pgsql: Avoid ERRCODE_INTERNAL_ERROR in oracle_compat.c functions.

2022-05-26 Thread Tom Lane
Avoid ERRCODE_INTERNAL_ERROR in oracle_compat.c functions. repeat() checked for integer overflow during its calculation of the required output space, but it just passed the resulting integer to palloc(). This meant that result sizes between 1GB and 2GB led to ERRCODE_INTERNAL_ERROR, "invalid memo

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.

2022-05-26 Thread Robert Haas
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff. Foreign tables can be partitioned, but previous documentation commits left the syntax synopsis both incomplete and incorrect. Justin Pryzby and Amit Langote Discussion: http://postgr.es/m/[email protected] Branc

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Remove misguided SSL key file ownership check in libpq.

2022-05-26 Thread Tom Lane
Remove misguided SSL key file ownership check in libpq. Commits a59c79564 et al. tried to sync libpq's SSL key file permissions checks with what we've used for years in the backend. We did not intend to create any new failure cases, but it turns out we did: restricting the key file's ownership bre

pgsql: Teach remove_unused_subquery_outputs about window run conditions

2022-05-26 Thread David Rowley
Teach remove_unused_subquery_outputs about window run conditions 9d9c02ccd added code to allow the executor to take shortcuts when quals on monotonic window functions guaranteed that once the qual became false it could never become true again. When possible, baserestrictinfo quals are converted t