pgsql: Doc: Update struct Trigger definition.

2022-09-02 Thread Etsuro Fujita
Doc: Update struct Trigger definition. Commit 487e9861d added a new field to struct Trigger, but failed to update the documentation to match; backpatch to v13 where that came in. Reviewed by Richard Guo. Discussion: https://postgr.es/m/CAPmGK17NY92CyxJ%2BBG7A3JZurmng4jfRfzPiBTtNupGMF0xW1g%40mai

pgsql: Doc: Update struct Trigger definition.

2022-09-02 Thread Etsuro Fujita
Doc: Update struct Trigger definition. Commit 487e9861d added a new field to struct Trigger, but failed to update the documentation to match; backpatch to v13 where that came in. Reviewed by Richard Guo. Discussion: https://postgr.es/m/CAPmGK17NY92CyxJ%2BBG7A3JZurmng4jfRfzPiBTtNupGMF0xW1g%40mai

pgsql: Doc: Update struct Trigger definition.

2022-09-02 Thread Etsuro Fujita
Doc: Update struct Trigger definition. Commit 487e9861d added a new field to struct Trigger, but failed to update the documentation to match; backpatch to v13 where that came in. Reviewed by Richard Guo. Discussion: https://postgr.es/m/CAPmGK17NY92CyxJ%2BBG7A3JZurmng4jfRfzPiBTtNupGMF0xW1g%40mai

pgsql: Doc: Update struct Trigger definition.

2022-09-02 Thread Etsuro Fujita
Doc: Update struct Trigger definition. Commit 487e9861d added a new field to struct Trigger, but failed to update the documentation to match; backpatch to v13 where that came in. Reviewed by Richard Guo. Discussion: https://postgr.es/m/CAPmGK17NY92CyxJ%2BBG7A3JZurmng4jfRfzPiBTtNupGMF0xW1g%40mai

pgsql: Expand the use of get_dirent_type(), shaving a few calls to stat

2022-09-02 Thread Michael Paquier
Expand the use of get_dirent_type(), shaving a few calls to stat()/lstat() Several backend-side loops scanning one or more directories with ReadDir() (WAL segment recycle/removal in xlog.c, backend-side directory copy, temporary file removal, configuration file parsing, some logical decoding logic

Re: pgsql: Remove further unwanted linker flags from perl_embed_ldflags

2022-09-02 Thread Michael Paquier
Hi Peter, On Tue, Aug 23, 2022 at 02:29:49PM +, Peter Eisentraut wrote: > Remove further unwanted linker flags from perl_embed_ldflags > > Remove the contents of $Config{ldflags} from ExtUtils::Embed's ldopts, > like we already do with $Config{ccdlflags}. Those flags are the > choices of tho

pgsql: Doc: fix column list vs. replica identity rules.

2022-09-02 Thread Amit Kapila
Doc: fix column list vs. replica identity rules. It was not strictly correct to say that a column list must always include replica identity columns because that is true for only updates and deletes. Author: Peter Smith Reviwed-by: Vignesh C, Amit Kapila Backpatch-through: 15, where it was introdu

pgsql: Doc: fix column list vs. replica identity rules.

2022-09-02 Thread Amit Kapila
Doc: fix column list vs. replica identity rules. It was not strictly correct to say that a column list must always include replica identity columns because that is true for only updates and deletes. Author: Peter Smith Reviwed-by: Vignesh C, Amit Kapila Backpatch-through: 15, where it was introdu

pgsql: Fix PL/Perl build on Cygwin

2022-09-02 Thread Peter Eisentraut
Fix PL/Perl build on Cygwin This was broken by b4e936859dc441102eb0b6fb7a104f3948c90490. The reason why this fixes it are not entirely clear, but it seemed the best way to get it working again. Discussion: https://www.postgresql.org/message-id/flat/8c4fcb72-2574-ff7c-4c25-1f032d4a2a57%40enterpr

pgsql: Remove unused code from sepgsql

2022-09-02 Thread Daniel Gustafsson
Remove unused code from sepgsql Commit 4232c4b40 removed all callers of sepgsql_check_perms but left the function in place. This removes the function as well. Reviewed-by: Robert Haas Discussion: https://postgr.es/m/3bd5c3bf-feca-4496-ae53-5e447997a...@yesql.se Branch -- master Details ---

pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.

2022-09-02 Thread Tom Lane
Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c th

pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.

2022-09-02 Thread Tom Lane
Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c th

pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.

2022-09-02 Thread Tom Lane
Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c th

pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.

2022-09-02 Thread Tom Lane
Fix oversight in recent MULTIEXPR_SUBLINK fix. Commits 3f7323cbb et al missed the possibility that the Params they are looking for could be buried under implicit coercions, as well as other stuff that processIndirection() could add to the original targetlist entry. Copy the code in ruleutils.c th

pgsql: Fix planner to consider matches to boolean columns in extension

2022-09-02 Thread Tom Lane
Fix planner to consider matches to boolean columns in extension indexes. The planner has to special-case indexes on boolean columns, because what we need for an indexscan on such a column is a qual of the shape of "boolvar = pseudoconstant". For plain bool constants, previous simplification will

pgsql: Fix cache invalidation bug in recovery_prefetch.

2022-09-02 Thread Thomas Munro
Fix cache invalidation bug in recovery_prefetch. XLogPageRead() can retry internally after a pread() system call has succeeded, in the case of short reads, and page validation failures while in standby mode (see commit 0668719801). Due to an oversight in commit 3f1ce973, these cases could leave s

pgsql: Fix cache invalidation bug in recovery_prefetch.

2022-09-02 Thread Thomas Munro
Fix cache invalidation bug in recovery_prefetch. XLogPageRead() can retry internally after a pread() system call has succeeded, in the case of short reads, and page validation failures while in standby mode (see commit 0668719801). Due to an oversight in commit 3f1ce973, these cases could leave s

pgsql: relnotes: improve collation check and ICU items

2022-09-02 Thread Bruce Momjian
relnotes: improve collation check and ICU items Reported-by: Matthias van de Meent Discussion: https://postgr.es/m/caeze2whrnat2g8upduhfqt1nwfv_jdugxaqu7ot4ry2l68o...@mail.gmail.com Backpatch-through: 15 only Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b9dce0d8aeb369f57a0480356fce8b6cb33fc86c Modified

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3eef32c58b438e08071acb22580162976bce680b Modified

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1525711588c87b80965594ff2249773d8d1ee5c9 Modified

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8ec6a4ef3c3a6aa08f2cc235fab8c691a8b2f341 Modified Files

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/170704da68c5150776c0ee4ed51350acde47b4a5 Modified

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0f590f0064b3a6f1a7492dcc2370819cda0a12c9 Modified

pgsql: doc: clarify recursion internal behavior

2022-09-02 Thread Bruce Momjian
doc: clarify recursion internal behavior Reported-by: Drew DeVault Discussion: https://postgr.es/m/20211018091720.31299-1-...@cmpwn.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/92cad1439f2b775211d34c7b8f42b87e02c68ace Modified

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/413074273918e223a496e0f5348c3b74c620b211 Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e5a5b97052bbeb24361b643881eb188b0b63f7e2 Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a78c38417a6030c900853a31b776265e57ac7e48 Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4dc98b4147e3212d7cfae4bd7e521c16a2bf7117 Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/adc15f49e68719ed55a2efb3942fcb5c89ed6d5f Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a3e88e5a099eed551110b6824b376d5a44ae Modified Files --

pgsql: doc: simplify docs about analyze and inheritance/partitions

2022-09-02 Thread Bruce Momjian
doc: simplify docs about analyze and inheritance/partitions Discussion: https://postgr.es/m/yxaqyijoslzgl...@momjian.us Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/75d5712452ee887e938535001f9efef337c644d9 Modified Files -- do