pgsql: Fix thinko in comment.

Fix thinko in comment. This comment has been wrong since its introduction in commit 0d5f05cde; backpatch to v12 where that came in. Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.pos

pgsql: Fix thinko in comment.

Fix thinko in comment. This comment has been wrong since its introduction in commit 0d5f05cde; backpatch to v12 where that came in. Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com Branch -- master Details --- https://git.postgresql

pgsql: Fix thinko in comment.

Fix thinko in comment. This comment has been wrong since its introduction in commit 0d5f05cde; backpatch to v12 where that came in. Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.pos

pgsql: Fix thinko in comment.

Fix thinko in comment. This comment has been wrong since its introduction in commit 0d5f05cde; backpatch to v12 where that came in. Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.pos

pgsql: Fix thinko in comment.

Fix thinko in comment. This comment has been wrong since its introduction in commit 0d5f05cde; backpatch to v12 where that came in. Discussion: https://postgr.es/m/CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5%3DqfcmTDh1iufUDnV_w%40mail.gmail.com Branch -- REL_15_STABLE Details --- https://git.pos

pgsql: Use min/max bounds defined by Zstd for compression level

Use min/max bounds defined by Zstd for compression level The bounds hardcoded in compression.c since ffd5365 (minimum at 1 and maximum at 22) do not match the reality of what zstd is able to handle, these values being available via ZSTD_maxCLevel() and ZSTD_minCLevel() at run-time. The maximum of

pgsql: Use min/max bounds defined by Zstd for compression level

Use min/max bounds defined by Zstd for compression level The bounds hardcoded in compression.c since ffd5365 (minimum at 1 and maximum at 22) do not match the reality of what zstd is able to handle, these values being available via ZSTD_maxCLevel() and ZSTD_minCLevel() at run-time. The maximum of

pgsql: Restore archive_command documentation

Restore archive_command documentation Commit 5ef1eefd76f404ddc59b885d50340e602b70f05f, which added archive_library, purged most mentions of archive_command from the documentation. This is inappropriate, since archive_command is still a feature in use and users will want to see information about i

pgsql: Restore archive_command documentation

Restore archive_command documentation Commit 5ef1eefd76f404ddc59b885d50340e602b70f05f, which added archive_library, purged most mentions of archive_command from the documentation. This is inappropriate, since archive_command is still a feature in use and users will want to see information about i

pgsql: Remove ALL keyword from TABLES IN SCHEMA for publication

Remove ALL keyword from TABLES IN SCHEMA for publication This may be a bit too subtle, but removing that word from there makes this clause no longer a perfect parallel of the GRANT variant "ALL TABLES IN SCHEMA": indeed, for publications what we record is the schema itself, not the tables therein,

pgsql: Remove ALL keyword from TABLES IN SCHEMA for publication

Remove ALL keyword from TABLES IN SCHEMA for publication This may be a bit too subtle, but removing that word from there makes this clause no longer a perfect parallel of the GRANT variant "ALL TABLES IN SCHEMA": indeed, for publications what we record is the schema itself, not the tables therein,

pgsql: Fix race condition where heap_delete() fails to pin VM page.

Fix race condition where heap_delete() fails to pin VM page. Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after buffer lock is re-acquired. Backpatching to the same version, 12. Discussion: https://postgr.es/m/caep4naw9jyqdkd_5y+-s2e4yiujq1vqiikfjygplshtp-k3...@mail.gmail.com

pgsql: Fix race condition where heap_delete() fails to pin VM page.

Fix race condition where heap_delete() fails to pin VM page. Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after buffer lock is re-acquired. Backpatching to the same version, 12. Discussion: https://postgr.es/m/caep4naw9jyqdkd_5y+-s2e4yiujq1vqiikfjygplshtp-k3...@mail.gmail.com

pgsql: Fix race condition where heap_delete() fails to pin VM page.

Fix race condition where heap_delete() fails to pin VM page. Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after buffer lock is re-acquired. Backpatching to the same version, 12. Discussion: https://postgr.es/m/caep4naw9jyqdkd_5y+-s2e4yiujq1vqiikfjygplshtp-k3...@mail.gmail.com

pgsql: Fix race condition where heap_delete() fails to pin VM page.

Fix race condition where heap_delete() fails to pin VM page. Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after buffer lock is re-acquired. Backpatching to the same version, 12. Discussion: https://postgr.es/m/caep4naw9jyqdkd_5y+-s2e4yiujq1vqiikfjygplshtp-k3...@mail.gmail.com

pgsql: Fix race condition where heap_delete() fails to pin VM page.

Fix race condition where heap_delete() fails to pin VM page. Similar to 5f12bc94dc, the code must re-check PageIsAllVisible() after buffer lock is re-acquired. Backpatching to the same version, 12. Discussion: https://postgr.es/m/caep4naw9jyqdkd_5y+-s2e4yiujq1vqiikfjygplshtp-k3...@mail.gmail.com

pgsql: Harmonize parameter names in ecpg code.

Harmonize parameter names in ecpg code. Make ecpg function declarations consistently use named parameters. Also make sure that the declarations use names that match corresponding names from function definitions. Like other recent commits that cleaned up function parameter names, this commit was

pgsql: Harmonize more lexer function parameter names.

Harmonize more lexer function parameter names. Make sure that function declarations use names that exactly match the corresponding names from function definitions for several "lexer adjacent" backend functions. These were missed by commit aab06442. Author: Peter Geoghegan Discussion: https://p

pgsql: Harmonize parameter names in contrib code.

Harmonize parameter names in contrib code. Make sure that function declarations use names that exactly match the corresponding names from function definitions in contrib code. Like other recent commits that cleaned up function parameter names, this commit was written with help from clang-tidy. A

pgsql: Harmonize parameter names in pg_dump/pg_dumpall.

Harmonize parameter names in pg_dump/pg_dumpall. Make sure that function declarations use names that exactly match the corresponding names from function definitions in pg_dump/pg_dumpall related code. Affected code happens to be inconsistent in how it applies conventions around how Archive and Ar

pgsql: Doc: adjust misleading phrasing of a few cross-references.

Doc: adjust misleading phrasing of a few cross-references. The pg_dump and pg_dumpall man pages referred to app-psql-patterns as appearing "below", which I suspect was copied-and-pasted from equivalent text in psql-ref.sgml rather than being actually thought through. At least to me, that phrasing

pgsql: Allow publications with schema and table of the same schema.

Allow publications with schema and table of the same schema. We previously thought that allowing such cases can confuse users when they specify DROP TABLES IN SCHEMA but that doesn't seem to be the case based on discussion. This helps to uplift the restriction during ALTER TABLE ... SET SCHEMA whi

pgsql: Allow publications with schema and table of the same schema.

Allow publications with schema and table of the same schema. We previously thought that allowing such cases can confuse users when they specify DROP TABLES IN SCHEMA but that doesn't seem to be the case based on discussion. This helps to uplift the restriction during ALTER TABLE ... SET SCHEMA whi

pgsql: ci: freebsd: Set extra_{lib,include}_dirs to /usr/local/...

ci: freebsd: Set extra_{lib,include}_dirs to /usr/local/... Ommitted in e6b6ea025cc, but necessary for libintl to be found. All other dependencies can be found via pkg-config (which searches in /usr/local/...) and thus worked even without adding the directories. Branch -- master Details