pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio

2022-11-09 Thread Tom Lane
Doc: add comments about PreventInTransactionBlock/IsInTransactionBlock. Add a little to the header comments for these functions to make it clearer what guarantees about commit behavior are provided to callers. (See commit f92944137 for context.) Although this is only a comment change, it's really

pgsql: Report a more useful error for reloptions on a partitioned table

2022-11-09 Thread Tom Lane
Report a more useful error for reloptions on a partitioned table. Previously, trying to set storage parameters on a partitioned table always led to "unrecognized parameter foo", because the code expected there might be some valid parameters; but there aren't any. The docs make clear that it's int

pgsql: Remove redundant declaration for XidInMVCCSnapshot

2022-11-09 Thread Alvaro Herrera
Remove redundant declaration for XidInMVCCSnapshot This was added for no good reason by c91560defc57, after b7eda3e0e334 had just moved the prototype from utils/tqual.h to utils/snapmgr.h. Author: Japin Li Discussion: https://postgr.es/m/[email protected]

pgsql: Apply a better fix to mdunlinkfork().

2022-11-09 Thread Tom Lane
Apply a better fix to mdunlinkfork(). Replace the stopgap fix I made in 0e758ae89 with a cleaner one. The real problem with 4ab5dae94 is that it contorted this function's logic substantially, by introducing a third code path that required different behavior in the function's main loop. That seem

pgsql: Apply a better fix to mdunlinkfork().

2022-11-09 Thread Tom Lane
Apply a better fix to mdunlinkfork(). Replace the stopgap fix I made in 0e758ae89 with a cleaner one. The real problem with 4ab5dae94 is that it contorted this function's logic substantially, by introducing a third code path that required different behavior in the function's main loop. That seem

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --

pgsql: Fix comment of SimpleLruInit() in slru.c

2022-11-09 Thread Michael Paquier
Fix comment of SimpleLruInit() in slru.c sync_handler was not mentioned in the comment block of the function. Oversight in dee663f. Author: Aleksander Alekseev Discussion: https://postgr.es/m/CAJ7c6TPUd9BwNY47TtMxaijLHSbyHNdhu=kvbgnvo_bi+oc...@mail.gmail.com Backpatch-through: 14 Branch --