Re: pgsql: Prevent port collisions between concurrent TAP tests

2022-11-26 Thread Michael Paquier
Hi Andrew, On Tue, Nov 22, 2022 at 03:56:43PM +, Andrew Dunstan wrote: > Prevent port collisions between concurrent TAP tests > > Currently there is a race condition where if concurrent TAP tests both > test that they can open a port they will assume that it is free and use > it, causing one

pgsql: Mark two signal flags as sig_atomic_t in pgbench and pg_test_fsy

2022-11-26 Thread Michael Paquier
Mark two signal flags as sig_atomic_t in pgbench and pg_test_fsync Two booleans used for timeout tracking were used within some SIGALRM signal handlers, but they were not declared as sig_atomic_t, so mark them as such. This has no consequence on WIN32 for both tools. Author: Ranier Vilela Review

Re: pgsql: Prevent port collisions between concurrent TAP tests

2022-11-26 Thread Andrew Dunstan
On 2022-11-26 Sa 06:15, Michael Paquier wrote: > Hi Andrew, > > On Tue, Nov 22, 2022 at 03:56:43PM +, Andrew Dunstan wrote: >> Prevent port collisions between concurrent TAP tests >> >> Currently there is a race condition where if concurrent TAP tests both >> test that they can open a port th

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Add portlock directory to .gitignore

2022-11-26 Thread Andrew Dunstan
Add portlock directory to .gitignore Commit 9b4eafcaf4 added creattion of a directory to reserve TAP test ports at the top of the build tree. In a non-vpath build this means at the top of the source tree, so it needs to be added to .gitignore. As suggested by Michael Paquier Backpatch to all liv

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4e9e1b2a625eccfdfd09b8fca9693dd1fe96f256 Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 inse

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/27a5a0ee20eaf01cdf53f48498379b19e8f52e83 Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 inse

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a2dcd78dd0837c5b705569f99d86ebf0d5a5725f Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 inse

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b85fd738529b345666c4a94ce837327a2f86d75e Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 inse

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ae0c48a59f747905f26acd38fecdc3e3f505b5b Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 inse

pgsql: Remove temporary portlock directory during make [dist]clean.

2022-11-26 Thread Tom Lane
Remove temporary portlock directory during make [dist]clean. Another oversight in 9b4eafcaf. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3274ec05c86730ff577f463e4e7b0259fb2bf684 Modified Files -- GNUmakefile.in | 4 ++-- 1 file changed, 2 insertions(

Re: pgsql: Prevent port collisions between concurrent TAP tests

2022-11-26 Thread Michael Paquier
On Sat, Nov 26, 2022 at 07:40:52AM -0500, Andrew Dunstan wrote: > Yes, good point. Will do. Thanks. -- Michael signature.asc Description: PGP signature