pgsql: doc: Re-order Table 28.2 "Collected Statistics Views"

2023-01-02 Thread Peter Eisentraut
doc: Re-order Table 28.2 "Collected Statistics Views" Make the order more sensible and repeatable. Comments have been added to guide future additions. Author: Peter Smith Reviewed-by: David G. Johnston Discussion: https://www.postgresql.org/message-id/flat/cahut+pv8oa7v06hjb3+hzctm2u-3ohwmdvx

pgsql: Push lpp variable closer to usage in heapgetpage()

2023-01-02 Thread Peter Eisentraut
Push lpp variable closer to usage in heapgetpage() Author: Melanie Plageman Discussion: https://www.postgresql.org/message-id/flat/caakru_ysonhksdyfcqjsktbsrd32dp-jjxmv7hl0bpd-z0t...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e351f85418313e97c2

pgsql: Add bt_multi_page_stats() function to contrib/pageinspect.

2023-01-02 Thread Tom Lane
Add bt_multi_page_stats() function to contrib/pageinspect. This is like the existing bt_page_stats() function, but it can report on a range of pages rather than just one at a time. I don't have a huge amount of faith in the portability of the new test cases, but they do pass in a 32-bit FreeBSD V

pgsql: Avoid special XID snapshotConflictHorizon values.

2023-01-02 Thread Peter Geoghegan
Avoid special XID snapshotConflictHorizon values. Don't allow VACUUM to WAL-log the value FrozenTransactionId as the snapshotConflictHorizon of freezing or visibility map related WAL records. The only special XID value that's an allowable snapshotConflictHorizon is InvalidTransactionId, which is

pgsql: Adjust VACUUM hastup LP_REDIRECT comments.

2023-01-02 Thread Peter Geoghegan
Adjust VACUUM hastup LP_REDIRECT comments. The term "truncation" has been ambiguous since commit 10a8d13823 added line pointer array truncation during heap pruning. Clear things up by specifying that we're talking about rel truncation here, to match nearby comments that apply to tuples with stora

pgsql: Update copyright for 2023

2023-01-02 Thread Bruce Momjian
Update copyright for 2023 Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fdaba0a2d749bff497313b584f86855a1440d43e Modified Files -- COPYRIGHT | 2 +- doc/src/sgml/legal.sgml | 6 +++--- 2 files changed, 4 insert

pgsql: Update copyright for 2023

2023-01-02 Thread Bruce Momjian
Update copyright for 2023 Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5a93c8f1847d34efe09dceea4717072480401dfe Modified Files -- COPYRIGHT | 2 +- doc/src/sgml/legal.sgml | 6 +++--- 2 files changed, 4 insert

pgsql: Update copyright for 2023

2023-01-02 Thread Bruce Momjian
Update copyright for 2023 Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/58dcac07ed347774d0fa5cc8e47dcd8462bdf136 Modified Files -- COPYRIGHT | 2 +- doc/src/sgml/legal.sgml | 6 +++--- 2 files changed, 4 insert

pgsql: Update copyright for 2023

2023-01-02 Thread Bruce Momjian
Update copyright for 2023 Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1fbcb1360bc19b89369209203ea7cc19b8cde224 Modified Files -- COPYRIGHT | 2 +- doc/src/sgml/legal.sgml | 6 +++--- 2 files changed, 4 insert

pgsql: Update copyright for 2023

2023-01-02 Thread Bruce Momjian
Update copyright for 2023 Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef3de5557687bdb60ab1a810c85a27094450f529 Modified Files -- COPYRIGHT | 2 +- doc/src/sgml/legal.sgml | 6 +++--- 2 files changed, 4 insert

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: Avoid reference to nonexistent array element in ExecInitAgg().

2023-01-02 Thread Tom Lane
Avoid reference to nonexistent array element in ExecInitAgg(). When considering an empty grouping set, we fetched phasedata->eqfunctions[-1]. Because the eqfunctions array is palloc'd, that would always be an aset pointer in released versions, and thus the code accidentally failed to malfunction

pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp

2023-01-02 Thread Andres Freund
perl: Hide warnings inside perl.h when using gcc compatible compiler New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC s

pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp

2023-01-02 Thread Andres Freund
perl: Hide warnings inside perl.h when using gcc compatible compiler New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC s

pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp

2023-01-02 Thread Andres Freund
perl: Hide warnings inside perl.h when using gcc compatible compiler New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC s

pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp

2023-01-02 Thread Andres Freund
perl: Hide warnings inside perl.h when using gcc compatible compiler New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC s

pgsql: perl: Hide warnings inside perl.h when using gcc compatible comp

2023-01-02 Thread Andres Freund
perl: Hide warnings inside perl.h when using gcc compatible compiler New versions of perl trigger warnings within perl.h with our compiler flags. At least -Wdeclaration-after-statement, -Wshadow=compatible-local are known to be problematic. To avoid these warnings, conditionally use #pragma GCC s

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231

pgsql: Fix typos in comments, code and documentation

2023-01-02 Thread Michael Paquier
Fix typos in comments, code and documentation While on it, newlines are removed from the end of two elog() strings. The others are simple grammar mistakes. One comment in pg_upgrade referred incorrectly to sequences since a7e5457. Author: Justin Pryzby Discussion: https://postgr.es/m/20221230231