pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Reject CancelRequestPacket having unexpected length.

2023-01-21 Thread Noah Misch
Reject CancelRequestPacket having unexpected length. When the length was too short, the server read outside the allocation. That yielded the same log noise as sending the correct length with (backendPID,cancelAuthCode) matching nothing. Change to a message about the unexpected length. Given the

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi

pgsql: Allow REPLICA IDENTITY to be set on an index that's not (yet) va

2023-01-21 Thread Tom Lane
Allow REPLICA IDENTITY to be set on an index that's not (yet) valid. The motivation for this change is that when pg_dump dumps a partitioned index that's marked REPLICA IDENTITY, it generates a command sequence that applies REPLICA IDENTITY before the partitioned index has been marked valid, causi