pgsql: Remove some non-ASCII symbols from a comment.

2023-04-15 Thread Tom Lane
Remove some non-ASCII symbols from a comment. Buildfarm member hamerkop is unhappy that daitch_mokotoff.c "contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss". There are a lot of non-ASCII characters in comments, bu

pgsql: Fix assignment to array of domain over composite, redux.

2023-04-15 Thread Tom Lane
Fix assignment to array of domain over composite, redux. Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through CoerceToDomain nodes. That's not sufficient, because since commit 04fe805a1 it's been possible for the planner to simplify CoerceToDomain to RelabelType when the domain h

pgsql: Fix assignment to array of domain over composite, redux.

2023-04-15 Thread Tom Lane
Fix assignment to array of domain over composite, redux. Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through CoerceToDomain nodes. That's not sufficient, because since commit 04fe805a1 it's been possible for the planner to simplify CoerceToDomain to RelabelType when the domain h

pgsql: Fix assignment to array of domain over composite, redux.

2023-04-15 Thread Tom Lane
Fix assignment to array of domain over composite, redux. Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through CoerceToDomain nodes. That's not sufficient, because since commit 04fe805a1 it's been possible for the planner to simplify CoerceToDomain to RelabelType when the domain h

pgsql: Fix assignment to array of domain over composite, redux.

2023-04-15 Thread Tom Lane
Fix assignment to array of domain over composite, redux. Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through CoerceToDomain nodes. That's not sufficient, because since commit 04fe805a1 it's been possible for the planner to simplify CoerceToDomain to RelabelType when the domain h

pgsql: Fix assignment to array of domain over composite, redux.

2023-04-15 Thread Tom Lane
Fix assignment to array of domain over composite, redux. Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through CoerceToDomain nodes. That's not sufficient, because since commit 04fe805a1 it's been possible for the planner to simplify CoerceToDomain to RelabelType when the domain h

Re: pgsql: Add grantable MAINTAIN privilege and pg_maintain role.

2023-04-15 Thread Peter Eisentraut
On 14.12.22 02:35, Jeff Davis wrote: Add grantable MAINTAIN privilege and pg_maintain role. Allows VACUUM, ANALYZE, REINDEX, REFRESH MATERIALIZED VIEW, CLUSTER, and LOCK TABLE. Effectively reverts 4441fc704d. Instead of creating separate privileges for VACUUM, ANALYZE, and other maintenance com

pgsql: Improve VACUUM/ANALYZE BUFFER_USAGE_LIMIT docs

2023-04-15 Thread David Rowley
Improve VACUUM/ANALYZE BUFFER_USAGE_LIMIT docs This addresses various deficiencies in the documentation for VACUUM and ANALYZE's BUFFER_USEAGE_LIMIT docs. Here we declare "size" in the syntax synopsis for VACUUM and ANALYZE's BUFFER_USAGE_LIMIT option and then define exactly what values can be sp