pgsql: Doc: clarify NULLS NOT DISTINCT use in unique indexes

2023-04-20 Thread David Rowley
Doc: clarify NULLS NOT DISTINCT use in unique indexes indexes-unique.html mentioned nothing about the availability of NULLS NOT DISTINCT to modify the NULLs-are-not-equal behavior of unique indexes. Add this to the synopsis and clarify what it does regarding NULLs. Author: David Gilman, David Row

pgsql: Doc: clarify NULLS NOT DISTINCT use in unique indexes

2023-04-20 Thread David Rowley
Doc: clarify NULLS NOT DISTINCT use in unique indexes indexes-unique.html mentioned nothing about the availability of NULLS NOT DISTINCT to modify the NULLs-are-not-equal behavior of unique indexes. Add this to the synopsis and clarify what it does regarding NULLs. Author: David Gilman, David Row

Re: pgsql: Fix list_copy_head() with empty Lists

2023-04-20 Thread Tom Lane
David Rowley writes: > Fix list_copy_head() with empty Lists > list_copy_head() given an empty List would crash from trying to > dereference the List to obtain its length. Since NIL is how we represent > an empty List, we should just be returning another empty List in this > case. I see that li

pgsql: Fix autovacuum cost debug logging

2023-04-20 Thread Daniel Gustafsson
Fix autovacuum cost debug logging Commit 7d71d3dd0 introduced finer grained updates of autovacuum option changes by increasing the frequency of reading the configuration file. The debug logging of cost parameter was however changed such that some initial values weren't logged. Fix by changing log

Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.

2023-04-20 Thread Andres Freund
On 2023-04-17 16:22:30 -0400, Andrew Dunstan wrote: > I am still having Windows issues with meson, but only with MSYS2. Any more details on that? I might be able to help out / improve things.

Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes.

2023-04-20 Thread Andrew Dunstan
On 2023-04-20 Th 11:06, Andres Freund wrote: On 2023-04-17 16:22:30 -0400, Andrew Dunstan wrote: I am still having Windows issues with meson, but only with MSYS2. Any more details on that? I might be able to help out / improve things. For some reason which makes no sense to me the buildfarm

pgsql: Fix list_copy_head() with empty Lists

2023-04-20 Thread David Rowley
Fix list_copy_head() with empty Lists list_copy_head() given an empty List would crash from trying to dereference the List to obtain its length. Since NIL is how we represent an empty List, we should just be returning another empty List in this case. list_copy_head() is new to v16, so let's fix

Re: pgsql: Fix list_copy_head() with empty Lists

2023-04-20 Thread David Rowley
On Fri, 21 Apr 2023 at 01:28, Tom Lane wrote: > I see that list_copy_head exists in v15 as well. It appears to have > no callers there, but we'd better fix it anyway in case somebody > back-patches a fix that uses it. Doh :-( Thanks for alerting me. I've just applied the patch to REL_15_STABL

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

pgsql: Use --strip-unneeded when stripping static libraries with GNU st

2023-04-20 Thread Tom Lane
Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces s

Re: pgsql: Fix list_copy_head() with empty Lists

2023-04-20 Thread Tom Lane
David Rowley writes: > Doh :-( Thanks for alerting me. I've just applied the patch to > REL_15_STABLE. > I kept the same commit message as master, which I think was the > correct thing to do, despite it containing information that wasn't > true. I know the script used to assist release note

pgsql: Remove io prefix from pg_stat_io columns

2023-04-20 Thread Michael Paquier
Remove io prefix from pg_stat_io columns a9c70b46 added the statistics view pg_stat_io which contained columns "io_context" and "io_object". Given that the columns are in the pg_stat_io view, the "io" prefix is somewhat redundant, so remove it. The code variables referring to these fields are ke

pgsql: Fix incorrect function name reference

2023-04-20 Thread David Rowley
Fix incorrect function name reference This function was renamed in 0c9d84427 but this comment wasn't updated. Author: Alexander Lakhin Discussion: https://postgr.es/m/699beab4-a6ca-92c9-f152-f559caf6d...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d91

pgsql: Remove unused global variable

2023-04-20 Thread David Rowley
Remove unused global variable Author: Alexander Lakhin Discussion: https://postgr.es/m/d5f68d19-c0fc-91a9-118d-7c6a5a3f5...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/84e05beb111335c0755ef37a7f4d64822170b76d Modified Files -- src/test/mod