pgsql: Fix last remaining uninitialized memory warnings

2023-08-09 Thread Peter Eisentraut
Fix last remaining uninitialized memory warnings gcc (version 13) fails to properly analyze the code due to the loop stop condition including `l != NULL`. Let's just help it out. Author: Tristan Partin Discussion: https://www.postgresql.org/message-id/flat/CT6HJ3U8068R.3A8SJMV02D9BC@gonk Branc

pgsql: struct PQcommMethods: use C99 designated initializers

2023-08-09 Thread Alvaro Herrera
struct PQcommMethods: use C99 designated initializers As in 98afa68d9352, 2c860777656a, et al. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c27f8621eedf744a7bc80e37dd2d3f0f559edf1b Modified Files -- src/backend/libpq/pqcomm.c | 12 ++-- src/ba

pgsql: doc: PG 16 relnotes, remove MAINTAIN item

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, remove MAINTAIN item Feature was removed by commit 957445996f. Discussion: 957445996f Backpatch-through: 16 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/86415153f47a4ad8e332262592e0a32f14f226c6 Modified Files -- doc/src

pgsql: doc: PG 16 relnotes, adjust \ef+ body comment to mention \sf

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, adjust \ef+ body comment to mention \sf Reported-by: Laurenz Albe Discussion: https://postgr.es/m/99d731a543501eb31bf7b8db43d231a037d7cc80.ca...@cybertec.at Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98

pgsql: doc: PG 16 relnotes, fix various typos

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, fix various typos Reported-by: Erik Rijkers Discussion: https://postgr.es/m/9c83328b-c0ff-070f-f2be-c3dce484e...@xs4all.nl Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e90308ae6b4a468d089733cc6f650bda144c0

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
Recalculate search_path after ALTER ROLE. Renaming a role can affect the meaning of the special string $user, so must cause search_path to be recalculated. Discussion: https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com Reviewed-by: Nathan Bossart, Michael Paquier Back

pgsql: doc: PG 16 relnotes, add Windows 10 huge pages fix

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, add Windows 10 huge pages fix Reported-by: Michael Paquier Discussion: https://postgr.es/m/ZL0M28/l+gryr...@paquier.xyz Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89cadf30c605d509f12b0b7f80119cbba38efc6e

pgsql: doc: PG 16 relnotes, merge and adjust CREATEROLE items

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, merge and adjust CREATEROLE items Reported-by: Noah Misch Discussion: https://postgr.es/m/20230805230847.ga1370...@rfd.leadboat.com Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6e1d1c58488e685370de0becc5a81

Re: pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
On Wed, 2023-08-09 at 20:31 +, Jeff Davis wrote: > Recalculate search_path after ALTER ROLE. Looks like this is causing some buildfarm failures for debug_parallel_query members related to the combination of parallel query, search_path, and renaming a role. I'm not sure yet, but this looks lik

Re: pgsql: Fix last remaining uninitialized memory warnings

2023-08-09 Thread Peter Smith
FYI - When building the latest HEAD I noticed some compiler warnings that seem related to this change pgbench.c: In function ‘evalStandardFunc’: pgbench.c:2242:2: warning: missing braces around initializer [-Wmissing-braces] PgBenchValue vargs[MAX_FARGS] = { 0 }; ^ pgbench.c:2242:2: warning: (

pgsql: doc: PG 16 relnotes, small wording improvement

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, small wording improvement Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0752461d3a1114d560225fae7522dde0ab544b63 Modified Files -- doc/src/sgml/release-16.sgml | 2 +- 1 file changed, 1 insertion(

pgsql: doc: PG 16 relnotes, move createuser and SCM items

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, move createuser and SCM items Reported-by: Noah Misch Discussion: https://postgr.es/m/20230805230847.ga1370...@rfd.leadboat.com Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc3e21282fae2b5b44c59e56e1fc49589

pgsql: doc: PG 16 relnotes, mark current as of 2023-08-09

2023-08-09 Thread Bruce Momjian
doc: PG 16 relnotes, mark current as of 2023-08-09 Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c8c033f721de1e25c90acf146fabee77c9dbf92e Modified Files -- doc/src/sgml/release-16.sgml | 2 +- 1 file changed, 1 inserti

pgsql: Use native CRC instructions on 64-bit LoongArch

2023-08-09 Thread John Naylor
Use native CRC instructions on 64-bit LoongArch As with the Intel and Arm CRC instructions, compiler intrinsics for them must be supported by the compiler. In contrast, no runtime check is needed. Aligned memory access is faster, so use the Arm coding as a model. YANG Xudong Discussion: https:/

Re: pgsql: Recalculate search_path after ALTER ROLE.

2023-08-09 Thread Jeff Davis
On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote: > I'm not sure yet, but this looks like a possible pre-existing bug, or > some incorrect assumption I made in fa2e874946. Before my commit the behavior is the same. Here's a minimal repro (debug_parallel_query set to 'on' or 'regress'): s1: