Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-19 Thread Tom Lane
Daniel Gustafsson writes: > llvmjit: Use explicit LLVMContextRef for inlining It looks like the v12 back-port of this wasn't quite right: canebrake and urutu have both been showing assertion failures down inside LLVMContextDispose since it went in. They aren't complaining about v13 and later, th

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

pgsql: Lock table in DROP STATISTICS

2023-11-19 Thread Tomas Vondra
Lock table in DROP STATISTICS The DROP STATISTICS code failed to properly lock the table, leading to ERROR: tuple concurrently deleted when executed concurrently with ANALYZE. Fixed by modifying RemoveStatisticsById() to acquire the same lock as ANALYZE. This function is called only by DROP

Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining

2023-11-19 Thread Daniel Gustafsson
> On 19 Nov 2023, at 17:05, Tom Lane wrote: > > Daniel Gustafsson writes: >> llvmjit: Use explicit LLVMContextRef for inlining > > It looks like the v12 back-port of this wasn't quite right: > canebrake and urutu have both been showing assertion failures > down inside LLVMContextDispose since i

pgsql: Prevent overflow for block number in buffile.c

2023-11-19 Thread Michael Paquier
Prevent overflow for block number in buffile.c As coded, the start block calculated by BufFileAppend() would overflow once more than 16k files are used with a default block size. This issue existed before b1e5c9fa9ac4, but there's no reason not to be clean about it. Per report from Coverity, wit