pgsql: doc: Update info on information schema usage tables

2023-11-30 Thread Peter Eisentraut
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it

pgsql: Fix an uninitialized access in hash_xlog_squeeze_page().

2023-11-30 Thread Amit Kapila
Fix an uninitialized access in hash_xlog_squeeze_page(). Commit 861f86beea changed hash_xlog_squeeze_page() to start reading the write buffer conditionally but forgot to initialize it leading to an uninitialized access. Reported-by: Alexander Lakhin Author: Hayato Kuroda Reviewed-by: Alexander

pgsql: Adjust obsolete comment explaining set_stack_base().

2023-11-30 Thread Thomas Munro
Adjust obsolete comment explaining set_stack_base(). Commit 7389aad6 removed the notion of backends started from inside a signal handler. A stray comment still referred to them, while explaining the need for a call to set_stack_base(). That leads to the question of whether we still need the

pgsql: Adjust obsolete comment explaining set_stack_base().

2023-11-30 Thread Thomas Munro
Adjust obsolete comment explaining set_stack_base(). Commit 7389aad6 removed the notion of backends started from inside a signal handler. A stray comment still referred to them, while explaining the need for a call to set_stack_base(). That leads to the question of whether we still need the

pgsql: meson: Stop using deprecated way getting path of files

2023-11-30 Thread Andres Freund
meson: Stop using deprecated way getting path of files The just released meson 1.3 strongly deprecated a hack we were using, emitting a noisy warning (the hack basically depended on an implementation detail to work). Turns out there has been a better way available for a while, I just hadn't found

pgsql: meson: Stop using deprecated way getting path of files

2023-11-30 Thread Andres Freund
meson: Stop using deprecated way getting path of files The just released meson 1.3 strongly deprecated a hack we were using, emitting a noisy warning (the hack basically depended on an implementation detail to work). Turns out there has been a better way available for a while, I just hadn't found

pgsql: doc: Update info on information schema usage tables

2023-11-30 Thread Peter Eisentraut
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it

pgsql: doc: Update info on information schema usage tables

2023-11-30 Thread Peter Eisentraut
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it

pgsql: doc: Update info on information schema usage tables

2023-11-30 Thread Peter Eisentraut
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it

pgsql: Remove redundant setting of hashkey after insertion

2023-11-30 Thread John Naylor
Remove redundant setting of hashkey after insertion It's not necessary to fill the key field in most cases, since hash_search has already done that. Some existing call sites have an assert or comment that this contract has been fulfilled, but those are quite old and that practice seems

pgsql: Fix spelling and punctuation

2023-11-30 Thread Daniel Gustafsson
Fix spelling and punctuation Remove trailing periods from pg_log_error emitted strings as only hint and detail level error messages should be punctuated. Also reword the usage screen which was missing a word. Author: Kyotaro Horiguchi Discussion:

pgsql: Fix array subscript warnings

2023-11-30 Thread Daniel Gustafsson
Fix array subscript warnings Commit a5cf808be55 accidentally passed signed chars to isalpha and isspace in the parser code which leads to undefined behavior. Fix by casting the parameters to unsigned chars. Author: Pavel Stehule Reported-by: Tom Lane Reported-by: Michael Paquier Discussion:

pgsql: Add missing file to nls Makefile

2023-11-30 Thread Daniel Gustafsson
Add missing file to nls Makefile Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20231130.120009.1370713511317755874.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c3f4a84481b6a8d84b1928165a7bf459e5304ed8 Modified Files

pgsql: Fix warning due non-standard inline declaration in 4ed8f0913bfdb

2023-11-30 Thread Alexander Korotkov
Fix warning due non-standard inline declaration in 4ed8f0913bfdb5f355 Reported-by: Alexander Lakhin, Tom Lane Author: Pavel Borisov Discussion: https://postgr.es/m/55d8800f-4a80-5256-1e84-246fbe79a...@gmail.com Branch -- master Details ---

pgsql: Fix typo in 5a1dfde8334b

2023-11-30 Thread Alexander Korotkov
Fix typo in 5a1dfde8334b Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/55d8800f-4a80-5256-1e84-246fbe79a...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ae2ccf66a261caac9701986597e3f29188f890d6 Modified Files --

pgsql: Print lwlock stats also for aux processes, when built with LWLOC

2023-11-30 Thread Heikki Linnakangas
Print lwlock stats also for aux processes, when built with LWLOCK_STATS InitAuxiliaryProcess() closely resembles InitProcess(), but it didn't call InitLWLockAccess(). But because InitLWLockAccess() is a no-op unless compiled with LWLOCK_STATS, and everything works even if it's not called, the