Re: pgsql: Support C.UTF-8 locale in the new builtin collation provider.

2024-05-02 Thread Peter Eisentraut
On 19.03.24 23:29, Jeff Davis wrote: Support C.UTF-8 locale in the new builtin collation provider. This commit changed the functions builtin_locale_encoding() and builtin_validate_locale() in pg_locale.c, but did not update the comments that claim that "C" is the only supported locale name.

pgsql: doc: Fix incorrectly spelled structname

2024-05-02 Thread Daniel Gustafsson
doc: Fix incorrectly spelled structname Commit 61461a300c1 accidentally misspelled the PGcancelConn struct using the PQ prefix (which admittedly is a very easy typo to make). Reported off-list. Reported-by: Alexander Lakhin Branch -- master Details --- https://git.postgresql.org/pg/com

pgsql: Disallow NO INHERIT not-null constraints on partitioned tables

2024-05-02 Thread Alvaro Herrera
Disallow NO INHERIT not-null constraints on partitioned tables Such constraints are semantically useless and only bring weird cases along, so reject them. As a side effect, we can no longer have "throwaway" constraints in pg_dump for primary keys in partitioned tables, but since they don't serve

Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

2024-05-02 Thread Daniel Gustafsson
> On 30 Apr 2024, at 07:26, Heikki Linnakangas > wrote: > Fix compilation on OpenSSL 1.0.2 and LibreSSL > > SSL_AD_NO_APPLICATION_PROTOCOL was introduced in OpenSSL 1.1.0. +* https://github.com/openssl/openssl/issues/24300. This is available in +* OpenSSL 1.1.0 and later, but

Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

2024-05-02 Thread Heikki Linnakangas
On 02/05/2024 12:09, Daniel Gustafsson wrote: On 30 Apr 2024, at 07:26, Heikki Linnakangas wrote: Fix compilation on OpenSSL 1.0.2 and LibreSSL SSL_AD_NO_APPLICATION_PROTOCOL was introduced in OpenSSL 1.1.0. +* https://github.com/openssl/openssl/issues/24300. This is available in

Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

2024-05-02 Thread Daniel Gustafsson
> On 2 May 2024, at 11:30, Heikki Linnakangas wrote: > > On 02/05/2024 12:09, Daniel Gustafsson wrote: >>> On 30 Apr 2024, at 07:26, Heikki Linnakangas >>> wrote: >>> Fix compilation on OpenSSL 1.0.2 and LibreSSL >>> >>> SSL_AD_NO_APPLICATION_PROTOCOL was introduced in OpenSSL 1.1.0. >> +

Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

2024-05-02 Thread Heikki Linnakangas
On 02/05/2024 13:24, Daniel Gustafsson wrote: On 2 May 2024, at 11:30, Heikki Linnakangas wrote: And I don't see the symbol in a fresh checkout of the portable libressl repository at https://github.com/libressl/portable. The portable repo only contains the portable parts, did you pull the lib

pgsql: Rename libpq trace internal functions

2024-05-02 Thread Peter Eisentraut
Rename libpq trace internal functions libpq's pqTraceOutputMessage() used to look like this: case 'Z': /* Ready For Query */ pqTraceOutputZ(conn->Pfdebug, message, &logCursor); break; Commit f4b54e1ed98 introduced macros for protocol characters, so now it looks

pgsql: Disallow direct change of NO INHERIT of not-null constraints

2024-05-02 Thread Alvaro Herrera
Disallow direct change of NO INHERIT of not-null constraints We support changing NO INHERIT constraint to INHERIT for constraints in child relations when adding a constraint to some ancestor relation, and also during pg_upgrade's schema restore; but other than those special cases, command ALTER TA

pgsql: Throw a more on-point error for publications depending on column

2024-05-02 Thread Tom Lane
Throw a more on-point error for publications depending on columns. Same as 42b041243, except that the trouble case is a publication WHERE clause that depends on a column. Again reported by Alexander Lakhin. Back-patch to v15 where we added publication WHERE clauses. Discussion: https://postgr.e

pgsql: Throw a more on-point error for publications depending on column

2024-05-02 Thread Tom Lane
Throw a more on-point error for publications depending on columns. Same as 42b041243, except that the trouble case is a publication WHERE clause that depends on a column. Again reported by Alexander Lakhin. Back-patch to v15 where we added publication WHERE clauses. Discussion: https://postgr.e

pgsql: Throw a more on-point error for publications depending on column

2024-05-02 Thread Tom Lane
Throw a more on-point error for publications depending on columns. Same as 42b041243, except that the trouble case is a publication WHERE clause that depends on a column. Again reported by Alexander Lakhin. Back-patch to v15 where we added publication WHERE clauses. Discussion: https://postgr.e