pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

2024-05-26 Thread Michael Paquier
Fix potential NULL pointer dereference in getIdentitySequence() The function invokes SearchSysCacheAttNum() and SearchSysCacheAttName(). They may respectively return 0 for the attribute number or NULL for the attribute name if the attribute does not exist, without any kind of error handling. The

Re: pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

2024-05-26 Thread Andrew Dunstan
On 2024-05-26 Su 07:58, Michael Paquier wrote: Fix potential NULL pointer dereference in getIdentitySequence() The function invokes SearchSysCacheAttNum() and SearchSysCacheAttName(). They may respectively return 0 for the attribute number or NULL for the attribute name if the attribute does n

pgsql: Fix meson uuid header check so it works with MSVC

2024-05-26 Thread Andrew Dunstan
Fix meson uuid header check so it works with MSVC The OSSP uuid.h file includes unistd.h, so to use it with MSVC we need to include the postgres include directories so it picks up our version of that in src/include/port/win32_msvc. Adjust the meson test accordingly. Branch -- master Details

Re: pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

2024-05-26 Thread Tom Lane
Andrew Dunstan writes: > On 2024-05-26 Su 07:58, Michael Paquier wrote: >> Fix potential NULL pointer dereference in getIdentitySequence() > This appears to have upset a number of buildfarm members It's hard to see how that patch would have broken "configure", and besides that the failures start

Re: pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

2024-05-26 Thread Andrew Dunstan
On 2024-05-26 Su 17:51, Tom Lane wrote: Andrew Dunstan writes: On 2024-05-26 Su 07:58, Michael Paquier wrote: Fix potential NULL pointer dereference in getIdentitySequence() This appears to have upset a number of buildfarm members It's hard to see how that patch would have broken "configure

Re: pgsql: Fix potential NULL pointer dereference in getIdentitySequence()

2024-05-26 Thread Michael Paquier
On Sun, May 26, 2024 at 06:43:50PM -0400, Andrew Dunstan wrote: > Oops, sorry for the noise. I just looked at a few failures and this was what > I saw. Thanks for the heads-up. I saw the failures before your message, panicked at first, and then noticed that it was unrelated. -- Michael signatur