pgsql: meson: Fix import library name in Windows

2024-06-20 Thread Peter Eisentraut
meson: Fix import library name in Windows This changes the import library name from 'postgres.exe.lib' to 'postgres.lib', which is what it was with the old MSVC build system. Extension builds use that name. Bug: #18513 Reported-by: Muralikrishna Bandaru Branch -- master Details --- htt

pgsql: Unify some error messages

2024-06-20 Thread Peter Eisentraut
Unify some error messages Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/95b44bb025b5d13c673662af68a218bd1873861f Modified Files -- contrib/pg_prewarm/autoprewarm.c | 2 +- src/backend/postmaster/bgworker.c | 2 +- 2 files changed, 2 insertions(+), 2 del

pgsql: Fix redundancy in error messages

2024-06-20 Thread Peter Eisentraut
Fix redundancy in error messages pg_log_error() already prints the program name, so we don't need to print it again inside the message. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/16a3415440ecf2f5cd02848fc05cbfe040ce14c2 Modified Files -- src/bin/pg

pgsql: pg_dump: Fix weird error message composition

2024-06-20 Thread Peter Eisentraut
pg_dump: Fix weird error message composition The previous way could make it look like "stdin" was the actual input file name. Write it as two separate messages instead. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3639d08e2f36f76e9a626c60b534c7fe204f329c Modifi

pgsql: pg_createsubscriber: Indent --help output correctly

2024-06-20 Thread Peter Eisentraut
pg_createsubscriber: Indent --help output correctly It was using 1 space indent instead of the 2 spaces used everywhere else. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d048a327890851f37c8a0d0b8522cb8064ad7cfc Modified Files -- src/bin/pg_basebacku

pgsql: pg_combinebackup: Fix small mistake in --help output

2024-06-20 Thread Peter Eisentraut
pg_combinebackup: Fix small mistake in --help output It was not showing that the --output option takes an argument. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab4346ebbfef44db857321d74bc0c31e03a72514 Modified Files -- src/bin/pg_combinebackup/pg_co

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 Thread Tom Lane
Don't throw an error if a queued AFTER trigger no longer exists. afterTriggerInvokeEvents and AfterTriggerExecute have always treated it as an error if the trigger OID mentioned in a queued after-trigger event can't be found. However, that fails to account for the edge case where the trigger's be

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: Doc: Generated columns are skipped for logical replication.

2024-06-20 Thread Amit Kapila
Doc: Generated columns are skipped for logical replication. Add a note in docs that generated columns are skipped for logical replication. Author: Peter Smith Reviewed-by: Peter Eisentraut Backpatch-through: 12 Discussion: https://postgr.es/m/CAHut+PuXb1GLQztQkoWzYjSwkAZZ0dgCJaAHyJtZF3kmtcL=k...

pgsql: doc PG 17 relnotes: remove mention of undocumented GUC

2024-06-20 Thread Bruce Momjian
doc PG 17 relnotes: remove mention of undocumented GUC GUC is trace_connection_negotiation. If it is undocumented, we should not mention it in the release notes. Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/95cabf542f04b634303f899600e

pgsql: parse_manifest: Use const char *

2024-06-20 Thread Peter Eisentraut
parse_manifest: Use const char * This adapts the manifest parsing code to take advantage of the const-ified jsonapi. Reviewed-by: Andrew Dunstan Discussion: https://www.postgresql.org/message-id/flat/f732b014-f614-4600-a437-dba5a2c3738b%40eisentraut.org Branch -- master Details --- ht

pgsql: jsonapi: Use const char *

2024-06-20 Thread Peter Eisentraut
jsonapi: Use const char * Apply const qualifiers to char * arguments and fields throughout the jsonapi. This allows the top-level APIs such as pg_parse_json_incremental() to declare their input argument as const. It also reduces the number of unconstify() calls. Reviewed-by: Andrew Dunstan Disc

pgsql: jsonapi: Use size_t

2024-06-20 Thread Peter Eisentraut
jsonapi: Use size_t Use size_t instead of int for object sizes in the jsonapi. This makes the API better self-documenting. Reviewed-by: Andrew Dunstan Discussion: https://www.postgresql.org/message-id/flat/f732b014-f614-4600-a437-dba5a2c3738b%40eisentraut.org Branch -- master Details ---

pgsql: Fix make build on MinGW

2024-06-20 Thread Peter Eisentraut
Fix make build on MinGW Revert a couple of the simplifications done in commit 721856ff24b because platforms without ln -s, where LN_S='cp -pR', such as MinGW, required the specific previous incantations. Reported-by: Noah Misch Discussion: https://www.postgresql.org/message-id/20240616193448...