pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Remove redundant perl version checks

2024-06-26 Thread Andrew Dunstan
Remove redundant perl version checks Commit 4c1532763a removed some redundant uses of 'use 5.008001;' in perl scripts, including in plperl's plc_perlboot.pl. Because it made other changes it wasn't backpatched. However, now this is causing a failure on back branches when built with bleeding edge p

pgsql: Fix partition pruning setup during DETACH CONCURRENTLY

2024-06-26 Thread Alvaro Herrera
Fix partition pruning setup during DETACH CONCURRENTLY When detaching partition in concurrent mode, it's possible for partition descriptors to not match the set that was recently seen when the plan was made, causing an assertion failure or (in production builds) failure to construct a working plan

pgsql: Fix nbtree array unsatisfied inequality check.

2024-06-26 Thread Peter Geoghegan
Fix nbtree array unsatisfied inequality check. _bt_advance_array_keys didn't take sufficient care at the point where it decides whether to start a new primitive index scan based on a call to _bt_check_compare against finaltup (a call with the scan direction flipped around). The final decision was

pgsql: Use PqMsg_* macros in fe-auth.c.

2024-06-26 Thread Nathan Bossart
Use PqMsg_* macros in fe-auth.c. Commit f4b54e1ed9, which introduced macros for protocol characters, missed updating a few places in fe-auth.c. Author: Jelte Fennema-Nio Discussion: https://postgr.es/m/CAGECzQSoPHtZ4xe0raJ6FYSEiPPS%2BYWXBhOGo%2BY1YecLgknF3g%40mail.gmail.com Branch -- master

pgsql: doc PG 17 relnotes: add item about pg_collation column renames

2024-06-26 Thread Bruce Momjian
doc PG 17 relnotes: add item about pg_collation column renames Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwYRw30QaWrSsL57k3L_=zdq4jtgy9pgnnhm42b7fgj...@mail.gmail.com Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commit

Re: pgsql: doc PG 17 relnotes: add item about pg_collation column renames

2024-06-26 Thread David G. Johnston
On Wed, Jun 26, 2024 at 10:14 AM Bruce Momjian wrote: > doc PG 17 relnotes: add item about pg_collation column renames > > + pg_collation.daticulocale The daticulocale name (dat prefix) exists on pg_database, not pg_collation. David J.

pgsql: doc PG 17 relnotes: fix system catalog name mistake

2024-06-26 Thread Bruce Momjian
doc PG 17 relnotes: fix system catalog name mistake Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwygkaouao4dxuqwhbg+vyu4xb5tgpudndofma0afty...@mail.gmail.com Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f92fd1

Re: pgsql: doc PG 17 relnotes: add item about pg_collation column renames

2024-06-26 Thread Bruce Momjian
On Wed, Jun 26, 2024 at 10:18:45AM -0700, David G. Johnston wrote: > On Wed, Jun 26, 2024 at 10:14 AM Bruce Momjian wrote: > > doc PG 17 relnotes:  add item about pg_collation column renames > > > >  +     pg_collation.daticulocale structfield> > > The daticulocale name (dat prefix) exist

Re: pgsql: doc PG 17 relnotes: add item about pg_collation column renames

2024-06-26 Thread Bruce Momjian
On Wed, Jun 26, 2024 at 03:08:50PM -0400, Bruce Momjian wrote: > > The daticulocale name (dat prefix) exists on pg_database, not pg_collation. > > Thank you very much, fixed. I am not sure why, but when I am working on > the release notes for hours, I am focused, but when I do one-off fixes, > I

pgsql: Fix bugs in MultiXact truncation

2024-06-26 Thread Heikki Linnakangas
Fix bugs in MultiXact truncation 1. TruncateMultiXact() performs the SLRU truncations in a critical section. Deleting the SLRU segments calls ForwardSyncRequest(), which will try to compact the request queue if it's full (CompactCheckpointerRequestQueue()). That in turn allocates memory, which is

pgsql: Fix bugs in MultiXact truncation

2024-06-26 Thread Heikki Linnakangas
Fix bugs in MultiXact truncation 1. TruncateMultiXact() performs the SLRU truncations in a critical section. Deleting the SLRU segments calls ForwardSyncRequest(), which will try to compact the request queue if it's full (CompactCheckpointerRequestQueue()). That in turn allocates memory, which is

pgsql: Fix bugs in MultiXact truncation

2024-06-26 Thread Heikki Linnakangas
Fix bugs in MultiXact truncation 1. TruncateMultiXact() performs the SLRU truncations in a critical section. Deleting the SLRU segments calls ForwardSyncRequest(), which will try to compact the request queue if it's full (CompactCheckpointerRequestQueue()). That in turn allocates memory, which is

pgsql: Fix bugs in MultiXact truncation

2024-06-26 Thread Heikki Linnakangas
Fix bugs in MultiXact truncation 1. TruncateMultiXact() performs the SLRU truncations in a critical section. Deleting the SLRU segments calls ForwardSyncRequest(), which will try to compact the request queue if it's full (CompactCheckpointerRequestQueue()). That in turn allocates memory, which is

pgsql: Fix overflow with pgstats DSA reference count

2024-06-26 Thread Michael Paquier
Fix overflow with pgstats DSA reference count When pgstats is initialized for a backend, it uses dsa_attach_in_place() without a "segment" provided. Hence, no callback is registered to automatically release the DSA attached once a backend exits. Not doing any cleanup causes the reference count o

pgsql: Fix overflow with pgstats DSA reference count

2024-06-26 Thread Michael Paquier
Fix overflow with pgstats DSA reference count When pgstats is initialized for a backend, it uses dsa_attach_in_place() without a "segment" provided. Hence, no callback is registered to automatically release the DSA attached once a backend exits. Not doing any cleanup causes the reference count o

pgsql: Fix overflow with pgstats DSA reference count

2024-06-26 Thread Michael Paquier
Fix overflow with pgstats DSA reference count When pgstats is initialized for a backend, it uses dsa_attach_in_place() without a "segment" provided. Hence, no callback is registered to automatically release the DSA attached once a backend exits. Not doing any cleanup causes the reference count o

pgsql: Drop the temporary tuple slots allocated by pgoutput.

2024-06-26 Thread Amit Kapila
Drop the temporary tuple slots allocated by pgoutput. In pgoutput, when converting the child table's tuple format to match the parent table's, we temporarily create a new slot to store the converted tuple. However, we missed to drop such temporary slots, leading to resource leakage. Reported-by:

pgsql: Drop the temporary tuple slots allocated by pgoutput.

2024-06-26 Thread Amit Kapila
Drop the temporary tuple slots allocated by pgoutput. In pgoutput, when converting the child table's tuple format to match the parent table's, we temporarily create a new slot to store the converted tuple. However, we missed to drop such temporary slots, leading to resource leakage. Reported-by:

pgsql: Drop the temporary tuple slots allocated by pgoutput.

2024-06-26 Thread Amit Kapila
Drop the temporary tuple slots allocated by pgoutput. In pgoutput, when converting the child table's tuple format to match the parent table's, we temporarily create a new slot to store the converted tuple. However, we missed to drop such temporary slots, leading to resource leakage. Reported-by: