pgsql: Apply PGDLLIMPORT markings to some GUC variables

2024-08-14 Thread Peter Eisentraut
Apply PGDLLIMPORT markings to some GUC variables According to the commit message in 8ec569479, we must have all variables in header files marked with PGDLLIMPORT. In commit d3cc5ffe81f6 some variables were moved from launch_backend.c file to several header files. This adds PGDLLIMPORT to moved va

pgsql: libpq: Trace responses to SSLRequest and GSSENCRequest

2024-08-14 Thread Alvaro Herrera
libpq: Trace responses to SSLRequest and GSSENCRequest Since these are single bytes instead of v2 or v3 messages they need custom tracing logic. These "messages" don't even have official names in the protocol specification, so I (Jelte) called them SSLResponse and GSSENCResponse here. Author: Je

pgsql: Add a couple of recent commits to .git-blame-ignore-revs.

2024-08-14 Thread Nathan Bossart
Add a couple of recent commits to .git-blame-ignore-revs. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ef6e028f05b3e4ab23c5edfdfff457e0d2a649f6 Modified Files -- .git-blame-ignore-revs | 6 ++ 1 file changed, 6 insertions(+)

Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe

2024-08-14 Thread Alexander Korotkov
On Wed, Aug 14, 2024 at 5:13 AM Alexander Korotkov wrote: > On Tue, Aug 13, 2024 at 1:30 AM Michael Paquier wrote: > > > On Aug 13, 2024, at 6:35, Alexander Korotkov > > > wrote:. > > > > > > As pointed by Noah Misch [1], unlike the commit the patch [2] also > > > changed segment-returning func

Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe

2024-08-14 Thread Michael Paquier
> On Aug 15, 2024, at 6:26, Alexander Korotkov wrote: > I mean, I'd like to push it if you don't object. > If you object and like to push it yourself, feel free to use this patch. I’d like to take a look at what you have here to get an opinion. Could you wait for a few days? -- Michael

Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe

2024-08-14 Thread Alexander Korotkov
On Thu, Aug 15, 2024 at 2:07 AM Michael Paquier wrote: > > On Aug 15, 2024, at 6:26, Alexander Korotkov wrote: > > I mean, I'd like to push it if you don't object. > > If you object and like to push it yourself, feel free to use this patch. > > I’d like to take a look at what you have here to get

pgsql: Improve ALTER PUBLICATION validation and error messages

2024-08-14 Thread David Rowley
Improve ALTER PUBLICATION validation and error messages Attempting to add a system column for a table to an existing publication would result in the not very intuitive error message of: ERROR: negative bitmapset member not allowed Here we improve that to have it display the same error message a

pgsql: Fix doc typo: unicode_assigned() return type.

2024-08-14 Thread Jeff Davis
Fix doc typo: unicode_assigned() return type. Reported-by: Hironobu SUZUKI Discussion: https://postgr.es/m/5dd88820-bb00-4b90-904b-738ea2e4e...@interdb.jp Backpatch-through: 17 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a3c6aa42ee0d625a55e73e17230db3eaeed3566c

pgsql: Fix doc typo: unicode_assigned() return type.

2024-08-14 Thread Jeff Davis
Fix doc typo: unicode_assigned() return type. Reported-by: Hironobu SUZUKI Discussion: https://postgr.es/m/5dd88820-bb00-4b90-904b-738ea2e4e...@interdb.jp Backpatch-through: 17 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/225483238d3e46669c9d73f8faead7aff5

pgsql: Variable renaming in dbcommands.c

2024-08-14 Thread Peter Eisentraut
Variable renaming in dbcommands.c There were several sets of very similar local variable names, such as "downer" and "dbowner", which was very confusing and error-prone. Rename the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c. Reviewed-by: Daniel Gustafsson Discussion