pgsql: psql: Tab completion for ALTER TYPE ... CASCADE/RESTRICT

2024-12-16 Thread Tomas Vondra
psql: Tab completion for ALTER TYPE ... CASCADE/RESTRICT Updates table completion for ALTER TYPE to offer CASCADE/RESTRICT for a number of actions on attributes: ALTER TYPE ... ADD/DROP/RENAME ATTRIBUTE ... [CASCADE|RESTRICT] ALTER TYPE ... TYPE ... [CASCADE|RESTRICT] Author: Kirill Resh

pgsql: psql: Tab completion for CREATE TEMP TABLE ... USING

2024-12-16 Thread Tomas Vondra
psql: Tab completion for CREATE TEMP TABLE ... USING The USING keyword was offered only for persistent tables, not for temporary ones. So improve that. Author: Kirill Reshke Reviewed-By: Karina Litskevich Discussion: https://postgr.es/m/CALdSSPhVELkvutquqrDB=Ujfq_Pjz=6jn-kzh+291kpnvil...@mail.gm

pgsql: psql: Tab completion for CREATE MATERIALIZED VIEW ... USING

2024-12-16 Thread Tomas Vondra
psql: Tab completion for CREATE MATERIALIZED VIEW ... USING The tab completion didn't offer USING for CREATE MATERIALIZED VIEW, so add it, and offer a list of access methods, followed by SELECT. Author: Kirill Reshke Reviewed-By: Karina Litskevich Discussion: https://postgr.es/m/CALdSSPhVELkvutq

pgsql: psql: Tab completion for ALTER TYPE ... ADD ATTRIBUTE

2024-12-16 Thread Tomas Vondra
psql: Tab completion for ALTER TYPE ... ADD ATTRIBUTE Improve psql tab completion for ALTER TYPE ... ADD ATTRIBUTE to offer a list of existing data types (until now no options were offered). Author: Kirill Reshke Reviewed-By: Karina Litskevich Discussion: https://postgr.es/m/CALdSSPhVELkvutquqrD

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: Make 009_twophase.pl test pass with recovery_min_apply_delay set

2024-12-16 Thread Heikki Linnakangas
Make 009_twophase.pl test pass with recovery_min_apply_delay set The test failed if you ran the regression tests with TEMP_CONFIG with recovery_min_apply_delay = '500ms'. Fix the race condition by waiting for transaction to be applied in the replica, like in a few other tests. The failing test wa

pgsql: psql: Tab completion for JOIN ... USING column list

2024-12-16 Thread Tomas Vondra
psql: Tab completion for JOIN ... USING column list For JOIN ... USING, offer attribute names for the first member of the column list. Author: Andreas Karlsson Reviewed-By: Tomas Vondra Discussion: https://postgr.es/m/3a7e27bc-d6ed-4cb0-9b21-f21143fc1...@proxel.se Branch -- master Details -

pgsql: psql: Tab completion for JOIN ... ON/USING

2024-12-16 Thread Tomas Vondra
psql: Tab completion for JOIN ... ON/USING Offer ON/USING clauses for join types that require join conditions (i.e. anything except for NATURAL/CROSS joins). Author: Andreas Karlsson Reviewed-By: Tomas Vondra Discussion: https://postgr.es/m/3a7e27bc-d6ed-4cb0-9b21-f21143fc1...@proxel.se Branch -

pgsql: psql: Tab completion for LATERAL joins

2024-12-16 Thread Tomas Vondra
psql: Tab completion for LATERAL joins When listing selectable objects after a JOIN, offer also LATERAL. Author: Andreas Karlsson Reviewed-By: Tomas Vondra Discussion: https://postgr.es/m/3a7e27bc-d6ed-4cb0-9b21-f21143fc1...@proxel.se Branch -- master Details --- https://git.postgresql.

pgsql: Refactor string case conversion into provider-specific files.

2024-12-16 Thread Jeff Davis
Refactor string case conversion into provider-specific files. Create API entry points pg_strlower(), etc., that work with any provider and give the caller control over the destination buffer. Then, move provider-specific logic into pg_locale_builtin.c, pg_locale_icu.c, and pg_locale_libc.c as appr

pgsql: doc: Mention BRIN indexes support parallel builds

2024-12-16 Thread Tomas Vondra
doc: Mention BRIN indexes support parallel builds Two places in the documentation suggest B-tree is the only index access method allowing parallel builds. Commit b4375717 added parallel builds for BRIN too, but failed to update the docs. So fix that, and backpatch to 17, where parallel BRIN builds

pgsql: doc: Mention BRIN indexes support parallel builds

2024-12-16 Thread Tomas Vondra
doc: Mention BRIN indexes support parallel builds Two places in the documentation suggest B-tree is the only index access method allowing parallel builds. Commit b4375717 added parallel builds for BRIN too, but failed to update the docs. So fix that, and backpatch to 17, where parallel BRIN builds

pgsql: Tweak some comments related to variable-numbered stats in pgstat

2024-12-16 Thread Michael Paquier
Tweak some comments related to variable-numbered stats in pgstat.c These comments referred to database objects, but depending on the stats kind dealt with this may not be true. Issues found while reviewing a different patch in this area. Discussion: https://postgr.es/m/ZtXR+CtkEVVE/l...@ip-10-9

pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup

2024-12-16 Thread Michael Paquier
pg_combinebackup: Fix PITR comparison test in 002_compare_backups The test was creating both the dumps to compare from the same database on the same node, so it would never detect any mismatches when comparing the logical dumps of the two servers. Fixing this issue has revealed that there is a di

pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup

2024-12-16 Thread Michael Paquier
pg_combinebackup: Fix PITR comparison test in 002_compare_backups The test was creating both the dumps to compare from the same database on the same node, so it would never detect any mismatches when comparing the logical dumps of the two servers. Fixing this issue has revealed that there is a di

pgsql: Print out error position for some more DDLs

2024-12-16 Thread Michael Paquier
Print out error position for some more DDLs The following commands gain some information about the error position in the query, should they fail when looking at the type used: - CREATE TYPE (LIKE) - CREATE TABLE OF Both are related to typenameType() where the type name lookup is done. These calls