Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Tom Lane
I wrote: > Furthermore, it can't be a coincidence that the four tables we are > seeing relallvisible diffs for are exactly the four tables in the > regression database that have hash indexes. Oh! If the source version is <= 9.6, old_9_6_invalidate_hash_indexes() generates a script "reindex_hash.s

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Andrew Dunstan
On 2025-02-22 Sa 1:34 PM, Tom Lane wrote: Andrew Dunstan writes: On 2025-02-21 Fr 10:11 PM, Tom Lane wrote: ... It seems there is something different between what TestUpgradeXversion.pm is doing and what 002_pg_upgrade.pl is doing. No clue what, although it does look like an additional roun

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Tom Lane
I wrote: > So there's our extra round of ANALYZE right there. I diked out the > vacuumdb call and things are working much better. It seems to pass > for branches back through 9.3, and upgrade from 9.2 has only some > diffs for relallvisible (see attached). I confess that when I wrote that, I had

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Jeff Davis
On Sat, 2025-02-22 at 20:15 -0500, Tom Lane wrote: > That's just crazy --- I would be > unsurprised if a range of back releases were misbehaving in the same > way, but not two isolated branches. > > Furthermore, it can't be a coincidence that the four tables we are > seeing relallvisible diffs for

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Tom Lane
Jeff Davis writes: > It's also strange that copperhead is consistently failing on 12 with: > pg_restore: while PROCESSING TOC: > pg_restore: from TOC entry 4163; 0 0 STATISTICS DATA "vcharidx" (no > owner) > pg_restore: error: could not execute query: ERROR: column "text" of > relation "vc

pgsql: Adjust EXPLAIN test case to filter out "Actual Rows" values.

2025-02-22 Thread Robert Haas
Adjust EXPLAIN test case to filter out "Actual Rows" values. Per the buildfarm, these tests appear to be unstable in the wake of commit ddb17e387aa28d61521227377b00f997756b8a27. I'm not sure that just hiding this output is the right way forward, because I think there may be other test cases that w

pgsql: Change \conninfo to use tabular format

2025-02-22 Thread Álvaro Herrera
Change \conninfo to use tabular format (Initially the proposal was to keep \conninfo alone and add this feature as \conninfo+, but we decided against keeping the original.) Also display more fields than before, though not as many as were suggested during the discussion. In particular, we don't s

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Tom Lane
Andrew Dunstan writes: > On 2025-02-21 Fr 10:11 PM, Tom Lane wrote: >> ... It seems there is >> something different between what TestUpgradeXversion.pm is doing >> and what 002_pg_upgrade.pl is doing. No clue what, although it >> does look like an additional round of analyze'ing has added more >>

Re: pgsql: Trial fix for old cross-version upgrades.

2025-02-22 Thread Andrew Dunstan
On 2025-02-21 Fr 10:11 PM, Tom Lane wrote: Jeff Davis writes: In 002_pg_upgrade.pl, I disabled autovacuum and restarted after the regression run. In other words, in the old cluster, autovacuum did have a chance to run, just not after the first dumpall. The hack I posted should prevent autova

pgsql: Documentation fixups for dumping statistics.

2025-02-22 Thread Jeff Davis
Documentation fixups for dumping statistics. Reported-by: Hayato Kuroda (Fujitsu) Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/oscpr01mb149665630030e7f54fda8b27bf5...@oscpr01mb14966.jpnprd01.prod.outlook.com Discussion: https://postgr.es/m/25d26774-25fa-46f2-9888-c6a707d1f...@du

pgsql: Allow EXPLAIN to indicate fractional rows.

2025-02-22 Thread Robert Haas
Allow EXPLAIN to indicate fractional rows. When nloops > 1, we now display two digits after the decimal point, rather than none. This is important because what we print is actually planstate->instrument->ntuples / nloops, and sometimes what you want to know is planstate->instrument->ntuples. You c

pgsql: Add more tests for utility commands in pipelines

2025-02-22 Thread Michael Paquier
Add more tests for utility commands in pipelines This commit checks interactions with pipelines and implicit transaction blocks for the following commands that have their own behaviors when used in pipelines depending on their order in a pipeline and sync requests: - SET LOCAL - REINDEX CONCURRENT

pgsql: jsonb internal API void * argument for binary data

2025-02-22 Thread Peter Eisentraut
jsonb internal API void * argument for binary data Change some internal jsonb API functions to take void * for binary data instead of char *. This removes the need for numerous casts. Reviewed-by: Dagfinn Ilmari Mannsåker Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc