pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: psql: Improve descriptions of \\flush[request] in --help

2025-04-19 Thread Michael Paquier
psql: Improve descriptions of \\flush[request] in --help Noah has reported that the current wording was confusing compared to the description of the underlying libpq routine. The new wording is from me. Reported-by: Noah Misch Discussion: https://postgr.es/m/20250415213450.1f.nmi...@google.com

pgsql: psql: Fix incorrect status code returned by \getresults

2025-04-19 Thread Michael Paquier
psql: Fix incorrect status code returned by \getresults When an invalid number of results is requested for \getresults, the status code returned by exec_command_getresults() was PSQL_CMD_SKIP_LINE and not PSQL_CMD_ERROR. This led to incorrect behaviors, with ON_ERROR_STOP for example. Reported-b

pgsql: psql: Split extended query protocol meta-commands in --help=comm

2025-04-19 Thread Michael Paquier
psql: Split extended query protocol meta-commands in --help=commands Compared to v17 with only \bind able to do extended query protocol work, v18 has now a total of 11 meta-commands related to the extended query protocol. These were all listed under the "General" section of the --help=commands ou

pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: Be more wary of corrupt data in pageinspect's heap_page_items().

2025-04-19 Thread Tom Lane
Be more wary of corrupt data in pageinspect's heap_page_items(). The original intent in heap_page_items() was to return nulls, not throw an error or crash, if an item was sufficiently corrupt that we couldn't safely extract data from it. However, commit d6061f83a utterly missed that memo, and not

pgsql: Fix typos and grammar in the code

2025-04-19 Thread Michael Paquier
Fix typos and grammar in the code The large majority of these have been introduced by recent commits done in the v18 development cycle. Author: Alexander Lakhin Discussion: https://postgr.es/m/9a7763ab-5252-429d-a943-b28941e0e...@gmail.com Branch -- master Details --- https://git.postg

pgsql: Rename injection points used in AIO tests

2025-04-19 Thread Michael Paquier
Rename injection points used in AIO tests The format of the injection point names used by the AIO code does not match the existing naming convention used everywhere else in the code, so let's be consistent. These points are used in test_aio. Reviewed-by: Hayato Kuroda Discussion: https://postgr