pgsql: amcheck: Remove unused IndexCheckableCallback typedef.

2025-07-04 Thread Fujii Masao
amcheck: Remove unused IndexCheckableCallback typedef. Commit d70b17636dd introduced the IndexCheckableCallback typedef for a callback function, but it was never used. This commit removes the unused typedef to clean up dead code. Author: Fujii Masao Reviewed-by: Andrey Borodin Discussion: http

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: pg_upgrade: check for inconsistencies in not-null constraints w/

2025-07-04 Thread Álvaro Herrera
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance With tables defined like this, CREATE TABLE ip (id int PRIMARY KEY); CREATE TABLE ic (id int) INHERITS (ip); ALTER TABLE ic ALTER id DROP NOT NULL; pg_upgrade fails during the schema restore phase due to this error:

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_18_STABLE

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_16_STABLE

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- master Detai

pgsql: pg_upgrade: Add missing newline in error message

2025-07-04 Thread Álvaro Herrera
pg_upgrade: Add missing newline in error message Minor oversight in 347758b12063 Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5aba3e637d3d874f7bf00318c828249a964c4c3c Modified Files -- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insert

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_14_STABLE

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_13_STABLE

pgsql: pg_upgrade: Add missing newline in error message

2025-07-04 Thread Álvaro Herrera
pg_upgrade: Add missing newline in error message Minor oversight in 347758b12063 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/90a85fce5e9b9ea63ec7e1b3001e0f39d4c8b7d4 Modified Files -- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+),

pgsql: pg_upgrade: Add missing newline in error message

2025-07-04 Thread Álvaro Herrera
pg_upgrade: Add missing newline in error message Minor oversight in 347758b12063 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0807a4656edcfdc2f900bc070a4a8592a0a7f880 Modified Files -- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insert

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_15_STABLE

pgsql: Fix new pg_upgrade query not to rely on regnamespace

2025-07-04 Thread Álvaro Herrera
Fix new pg_upgrade query not to rely on regnamespace That was invented in 9.5, and pg_upgrade claims to support back to 9.0. But we don't need that with a simple query change, tested by Tom Lane. Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql Branch -- REL_17_STABLE