pgsql: Add static assertion that RELSEG_SIZE fits in an int.

2025-10-19 Thread Tom Lane
Add static assertion that RELSEG_SIZE fits in an int. Our configure script intended to ensure this, but it supposed that expr(1) would report an error for integer overflow. Maybe that was true when the code was written (commit 3c6248a82 of 2008-05-02), but all the modern expr's I tried will deliv

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: Don't rely on zlib's gzgetc() macro.

2025-10-19 Thread Tom Lane
Don't rely on zlib's gzgetc() macro. It emerges that zlib's configuration logic is not robust enough to guarantee that the macro will have the same ideas about struct field layout as the library itself does, leading to corruption of zlib's state struct followed by unintelligible failure messages.

pgsql: pg_checksums: Use new routine to retrieve data of PG_VERSION

2025-10-19 Thread Michael Paquier
pg_checksums: Use new routine to retrieve data of PG_VERSION Previously, attempting to use pg_checksums on a cluster with a control file whose version does not match with what thetool is able to support would lead to the following error: pg_checksums: error: pg_control CRC value is incorrect This

pgsql: pg_dump: Remove unnecessary code for security labels on extensio

2025-10-19 Thread Fujii Masao
pg_dump: Remove unnecessary code for security labels on extensions. Commit d9572c4e3b4 added extension support and made pg_dump attempt to dump security labels on extensions. However, security labels on extensions are not actually supported, so this code was unnecessary. This commit removes it.