Re: pgsql: Allow on-line enabling and disabling of data checksums

On Fri, Apr 6, 2018 at 5:35 AM, Magnus Hagander wrote: > Allow on-line enabling and disabling of data checksums > > This makes it possible to turn checksums on in a live cluster, without > the previous need for dump/reload or logical replication (and to turn it > off). > > Enabling checkusm starts

pgsql: Attempt to fix win32 build of pg_verify_checksums

Attempt to fix win32 build of pg_verify_checksums S_ISLNK doesn't exist on Win32, instead we should use pgwin32_is_junction(). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3b0b4f31f73a5f45f8e122d826211c13cd2412f7 Modified Files -- src/bin/pg_verify_c

pgsql: Allow on-line enabling and disabling of data checksums

Allow on-line enabling and disabling of data checksums This makes it possible to turn checksums on in a live cluster, without the previous need for dump/reload or logical replication (and to turn it off). Enabling checkusm starts a background process in the form of a launcher/worker combination t

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c00c4c57b

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d2c9737bc

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ec45e6036

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e17745070

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ec349b112

pgsql: doc: remove mention of the DMOZ catalog in ltree docs

doc: remove mention of the DMOZ catalog in ltree docs Discussion: https://postgr.es/m/CAF4Au4xYem_W3KOuxcKct7=g4j8z3uo9j3duktfjqusfp_9...@mail.gmail.com Author: Oleg Bartunov Backpatch-through: 9.3 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c39e903d510064e4

Re: pgsql: MERGE INSERT allows only one VALUES clause

On 5 April 2018 at 17:15, Andrew Gierth wrote: >> "Simon" == Simon Riggs writes: > > Simon> MERGE INSERT allows only one VALUES clause > > That can't possibly be right; you've changed it to say that only one > _expression_ (i.e. column) is allowed in the VALUES () list, not that > only one _

pgsql: MERGE syntax diagram correction

MERGE syntax diagram correction Reported-by: Andrew Gierth Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ddb4158579e052ee35313c333256cb1f16ee65fa Modified Files -- doc/src/sgml/ref/merge.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: PL/pgSQL: Add support for SET TRANSACTION

PL/pgSQL: Add support for SET TRANSACTION A normal SQL command run inside PL/pgSQL acquires a snapshot, but SET TRANSACTION does not work anymore if a snapshot is set. So we have to handle this separately. Reviewed-by: Alexander Korotkov Reviewed-by: Tomas Vondra Branch -- master Details

pgsql: Allow cpluspluscheck to pass by renaming variable

Allow cpluspluscheck to pass by renaming variable Use of a C++ keyword as a function name caused problems Reported-by: Álvaro Herrera Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/530e69e59b07cf94a65cfde7dd1a8b1c62b44228 Modified Files -- src/backend

pgsql: Fix plan cache issue in PL/pgSQL CALL

Fix plan cache issue in PL/pgSQL CALL If we are not going to save the plan, then we need to unset expr->plan after we are done, also in error cases. Otherwise, we get a dangling pointer next time around. This is not the ideal solution. It would be better if we could convince SPI not to associat

Re: pgsql: Optimize btree insertions for common case of increasing values

On Thu, Apr 5, 2018 at 6:27 AM, Pavan Deolasee wrote: > I came up with something like this: > > + /* > +* If we're here then a pagesplit is needed. We should never > reach here > +* if we're using the fastpath since we should have checked > for all the

pgsql: Fix worker_spi for new parameter to initialize connection

Fix worker_spi for new parameter to initialize connection Missed in previous commit. Spotted by Teodor and the buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6a5f796b48b0e9808fef9731da8aea17f56de999 Modified Files -- src/test/modules/worker_

Re: pgsql: Allow background workers to bypass datallowconn

On Thu, Apr 5, 2018 at 7:11 PM, Teodor Sigaev wrote: > Something goes wrong > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crak > e&dt=2018-04-05 17%3A07%3A19 > > Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.b > uild/../pgsql/src/test/modules/worker_spi/worker_spi.c: In function > ‘w

Re: pgsql: Allow background workers to bypass datallowconn

Something goes wrong https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2018-04-05 17%3A07%3A19 Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/test/modules/worker_spi/worker_spi.c: In function ‘worker_spi_main’: Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.bui

pgsql: Remove tsearch test contained russian characters, missed in

Remove tsearch test contained russian characters, missed in 1664ae1978bf0f5ee940dc2fc8313e6400a7e7da Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1a8c95365e01c37ff5f51eb803e8ce926fbb0238 Modified Files -- src/test/regress/expected/tsearch.out | 6

pgsql: Allow background workers to bypass datallowconn

Allow background workers to bypass datallowconn THis adds a "flags" field to the BackgroundWorkerInitializeConnection() and BackgroundWorkerInitializeConnectionByOid(). For now only one flag, BGWORKER_BYPASS_ALLOWCONN, is defined, which allows the worker to ignore datallowconn. Branch -- mast

Re: pgsql: Add websearch_to_tsquery

Miss russion characters in tests, removing Teodor Sigaev wrote: Add websearch_to_tsquery Error-tolerant conversion function with web-like syntax for search query, it simplifies constraining search engine with close to habitual interface for users. Bump catalog version Authors: Victor Drobny

pgsql: Add websearch_to_tsquery

Add websearch_to_tsquery Error-tolerant conversion function with web-like syntax for search query, it simplifies constraining search engine with close to habitual interface for users. Bump catalog version Authors: Victor Drobny, Dmitry Ivanov with editorization by me Reviewed by: Aleksander Ale

Re: pgsql: MERGE INSERT allows only one VALUES clause

> "Simon" == Simon Riggs writes: Simon> MERGE INSERT allows only one VALUES clause That can't possibly be right; you've changed it to say that only one _expression_ (i.e. column) is allowed in the VALUES () list, not that only one _row_ is allowed. I think it was correct before. -- Andrew

pgsql: Add missing include

Add missing include Newly added prototype broke cpluspluscheck. Minor buglet in commit 8694cc96b52a. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fbc27330b8f8693d8fa9b1f8cb450567c3d81640 Modified Files -- src/include/storage/reinit.h | 3 +++ 1 file

pgsql: Add support of bool, bpchar, name and uuid to btree_gin

Add support of bool, bpchar, name and uuid to btree_gin Mostly for completeness, but I believe there are cases to use that in multicolumn GIN indexes. Bump btree_gin module version Author: Matheus Oliveira Reviewed by: Tomas Vondra Discussion: https://www.postgresql.org/message-id/flat/CAJghg4L

pgsql: Fix handling of non-upgraded B-tree metapages

Fix handling of non-upgraded B-tree metapages 857f9c36 bumps B-tree metapage version while upgrade is performed "on the fly" when needed. However, some asserts fired when old version metapage was cached to rel->rd_amcache. Despite new metadata fields are never used from rel->rd_amcache, that needs

Re: pgsql: Optimize btree insertions for common case of increasing values

On Wed, Apr 4, 2018 at 10:46 PM, Peter Geoghegan wrote: > > > > You mean passing "fastpath" to _bt_insertonpg and then checking it's > false > > if page split is needed? But isn't page split is only needed if the page > > doesn't have enough free space? If so, we have checked for that before > >

Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Thu, Apr 5, 2018 at 3:24 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Apr 5, 2018 at 2:26 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote: >> >>> Peter Geoghegan writes: >>> >>> TRAP: FailedAssertion("!(m

Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Thu, Apr 5, 2018 at 2:26 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote: > >> Peter Geoghegan writes: >> >>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File: >> >>> "/home/pg/postgresql/root/build/../source/src/backend/acce

pgsql: MERGE minor errata

MERGE minor errata Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/01b88b4df5e2df0365cceaf79a039214d9f05273 Modified Files -- src/backend/executor/README | 4 ++-- src/backend/executor/execMerge.c | 2 +- src/backend/executor/execPartition.c |

pgsql: MERGE fix variable warning in non-assert builds

MERGE fix variable warning in non-assert builds Author: Jesper Pedersen Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3af7b2b0d497cfc240ffc8098ef068adb30048a2 Modified Files -- src/backend/executor/execMerge.c | 6 ++ 1 file changed, 2 insertions(+

Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Thu, Apr 5, 2018 at 6:28 AM, Tom Lane wrote: > Peter Geoghegan writes: > >>> TRAP: FailedAssertion("!(metad->btm_version == 3)", File: > >>> "/home/pg/postgresql/root/build/../source/src/backend/ > access/nbtree/nbtpage.c", > >>> Line: 619) > > >> Hm, buildfarm's not complaining --- what's th

Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Thu, Apr 5, 2018 at 1:32 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev wrote: > >> Skip full index scan during cleanup of B-tree indexes when possible >> > > Thank you for committing this. > > It appears that patch contains some redu

pgsql: MERGE INSERT allows only one VALUES clause

MERGE INSERT allows only one VALUES clause Doc syntax and brief mention of restriction Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a5d86181ecc9c441d4c327771c43134de59549cd Modified Files -- doc/src/sgml/ref/merge.sgml | 3 ++- 1 file changed, 2 inser

pgsql: Remove unused vars and mark assert-only vars

Remove unused vars and mark assert-only vars Kyotaro HORIGUCHI Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/17d8beb4f52599805283b1f2f49e02491656f7e1 Modified Files -- src/backend/access/nbtree/nbtpage.c | 4 +--- src/backend/access/nbtree/nbtree.c |

pgsql: Fix misprint in documentation

Fix misprint in documentation Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a02d51c0d3c0c25d99d2a1cd84f3321640294fa9 Modified Files -- doc/src/sgml/ref/create_index.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

Fix typo Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51e6562324f8f03909f1ad1754720e95ae238fad Modified Files -- src/backend/access/nbtree/nbtpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: MERGE post-commit review

MERGE post-commit review Review comments from Andres Freund * Consolidate code into AfterTriggerGetTransitionTable() * Rename nodeMerge.c to execMerge.c * Rename nodeMerge.h to execMerge.h * Move MERGE handling in ExecInitModifyTable() into a execMerge.c ExecInitMerge() * Move mt_merge_subcomma