pgsql: Fix invalid value of synchronous_commit in description of flush_

2018-12-04 Thread Michael Paquier
Fix invalid value of synchronous_commit in description of flush_lag

"remote_flush" has never been a valid user-facing value, but "on" is.

Author: Maksim Milyutin
Discussion: https://postgr.es/m/27b3b80c-3615-2d76-02c5-44566b531...@gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/db35e959bbbddaf01c9aa1060ef60b34520e021d

Modified Files
--
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix invalid value of synchronous_commit in description of flush_

2018-12-04 Thread Michael Paquier
Fix invalid value of synchronous_commit in description of flush_lag

"remote_flush" has never been a valid user-facing value, but "on" is.

Author: Maksim Milyutin
Discussion: https://postgr.es/m/27b3b80c-3615-2d76-02c5-44566b531...@gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/99f9ccee510366a560df88088835e7e8d5066118

Modified Files
--
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix invalid value of synchronous_commit in description of flush_

2018-12-04 Thread Michael Paquier
Fix invalid value of synchronous_commit in description of flush_lag

"remote_flush" has never been a valid user-facing value, but "on" is.

Author: Maksim Milyutin
Discussion: https://postgr.es/m/27b3b80c-3615-2d76-02c5-44566b531...@gmail.com

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/367f362b2d902de1c8f265639980ae001a4307e8

Modified Files
--
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix typo

2018-12-04 Thread Stephen Frost
Fix typo

Backends don't typically exist uncleanly, but they can certainly exit
uncleanly, and it's exiting uncleanly that's being discussed here.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f502fc88b3c8b4c619a4bcbb86c3225a699c1d45

Modified Files
--
src/backend/libpq/be-secure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: postgres_fdw: Improve cost and size estimation for aggregate pus

2018-12-04 Thread Etsuro Fujita
postgres_fdw: Improve cost and size estimation for aggregate pushdown.

In commit 7012b132d07c2b4ea15b0b3cb1ea9f3278801d98, which added aggregate
pushdown to postgres_fdw, we didn't account for the evaluation cost and the
selectivity of HAVING quals attached to ForeignPaths performing aggregate
pushdown, as core had never accounted for that for AggPaths and GroupPaths.
And we didn't set these values of the locally-checked quals (ie, fpinfo's
local_conds_cost and local_conds_sel), which were initialized to zeros, but
since estimate_path_cost_size factors in these to estimate the result size
and the evaluation cost of such a ForeignPath when the use_remote_estimate
option is enabled, this caused it to produce underestimated results in that
case.

By commit 7b6c07547190f056b0464098bb5a2247129d7aa2 core was changed so that
it accounts for the evaluation cost and the selectivity of HAVING quals in
aggregation paths, so change the postgres_fdw's aggregate pushdown code as
well as such.  This not only fixes the underestimation issue mentioned
above, but improves the estimation using local statistics in that function
when that option is disabled.

This would be a bug fix rather than an improvement, but apply it to HEAD
only to avoid destabilizing existing plan choices.

Author: Etsuro Fujita
Discussion: https://postgr.es/m/5BFD3EAD.2060301%40lab.ntt.co.jp

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f8f6e44676ef38fee7a5bbe4f256a34ea7799ac1

Modified Files
--
contrib/postgres_fdw/expected/postgres_fdw.out |  2 +
contrib/postgres_fdw/postgres_fdw.c| 56 ++
contrib/postgres_fdw/sql/postgres_fdw.sql  |  3 ++
3 files changed, 54 insertions(+), 7 deletions(-)