pgsql: Remove spurious return.

2019-03-23 Thread Andres Freund
Remove spurious return. Per buildfarm member anole. Author: Andres Freund Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2db277057a375ccbcc98cc3bbce8ce5b4d788ea Modified Files -- src/include/access/tableam.h | 4 ++-- 1 file changed, 2 insertions(+),

pgsql: tableam: Add tuple_{insert, delete, update, lock} and use.

2019-03-23 Thread Andres Freund
tableam: Add tuple_{insert, delete, update, lock} and use. This adds new, required, table AM callbacks for insert/delete/update and lock_tuple. To be able to reasonably use those, the EvalPlanQual mechanism had to be adapted, moving more logic into the AM. Previously both delete/update/lock

pgsql: Revert strlen -> strnlen optimization pre-v11.

2019-03-23 Thread Tom Lane
Revert strlen -> strnlen optimization pre-v11. We don't have a src/port substitute for that function in older branches, so it fails on platforms lacking the function natively. Per buildfarm. Branch -- REL_10_STABLE Details ---

pgsql: Revert strlen -> strnlen optimization pre-v11.

2019-03-23 Thread Tom Lane
Revert strlen -> strnlen optimization pre-v11. We don't have a src/port substitute for that function in older branches, so it fails on platforms lacking the function natively. Per buildfarm. Branch -- REL9_4_STABLE Details ---

pgsql: Revert strlen -> strnlen optimization pre-v11.

2019-03-23 Thread Tom Lane
Revert strlen -> strnlen optimization pre-v11. We don't have a src/port substitute for that function in older branches, so it fails on platforms lacking the function natively. Per buildfarm. Branch -- REL9_5_STABLE Details ---

pgsql: Revert strlen -> strnlen optimization pre-v11.

2019-03-23 Thread Tom Lane
Revert strlen -> strnlen optimization pre-v11. We don't have a src/port substitute for that function in older branches, so it fails on platforms lacking the function natively. Per buildfarm. Branch -- REL9_6_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- REL9_6_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- REL9_5_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- REL9_4_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- REL_11_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- REL_10_STABLE Details ---

pgsql: Remove inadequate check for duplicate "xml" PI.

2019-03-23 Thread Tom Lane
Remove inadequate check for duplicate "xml" PI. I failed to think about PIs starting with "xml". We don't really need this check at all, so just take it out. Oversight in commit 8d1dadb25 et al. Branch -- master Details ---

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Suppress DETAIL output from an event_trigger test.

2019-03-23 Thread Peter Geoghegan
Suppress DETAIL output from an event_trigger test. Suppress 3 lines of unstable DETAIL output from a DROP ROLE statement in event_trigger.sql. This is further cleanup for commit dd299df8. Note that the event_trigger test instability issue is very similar to the recently suppressed foreign_data

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Accept XML documents when xmloption = content, as required by SQ

2019-03-23 Thread Tom Lane
Accept XML documents when xmloption = content, as required by SQL:2006+. Previously we were using the SQL:2003 definition, which doesn't allow this, but that creates a serious dump/restore gotcha: there is no setting of xmloption that will allow all valid XML data. Hence, switch to the 2006

pgsql: Ensure xmloption = content while restoring pg_dump output.

2019-03-23 Thread Tom Lane
Ensure xmloption = content while restoring pg_dump output. In combination with the previous commit, this ensures that valid XML data can always be dumped and reloaded, whether it is "document" or "content". Discussion:

pgsql: Add nbtree high key "continuescan" optimization.

2019-03-23 Thread Peter Geoghegan
Add nbtree high key "continuescan" optimization. Teach nbtree forward index scans to check the high key before moving to the right sibling page in the hope of finding that it isn't actually necessary to do so. The new check may indicate that the scan definitely cannot find matching tuples to the

pgsql: Improve format of code and some error messages in pg_checksums

2019-03-23 Thread Michael Paquier
Improve format of code and some error messages in pg_checksums This makes the code more consistent with the surroundings. Author: Fabrízio de Royes Mello Discussion: https://postgr.es/m/CAFcNs+pXb_35r5feMU3-dWsWxXU=yjq+spusthfygfbt0qc...@mail.gmail.com Branch -- master Details ---