Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().
On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut wrote: > On 22.02.21 12:28, Thomas Munro wrote: > > pg_collation_actual_version() -> pg_collation_current_version(). > > > > The new name seems a bit more natural. > > > > Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com > > I don't find where this change was discussed in that thread. I > specifically chose that name to indicate, "not the current version in > the database, but the version the OS thinks it should be". I think the > rename loses that distinction. I understood "actual" to be a way of contrasting with pg_collation.collversion, which we dropped. Without that, the meaning of a more typical function name with "current" seemed clearer to me, and "actual" seemed excessively emphatic. There isn't a concept of a single "current version in the database" anymore, there's just the set of relevant versions that were current when each index was built. Happy to revert the name change if you hate it though, and sorry I didn't CC you on the thread.
Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().
On 22.02.21 12:28, Thomas Munro wrote: pg_collation_actual_version() -> pg_collation_current_version(). The new name seems a bit more natural. Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com I don't find where this change was discussed in that thread. I specifically chose that name to indicate, "not the current version in the database, but the version the OS thinks it should be". I think the rename loses that distinction.
pgsql: Fix an oversight in ReorderBufferFinishPrepared.
Fix an oversight in ReorderBufferFinishPrepared. We don't have anything to decode in a transaction if ReorderBufferTXN doesn't exist by the time we decode the commit prepared. So don't create a new ReorderBufferTXN here. This is an oversight in commit a271a1b5. Reported-by: Markus Wanner Discussion: https://postgr.es/m/dbec82e2-dbd7-95a2-c6b6-e488cbbdf...@bluegap.ch Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ade89ba5f408e6034db7cc8a2c9b7858f5a214c4 Modified Files -- src/backend/replication/logical/reorderbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Change the error message for logical replication authentication
Change the error message for logical replication authentication failure. The authentication failure error message wasn't distinguishing whether it is a physical replication or logical replication connection failure and was giving incomplete information on what led to failure in case of logical replication connection. Author: Paul Martinez and Amit Kapila Reviewed-by: Euler Taveira and Amit Kapila Discussion: https://postgr.es/m/cacqfvbyahrai2opdjfua3ycvn3qmzzxzdw0ibsj8wouwedt...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc617a7b1cada2ec5f8b9d45a4312e49fc1766ad Modified Files -- doc/src/sgml/client-auth.sgml | 6 -- src/backend/libpq/auth.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-)
pgsql: Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls
Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls Pavan Deolasee recently noted that a few of the HeapTupleHeaderIndicatesMovedPartitions calls added by commit 5db6df0c0117 are useless, since they are done after comparing t_self with t_ctid. But because t_self can never be set to the magical values that indicate that the tuple moved partition, this can never succeed: if the first test fails (so we know t_self equals t_ctid), necessarily the second test will also fail. So these checks can be removed and no harm is done. There's no bug here, just a code legibility issue. Reported-by: Pavan Deolasee Discussion: https://postgr.es/m/20200929164411.GA15497@alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0f5505a8815aa4eb03ca61245a5a51ff9adda2f4 Modified Files -- src/backend/access/heap/heapam.c| 12 src/backend/access/heap/heapam_visibility.c | 9 +++-- 2 files changed, 7 insertions(+), 14 deletions(-)
pgsql: Fix typo
Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6a03369a71d4a7dc5b8d928aab775ddd28b72494 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix docs build for website styles
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn import the required one. That puts the process entirely within the scope of the website repository, so next time a version is switched that's the only place changes have to be made, making them less likely to be missed. Per (off-list) discussion with Peter Geoghegan and Jonathan Katz. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d22d0fa937616a3112f69ebd6a6ed4f039162441 Modified Files -- doc/src/sgml/stylesheet.xsl | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
pgsql: Fix docs build for website styles
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn import the required one. That puts the process entirely within the scope of the website repository, so next time a version is switched that's the only place changes have to be made, making them less likely to be missed. Per (off-list) discussion with Peter Geoghegan and Jonathan Katz. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/186f6168b73de6472e8aeb6e96b2ec6c73fd7b89 Modified Files -- doc/src/sgml/stylesheet.xsl | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
pgsql: Hide internal error for pg_collation_actual_version().
Hide internal error for pg_collation_actual_version(). Instead of an unsightly internal "cache lookup failed" message, just return NULL for bad OIDs, as is the convention for other similar things. Reported-by: Justin Pryzby Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0fb0a0503bfc125764c8dba4f515058145dc7f8b Modified Files -- src/backend/catalog/index.c| 5 +++-- src/backend/catalog/pg_depend.c| 3 ++- src/backend/commands/collationcmds.c | 2 +- src/backend/utils/adt/pg_locale.c | 9 +++-- src/include/utils/pg_locale.h | 2 +- src/test/regress/expected/collate.icu.utf8.out | 14 ++ src/test/regress/sql/collate.icu.utf8.sql | 5 + 7 files changed, 33 insertions(+), 7 deletions(-)
pgsql: Refactor get_collation_current_version().
Refactor get_collation_current_version(). The code paths for three different OSes finished up with three different ways of excluding C[.xxx] and POSIX from consideration. Merge them. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/beb4480c853a60ec43bd3f1a71252890dd234f10 Modified Files -- src/backend/utils/adt/pg_locale.c | 34 -- 1 file changed, 4 insertions(+), 30 deletions(-)
pgsql: Tab-complete CREATE COLLATION.
Tab-complete CREATE COLLATION. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5bc09a74719dfeb6c4cebb311b81385c508459a8 Modified Files -- src/bin/psql/tab-complete.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-)
pgsql: pg_collation_actual_version() -> pg_collation_current_version().
pg_collation_actual_version() -> pg_collation_current_version(). The new name seems a bit more natural. Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9cf184cc0599b6e65e7e5ecd9d91cd42e278bcd8 Modified Files -- doc/src/sgml/func.sgml | 8 src/backend/commands/collationcmds.c | 2 +- src/backend/utils/adt/pg_locale.c | 14 +++--- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.dat| 4 ++-- src/test/regress/expected/collate.icu.utf8.out | 6 +++--- src/test/regress/sql/collate.icu.utf8.sql | 6 +++--- 7 files changed, 21 insertions(+), 21 deletions(-)
pgsql: Initialize atomic variable waitStart in PGPROC, at postmaster st
Initialize atomic variable waitStart in PGPROC, at postmaster startup. Commit 46d6e5f567 added the atomic variable "waitStart" into PGPROC struct, to store the time at which wait for lock acquisition started. Previously this variable was initialized every time each backend started. Instead, this commit makes postmaster initialize it at the startup, to ensure that the variable should be initialized before any use of it. This commit also moves the code to initialize "waitStart" variable for prepare transaction, from TwoPhaseGetDummyProc() to MarkAsPreparingGuts(). Because MarkAsPreparingGuts() is more proper place to do that since it initializes other PGPROC variables. Author: Fujii Masao Reviewed-by: Atsushi Torikoshi Discussion: https://postgr.es/m/1df88660-6f08-cc6e-b7e2-f85296a2b...@oss.nttdata.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f05ed5a5cfa55878baa77a1e39d68cb09793b477 Modified Files -- src/backend/access/transam/twophase.c | 10 ++ src/backend/storage/lmgr/proc.c | 5 +++-- 2 files changed, 5 insertions(+), 10 deletions(-)
