pgsql: Doc: Remove extraneous whitespaces with some tags
Doc: Remove extraneous whitespaces with some tags Author: Justin Pryzby Discussion: https://postgr.es/m/20210423184338.gl7...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d0049c58b4970183a102fc1f7dc1e9bef2a7149 Modified Files -- doc/src/sgml/maintenance.sgml | 2 +- doc/src/sgml/mvcc.sgml | 2 +- doc/src/sgml/pgcrypto.sgml | 2 +- doc/src/sgml/ref/pg_rewind.sgml | 2 +- doc/src/sgml/runtime.sgml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
pgsql: Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c
Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c 6f6f284 has introduced a specific macro to make printf()-ing of LSNs easier. This takes care of what looks like the remaining code paths that did not get the call. Author: Michael Paquier Reviewed-by: Kyotaro Horiguchi, Tom Lane Discussion: https://postgr.es/m/yijs9x6k8ruiz...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4aba61b87026b43fb37fc8e9ec5d9ae208e07b6b Modified Files -- src/backend/access/transam/xlogreader.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-)
pgsql: amcheck: MAXALIGN() nbtree special area offset.
amcheck: MAXALIGN() nbtree special area offset. This isn't strictly necessary, but in theory it might matter if in the future the width of the nbtree special area changes -- its total size might not be an even number of MAXALIGN() quantums, even with padding. PageInit() MAXALIGN()s all special area offsets, but amcheck uses the offset to perform initial basic validation of line pointers, so we don't rely on the offset from the page header. The real reason to do this is to set a good example for new code that adds amcheck coverage for other index AMs. Reported-By: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACUMqTR9nErh99FbOBmzCXE9=gxnqhbiwyohejjjs1l...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bb3ecc8c961896ecb2ad3d5ba705c2877b933945 Modified Files -- contrib/amcheck/verify_nbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Factor out system call names from error messages
Factor out system call names from error messages Instead, put them in via a format placeholder. This reduces the number of distinct translatable messages and also reduces the chances of typos during translation. We already did this for the system call arguments in a number of cases, so this is just the same thing taken a bit further. Discussion: https://www.postgresql.org/message-id/flat/92d6f545-5102-65d8-3c87-489f71ea0a37%40enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/82c3cd974131d7fa1cfcd07cebfb04fffe26ee35 Modified Files -- src/backend/libpq/pqcomm.c | 46 ++ src/backend/postmaster/pgstat.c| 4 +-- src/backend/storage/ipc/latch.c| 25 -- src/bin/pg_basebackup/pg_recvlogical.c | 2 +- src/bin/pg_basebackup/receivelog.c | 2 +- src/bin/pg_dump/parallel.c | 6 ++--- src/bin/pg_upgrade/parallel.c | 2 +- src/common/exec.c | 2 +- src/interfaces/libpq/fe-connect.c | 15 +++ src/interfaces/libpq/fe-misc.c | 3 ++- 10 files changed, 55 insertions(+), 52 deletions(-)
pgsql: Use correct format placeholder for WSAGetLastError()
Use correct format placeholder for WSAGetLastError() Some code thought this was unsigned, but it's signed int. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9486844f301e265a3ad11b612decaba2462c3c15 Modified Files -- src/backend/libpq/pqcomm.c| 2 +- src/backend/port/win32/socket.c | 2 +- src/backend/storage/ipc/latch.c | 6 +++--- src/interfaces/libpq/fe-connect.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-)
pgsql: Mark multirange_constructor0() and multirange_constructor2() str
Mark multirange_constructor0() and multirange_constructor2() strict These functions shouldn't receive null arguments: multirange_constructor0() doesn't have any arguments while multirange_constructor2() has a single array argument, which is never null. But mark them strict anyway for the sake of uniformity. Also, make checks for null arguments use elog() instead of ereport() as these errors should normally be never thrown. And adjust corresponding comments. Catversion is bumped. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/0f783a96-8d67-9e71-996b-f34a7352eeef%40enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6bbcff096f932a1fe43ac3208c5c8b0acac29cda Modified Files -- src/backend/commands/typecmds.c | 4 ++-- src/backend/utils/adt/multirangetypes.c | 25 + src/include/catalog/catversion.h| 2 +- src/include/catalog/pg_proc.dat | 24 4 files changed, 28 insertions(+), 27 deletions(-)
pgsql: Reorder COMPRESSION option in gram.y and parsenodes.h into alpha
Reorder COMPRESSION option in gram.y and parsenodes.h into alphabetical order. Commit bbe0a81db6 introduced "INCLUDING COMPRESSION" option in CREATE TABLE command, but previously TableLikeOption in gram.y and parsenodes.h didn't classify this new option in alphabetical order with the rest. Author: Fujii Masao Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/yheraixohfr1r...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3f20d5f37086e548c32ddb9d6ae09c2e1ce300ce Modified Files -- src/backend/parser/gram.y | 2 +- src/include/nodes/parsenodes.h | 16 2 files changed, 9 insertions(+), 9 deletions(-)
pgsql: Mention that toplevel is part of pg_stat_statements key.
Mention that toplevel is part of pg_stat_statements key. While at it, also document that toplevel is always true if pg_stat_statements.track is set to top. Author: Julien Rouhaud Reported-By: Fujii Masao Discussion: https://postgr.es/m/a878d5ea-64a7-485e-5d2f-177618ebc...@oss.nttdata.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7531fcb1fcf5b3ea2f49959a3f095c083e3fc4c4 Modified Files -- doc/src/sgml/pgstatstatements.sgml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)
pgsql: pg_amcheck: Use logging functions
pg_amcheck: Use logging functions This was already mostly done, but some error messages were printed the long way. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/add5fad78aac8da96aeeb730155d35b16ff9b55a Modified Files -- src/bin/pg_amcheck/pg_amcheck.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-)
pgsql: doc: Fix typos
doc: Fix typos Author: Justin Pryzby Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9bd563aa9f0694994a6640946a7ee3dc0431d507 Modified Files -- doc/src/sgml/func.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: doc: Fix obsolete description about pg_basebackup.
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. Now, even when taking a backup from the standby, pg_basebackup can wait for all required WAL files to be archived. Therefore this commit removes such obsolete description from the docs. Also this commit adds new description about the limitation when taking a backup from the standby, into the docs. The limitation is that pg_basebackup cannot force the standbfy to switch to a new WAL file at the end of backup, which may cause pg_basebackup to wait a long time for the last required WAL file to be switched and archived, especially when write activity on the primary is low. Back-patch to v10 where the issue was introduced. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi, Fujii Masao Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210420.133235.1342729068750553399.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eaec48b3c54eec222d64468b57af80ee4ddf76a9 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
pgsql: doc: Fix obsolete description about pg_basebackup.
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. Now, even when taking a backup from the standby, pg_basebackup can wait for all required WAL files to be archived. Therefore this commit removes such obsolete description from the docs. Also this commit adds new description about the limitation when taking a backup from the standby, into the docs. The limitation is that pg_basebackup cannot force the standbfy to switch to a new WAL file at the end of backup, which may cause pg_basebackup to wait a long time for the last required WAL file to be switched and archived, especially when write activity on the primary is low. Back-patch to v10 where the issue was introduced. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi, Fujii Masao Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210420.133235.1342729068750553399.horikyota@gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8019fcb00f8832e3b0d787e078f28dbb853f3151 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
pgsql: doc: Fix obsolete description about pg_basebackup.
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. Now, even when taking a backup from the standby, pg_basebackup can wait for all required WAL files to be archived. Therefore this commit removes such obsolete description from the docs. Also this commit adds new description about the limitation when taking a backup from the standby, into the docs. The limitation is that pg_basebackup cannot force the standbfy to switch to a new WAL file at the end of backup, which may cause pg_basebackup to wait a long time for the last required WAL file to be switched and archived, especially when write activity on the primary is low. Back-patch to v10 where the issue was introduced. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi, Fujii Masao Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210420.133235.1342729068750553399.horikyota@gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ecc88076ed2eb52b36261ee82c5c5fc93c10b6c Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
pgsql: doc: Fix obsolete description about pg_basebackup.
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. Now, even when taking a backup from the standby, pg_basebackup can wait for all required WAL files to be archived. Therefore this commit removes such obsolete description from the docs. Also this commit adds new description about the limitation when taking a backup from the standby, into the docs. The limitation is that pg_basebackup cannot force the standbfy to switch to a new WAL file at the end of backup, which may cause pg_basebackup to wait a long time for the last required WAL file to be switched and archived, especially when write activity on the primary is low. Back-patch to v10 where the issue was introduced. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi, Fujii Masao Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210420.133235.1342729068750553399.horikyota@gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/50b84aa26239986bbcdcad58de7c9ee01ed376c1 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
pgsql: doc: Fix obsolete description about pg_basebackup.
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. Now, even when taking a backup from the standby, pg_basebackup can wait for all required WAL files to be archived. Therefore this commit removes such obsolete description from the docs. Also this commit adds new description about the limitation when taking a backup from the standby, into the docs. The limitation is that pg_basebackup cannot force the standbfy to switch to a new WAL file at the end of backup, which may cause pg_basebackup to wait a long time for the last required WAL file to be switched and archived, especially when write activity on the primary is low. Back-patch to v10 where the issue was introduced. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi, Fujii Masao Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/20210420.133235.1342729068750553399.horikyota@gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d59964999d15be29fcd97544e66780fc5c9f17a9 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
