pgsql: Display 'password_required' option for \dRs+ command.

2023-04-23 Thread Amit Kapila
Display 'password_required' option for \dRs+ command.

The commit c3afe8cf5a added a new subscription option 'password_required'
which should be shown with \dRs+ command.

Author: Vignesh C
Reviewed-by: Amit Kapila, Robert Haas
Discussion: 
https://postgr.es/m/caa4ek1lrz5sczxwcw6otpjltwpvrwbihqom4jzqm6ppfpex...@mail.gmail.com
Discussion: 
https://postgr.es/m/9dfc88d3-1300-4de8-acbc-4cef84399...@enterprisedb.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/19e65dff38bdccdf2cac7f2083342101df6bea57

Modified Files
--
src/bin/psql/describe.c|   4 +-
src/test/regress/expected/subscription.out | 151 +++--
src/test/regress/sql/subscription.sql  |   2 +
3 files changed, 84 insertions(+), 73 deletions(-)



pgsql: Remove new .

2023-04-23 Thread Noah Misch
Remove new .

Just intagg is obsolete, and having a one-entry list gives undue weight.

Discussion: https://postgr.es/m/20230409185050.ga949...@rfd.leadboat.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/244ab8c00c427d35901a6f1eb97e4e22b2916e7e

Modified Files
--
doc/src/sgml/contrib.sgml | 9 -
1 file changed, 9 deletions(-)



Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sun, Apr 23, 2023, 09:39 Tom Lane  wrote:

> Magnus Hagander  writes:
> > On Sat, Apr 22, 2023 at 4:25 PM Tom Lane  wrote:
> >> Magnus Hagander  writes:
> >>> It would perhaps be a good idea to push a README update to the
> >>> pg_bsd_indent repo that states this?
>
> >> Good point.  We could either do that or just take that repo down.
> >> I'm happy to push such an update if the latter seems bad.
>
> > I think it's worth doing. If we just zap it we kill history. Not that
> > there's a huge amount of it in there, but there is some and just in
> > case.
>
> OK, README update done.



Thanks!

/Magnus

>
>


Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Tom Lane
Magnus Hagander  writes:
> On Sat, Apr 22, 2023 at 4:25 PM Tom Lane  wrote:
>> Magnus Hagander  writes:
>>> It would perhaps be a good idea to push a README update to the
>>> pg_bsd_indent repo that states this?

>> Good point.  We could either do that or just take that repo down.
>> I'm happy to push such an update if the latter seems bad.

> I think it's worth doing. If we just zap it we kill history. Not that
> there's a huge amount of it in there, but there is some and just in
> case.

OK, README update done.

regards, tom lane




Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 4:25 PM Tom Lane  wrote:
>
> Magnus Hagander  writes:
> > The plan of this import is that the standalone git version is "dead",
> > correct? Given we now have a version in-tree that's newer than the one
> > in that repo?
>
> Right.
>
> > It would perhaps be a good idea to push a README update to the
> > pg_bsd_indent repo that states this?
>
> Good point.  We could either do that or just take that repo down.
> I'm happy to push such an update if the latter seems bad.


I think it's worth doing. If we just zap it we kill history. Not that
there's a huge amount of it in there, but there is some and just in
case.

--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/




pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned

Unaligned siglen could lead to an unaligned access to subsequent key fields.

Backpatch to 13, where opclass options were introduced.

Reported-by:  Alexander Lakhin
Bug: 17847
Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.org
Reviewed-by: Tom Lane, Pavel Borisov, Alexander Lakhin
Backpatch-through: 13

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/48c6825d0ec8a5021e95aea666944e9345ceb77d

Modified Files
--
contrib/ltree/expected/ltree.out |  9 +++--
contrib/ltree/ltree_gist.c   | 17 -
contrib/ltree/sql/ltree.sql  |  2 ++
doc/src/sgml/ltree.sgml  |  3 ++-
4 files changed, 27 insertions(+), 4 deletions(-)



pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions()

We need to call them only when validate == true.

Backpatch to 13, where opclass options were introduced.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us
Reviewed-by: Tom Lane, Pavel Borisov
Backpatch-through: 13

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/02191136cb25670dc9f086248f7b495d68c965d5

Modified Files
--
src/backend/access/common/reloptions.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned

Unaligned siglen could lead to an unaligned access to subsequent key fields.

Backpatch to 13, where opclass options were introduced.

Reported-by: Alexander Lakhin
Bug: 17847
Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.org
Reviewed-by: Tom Lane, Pavel Borisov, Alexander Lakhin
Backpatch-through: 13

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f4a4a18ecbdb74da70679c7bcaa395f66b68c4af

Modified Files
--
contrib/ltree/expected/ltree.out |  9 +++--
contrib/ltree/ltree_gist.c   | 17 -
contrib/ltree/sql/ltree.sql  |  2 ++
doc/src/sgml/ltree.sgml  |  3 ++-
4 files changed, 27 insertions(+), 4 deletions(-)



pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions()

We need to call them only when validate == true.

Backpatch to 13, where opclass options were introduced.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us
Reviewed-by: Tom Lane, Pavel Borisov
Backpatch-through: 13

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/9ef5a358378423a1208bee73b9cb3381f27cd3c2

Modified Files
--
src/backend/access/common/reloptions.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions()

We need to call them only when validate == true.

Backpatch to 13, where opclass options were introduced.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us
Reviewed-by: Tom Lane, Pavel Borisov
Backpatch-through: 13

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6e7361c85e95a09ee0d1fbb2f8460962b86489ab

Modified Files
--
src/backend/access/common/reloptions.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned

Unaligned siglen could lead to an unaligned access to subsequent key fields.

Backpatch to 13, where opclass options were introduced.

Reported-by: Alexander Lakhin
Bug: 17847
Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.org
Reviewed-by: Tom Lane, Pavel Borisov, Alexander Lakhin
Backpatch-through: 13

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/214495dc5b712552d3938d5f03acddfedc8a81ca

Modified Files
--
contrib/ltree/expected/ltree.out |  9 +++--
contrib/ltree/ltree_gist.c   | 17 -
contrib/ltree/sql/ltree.sql  |  2 ++
doc/src/sgml/ltree.sgml  |  3 ++-
4 files changed, 27 insertions(+), 4 deletions(-)



pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions()

We need to call them only when validate == true.

Backpatch to 13, where opclass options were introduced.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us
Reviewed-by: Tom Lane, Pavel Borisov
Backpatch-through: 13

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cd115c3530bd59bb0305d62ccef1c9504207ff4c

Modified Files
--
src/backend/access/common/reloptions.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned

Unaligned siglen could lead to an unaligned access to subsequent key fields.

Backpatch to 13, where opclass options were introduced.

Reported-by: Alexander Lakhin
Bug: 17847
Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.org
Reviewed-by: Tom Lane, Pavel Borisov, Alexander Lakhin
Backpatch-through: 13

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8bbd0cce92be98de9f4f727b8bf66fe26e5831ea

Modified Files
--
contrib/ltree/expected/ltree.out |  9 +++--
contrib/ltree/ltree_gist.c   | 17 -
contrib/ltree/sql/ltree.sql  |  2 ++
doc/src/sgml/ltree.sgml  |  3 ++-
4 files changed, 27 insertions(+), 4 deletions(-)