pgsql: doc: Update info on information schema usage tables
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it neglected to update the documentation. This is now done here. Reported-by: Erki Eessaar Reviewed-by: Erki Eessaar Discussion: https://www.postgresql.org/message-id/flat/AM9PR01MB8268EC7B696F9FE346CA5B93FEB8A%40AM9PR01MB8268.eurprd01.prod.exchangelabs.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5b2dcead39904ae56e2c17cb5c7a14e6f255790c Modified Files -- doc/src/sgml/information_schema.sgml | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)
pgsql: doc: Update info on information schema usage tables
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it neglected to update the documentation. This is now done here. Reported-by: Erki Eessaar Reviewed-by: Erki Eessaar Discussion: https://www.postgresql.org/message-id/flat/AM9PR01MB8268EC7B696F9FE346CA5B93FEB8A%40AM9PR01MB8268.eurprd01.prod.exchangelabs.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/74a1bb168dd5fafe17e0f901543b286d9b15d3e4 Modified Files -- doc/src/sgml/information_schema.sgml | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)
pgsql: doc: Update info on information schema usage tables
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it neglected to update the documentation. This is now done here. Reported-by: Erki Eessaar Reviewed-by: Erki Eessaar Discussion: https://www.postgresql.org/message-id/flat/AM9PR01MB8268EC7B696F9FE346CA5B93FEB8A%40AM9PR01MB8268.eurprd01.prod.exchangelabs.com Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1dac2dd6779a7a5b35bd222f74bee1fe8c6e560d Modified Files -- doc/src/sgml/information_schema.sgml | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)
pgsql: doc: Update info on information schema usage tables
doc: Update info on information schema usage tables Commit f40c6969d0 added the information schema usage tables but added documentation that they did not fully work yet. Commit e717a9a18b then added SQL-standard function bodies, which made the information schema views fully functional, but it neglected to update the documentation. This is now done here. Reported-by: Erki Eessaar Reviewed-by: Erki Eessaar Discussion: https://www.postgresql.org/message-id/flat/AM9PR01MB8268EC7B696F9FE346CA5B93FEB8A%40AM9PR01MB8268.eurprd01.prod.exchangelabs.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1a4d714e18127264abf856fc6c07e056bd2f558a Modified Files -- doc/src/sgml/information_schema.sgml | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)
pgsql: Fix an uninitialized access in hash_xlog_squeeze_page().
Fix an uninitialized access in hash_xlog_squeeze_page(). Commit 861f86beea changed hash_xlog_squeeze_page() to start reading the write buffer conditionally but forgot to initialize it leading to an uninitialized access. Reported-by: Alexander Lakhin Author: Hayato Kuroda Reviewed-by: Alexander Lakhin, Amit Kapila Discussion: http://postgr.es/m/62ed1a9f-746a-8e86-904b-51b9b806a...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f66fcc5cd616da8d81a2d2f9b80a9f080796f4b6 Modified Files -- src/backend/access/hash/hash_xlog.c | 2 +- src/test/regress/expected/hash_index.out | 14 ++ src/test/regress/sql/hash_index.sql | 17 + 3 files changed, 32 insertions(+), 1 deletion(-)
pgsql: meson: Stop using deprecated way getting path of files
meson: Stop using deprecated way getting path of files The just released meson 1.3 strongly deprecated a hack we were using, emitting a noisy warning (the hack basically depended on an implementation detail to work). Turns out there has been a better way available for a while, I just hadn't found it. 1.4 added a more convenient approach, but we can't rely on that. Reviewed-by: Tristan Partin Discussion: https://postgr.es/m/20231129185053.s6c7f73eg7b4z...@awork3.anarazel.de Backpatch: 16-, where the meson build was added. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/70516b8fc3ee77113013930efb7bfdbabcfed885 Modified Files -- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)
pgsql: meson: Stop using deprecated way getting path of files
meson: Stop using deprecated way getting path of files The just released meson 1.3 strongly deprecated a hack we were using, emitting a noisy warning (the hack basically depended on an implementation detail to work). Turns out there has been a better way available for a while, I just hadn't found it. 1.4 added a more convenient approach, but we can't rely on that. Reviewed-by: Tristan Partin Discussion: https://postgr.es/m/20231129185053.s6c7f73eg7b4z...@awork3.anarazel.de Backpatch: 16-, where the meson build was added. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aa11a9c14902b7bcb1d73533a0403dc50361112a Modified Files -- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)
pgsql: Adjust obsolete comment explaining set_stack_base().
Adjust obsolete comment explaining set_stack_base(). Commit 7389aad6 removed the notion of backends started from inside a signal handler. A stray comment still referred to them, while explaining the need for a call to set_stack_base(). That leads to the question of whether we still need the call in !EXEC_BACKEND builds. There doesn't seem to be much point in suppressing it now, as it doesn't hurt and probably helps to measure the stack base from the exact same place in EXEC_BACKEND and !EXEC_BACKEND builds. Back-patch to 16. Reported-by: Heikki Linnakangas Reported-by: Tristan Partin Reported-by: Andres Freund Discussion: https://postgr.es/m/CA%2BhUKG%2BEJHcevNGNOxVWxTNFbuB%3Dvjf4U68%2B85rAC_Sxvy2zEQ%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3b51265ee30784880fb2652051a4066ab9f9f90e Modified Files -- src/backend/utils/init/miscinit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
pgsql: Adjust obsolete comment explaining set_stack_base().
Adjust obsolete comment explaining set_stack_base(). Commit 7389aad6 removed the notion of backends started from inside a signal handler. A stray comment still referred to them, while explaining the need for a call to set_stack_base(). That leads to the question of whether we still need the call in !EXEC_BACKEND builds. There doesn't seem to be much point in suppressing it now, as it doesn't hurt and probably helps to measure the stack base from the exact same place in EXEC_BACKEND and !EXEC_BACKEND builds. Back-patch to 16. Reported-by: Heikki Linnakangas Reported-by: Tristan Partin Reported-by: Andres Freund Discussion: https://postgr.es/m/CA%2BhUKG%2BEJHcevNGNOxVWxTNFbuB%3Dvjf4U68%2B85rAC_Sxvy2zEQ%40mail.gmail.com Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cf84755575d1052770e92d291d1427720c8b53ca Modified Files -- src/backend/utils/init/miscinit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
pgsql: Print lwlock stats also for aux processes, when built with LWLOC
Print lwlock stats also for aux processes, when built with LWLOCK_STATS InitAuxiliaryProcess() closely resembles InitProcess(), but it didn't call InitLWLockAccess(). But because InitLWLockAccess() is a no-op unless compiled with LWLOCK_STATS, and everything works even if it's not called, the only consequence was that the stats were not printed for aux processes. This was an oversight in commit 1c6821be31f, in version 9.5, so it is missing in all supported branches. But since it only affects developers using LWLOCK_STATS and no one has complained, no backpatching. Discussion: https://www.postgresql.org/message-id/20231130202648.7k6agmuizdilu...@awork3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f93133a250c62d4dcda4298296fca759a8779621 Modified Files -- src/backend/storage/lmgr/proc.c | 7 +++ 1 file changed, 7 insertions(+)
pgsql: Fix typo in 5a1dfde8334b
Fix typo in 5a1dfde8334b Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/55d8800f-4a80-5256-1e84-246fbe79a...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ae2ccf66a261caac9701986597e3f29188f890d6 Modified Files -- src/backend/access/transam/twophase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Add missing file to nls Makefile
Add missing file to nls Makefile Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20231130.120009.1370713511317755874.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c3f4a84481b6a8d84b1928165a7bf459e5304ed8 Modified Files -- src/bin/pg_dump/nls.mk | 1 + 1 file changed, 1 insertion(+)
pgsql: Fix array subscript warnings
Fix array subscript warnings Commit a5cf808be55 accidentally passed signed chars to isalpha and isspace in the parser code which leads to undefined behavior. Fix by casting the parameters to unsigned chars. Author: Pavel Stehule Reported-by: Tom Lane Reported-by: Michael Paquier Discussion: https://postgr.es/m/388186.1701315...@sss.pgh.pa.us Discussion: https://postgr.es/m/zwgg5xim2cxqc...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/17935e1fdf0aff083347b4b2d6268d945041d188 Modified Files -- src/bin/pg_dump/filter.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)
pgsql: Fix spelling and punctuation
Fix spelling and punctuation Remove trailing periods from pg_log_error emitted strings as only hint and detail level error messages should be punctuated. Also reword the usage screen which was missing a word. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20231130.105223.554982964895179414.horikyota@gmail.com Discussion: https://postgr.es/m/20231130.103900.2069212175914114279.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b3efa270b5192f0c72dc26f0ea1bc795ad8516c3 Modified Files -- src/bin/pg_dump/pg_dump.c| 6 +++--- src/bin/pg_dump/pg_dumpall.c | 4 ++-- src/bin/pg_dump/pg_restore.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-)
pgsql: Fix warning due non-standard inline declaration in 4ed8f0913bfdb
Fix warning due non-standard inline declaration in 4ed8f0913bfdb5f355 Reported-by: Alexander Lakhin, Tom Lane Author: Pavel Borisov Discussion: https://postgr.es/m/55d8800f-4a80-5256-1e84-246fbe79a...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b589f211e025eb66f7c9e5a0b0cc23cc6fff3605 Modified Files -- src/backend/access/transam/slru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Remove redundant setting of hashkey after insertion
Remove redundant setting of hashkey after insertion It's not necessary to fill the key field in most cases, since hash_search has already done that. Some existing call sites have an assert or comment that this contract has been fulfilled, but those are quite old and that practice seems unnecessary here. While at it, remove a nearby redundant assignment that a smart compiler will elide anyway. Zhao Junwang, with some adjustments by me Reviewed by Nathan Bossart, with additional feedback from Tom Lane Discussion: http://postgr.es/m/CAEG8a3%2BUPF%3DR2QGPgJMF2mKh8xPd1H2TmfH77zPuVUFdBpiGUA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/095d109ccd76ca4c46c4ea2be30d63d70361c5f9 Modified Files -- contrib/dblink/dblink.c | 1 - src/backend/commands/async.c | 20 src/backend/commands/tablecmds.c | 3 --- .../replication/logical/applyparallelworker.c| 1 - src/backend/replication/logical/relation.c | 1 - 5 files changed, 8 insertions(+), 18 deletions(-)
