pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/caa6e12b5deb3ece8828507b2b4d4e1218d42ed7 Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f2d0af1719e608a7d5d1e51620c4b914b3137fa Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d5f965c257aed40d515e6b518422ac6e6982c46c Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/65f1623336a39f65a9d8a34e06f127cae583ff3b Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment

2017-11-27 Thread Magnus Hagander
Fix typo in comment Andreas Karlsson Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/510cc2e048f800e1764a6d6cbcf8fff4e3bda1fd Modified Files -- src/tools/msvc/config_default.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo on comment

2017-12-18 Thread Magnus Hagander
Fix typo on comment Author: David Rowley Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7731c32087faf498db0562cc7e40d256ffc1750f Modified Files -- src/backend/utils/adt/json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2017-12-09 Thread Magnus Hagander
Fix typo Reported by Robins Tharakan Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/22e71b3afb1c3bc994ba71a8c41784ddec53ceda Modified Files -- src/backend/parser/parse_utilcmd.c | 2 +- src/test/regress/expected/identity.out | 2 +- 2 files

pgsql: Fix typo

2017-12-09 Thread Magnus Hagander
Fix typo Reported by Robins Tharakan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8f632caec3fcc5eece9d53d7510322f11489fe4 Modified Files -- src/backend/parser/parse_utilcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix regression test output

2017-12-09 Thread Magnus Hagander
Fix regression test output Missed this in the last commit. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ce1468d02bdbbe3aa710463fa9faaf8cf865ad72 Modified Files -- src/test/regress/expected/identity.out | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Remove incorrect statement about IPC configuration on OpenBSD

2018-05-25 Thread Magnus Hagander
Remove incorrect statement about IPC configuration on OpenBSD kern.ipc.shm_use_phys is not a sysctl on OpenBSD, and SEMMAP is not a kernel configuration option. These were probably copy pasteos from when the documentation had a single paragraph for *BSD. Author: Daniel Gustafsson

pgsql: Remove incorrect statement about IPC configuration on OpenBSD

2018-05-25 Thread Magnus Hagander
Remove incorrect statement about IPC configuration on OpenBSD kern.ipc.shm_use_phys is not a sysctl on OpenBSD, and SEMMAP is not a kernel configuration option. These were probably copy pasteos from when the documentation had a single paragraph for *BSD. Author: Daniel Gustafsson

pgsql: Remove incorrect statement about IPC configuration on OpenBSD

2018-05-25 Thread Magnus Hagander
Remove incorrect statement about IPC configuration on OpenBSD kern.ipc.shm_use_phys is not a sysctl on OpenBSD, and SEMMAP is not a kernel configuration option. These were probably copy pasteos from when the documentation had a single paragraph for *BSD. Author: Daniel Gustafsson

pgsql: Remove incorrect statement about IPC configuration on OpenBSD

2018-05-25 Thread Magnus Hagander
Remove incorrect statement about IPC configuration on OpenBSD kern.ipc.shm_use_phys is not a sysctl on OpenBSD, and SEMMAP is not a kernel configuration option. These were probably copy pasteos from when the documentation had a single paragraph for *BSD. Author: Daniel Gustafsson

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/830e8e3609d003e320b963a7fa7c1432e10d8766 Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29ce50091d128faaabd0a4044e91a7d0da11bb8e Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/048caa5560da33d63bbcbb2063c8ecd48994c99b Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b5f096d50bee5c20023ed05390fdc52aa44a1404 Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/714d8e5fa1b21a1113d6cd444af5cbc9d67d566f Modified Files

pgsql: Fix typo in README

2018-06-07 Thread Magnus Hagander
Fix typo in README Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/848b1f3e358f4a1bb98d8c4a07ff8ee5fd7ea9a0 Modified Files -- src/backend/optimizer/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add missing include

2018-06-20 Thread Magnus Hagander
Add missing include Per buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3adcad45588bff17b1253f60cf51c440e87df997 Modified Files -- src/bin/pg_verify_checksums/pg_verify_checksums.c | 1 + 1 file changed, 1 insertion(+)

pgsql: Properly set base backup backends to active in pg_stat_activity

2017-12-29 Thread Magnus Hagander
Properly set base backup backends to active in pg_stat_activity When walsenders were included in pg_stat_activity, only the ones actually streaming WAL were listed as active when they were active. In particular, the connections sending base backups were listed as being idle. Which means that a

pgsql: Fix wording of "hostaddrs"

2018-01-21 Thread Magnus Hagander
Fix wording of "hostaddrs" The field is still called "hostaddr", so make sure references use "hostaddr values" instead. Author: Michael Paquier Branch -- REL_10_STABLE Details ---

pgsql: Fix wording of "hostaddrs"

2018-01-21 Thread Magnus Hagander
Fix wording of "hostaddrs" The field is still called "hostaddr", so make sure references use "hostaddr values" instead. Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5c15a54e851ecdd2b53e6d6a84f8ec0802ffc3cb

pgsql: Support huge pages on Windows

2018-01-21 Thread Magnus Hagander
Support huge pages on Windows Add support for huge pages (called large pages on Windows) to the Windows build. This (probably) breaks compatibility with Windows versions prior to Windows 2003 or Windows Vista. Authors: Takayuki Tsunakawa and Thomas Munro Reviewed by: Magnus Hagander, Amit

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Change default git repo URL to https

2018-02-07 Thread Magnus Hagander
Change default git repo URL to https Since we now support the server side handler for git over https (so we're no longer using the "dumb protocol"), make https the primary choice for cloning the repository, and the git protocol the secondary choice. In passing, also change the links to

pgsql: Fix typo in comment

2018-02-16 Thread Magnus Hagander
Fix typo in comment Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f8437c819acc37b43bd2d5b19a6b7609b4ea1292 Modified Files -- src/backend/access/transam/xlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2018-02-20 Thread Magnus Hagander
Fix typo Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a44a26b65d3d36867267624b76d3dea3dc4f6f6 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Support long option for --pgdata in pg_verify_checksums

2018-06-20 Thread Magnus Hagander
Support long option for --pgdata in pg_verify_checksums Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/741ee9dc819dd90270e66ab9bc254eeb7fda7100 Modified Files -- doc/src/sgml/ref/pg_verify_checksums.sgml | 3 ++-

pgsql: Move pg_verify_checksum docs to Server utils

2018-06-20 Thread Magnus Hagander
Move pg_verify_checksum docs to Server utils Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b92ef305c3eebc379af7af52ff03f75c67d39e8f Modified Files -- doc/src/sgml/reference.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Document the -D and $PGDATA switch/env for pg_verify_checksums

2018-06-20 Thread Magnus Hagander
Document the -D and $PGDATA switch/env for pg_verify_checksums Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d73300a28683fb1723ecda1a3fa767dbe8be6502 Modified Files -- doc/src/sgml/ref/pg_verify_checksums.sgml | 26

pgsql: Fix a number of typos

2018-06-20 Thread Magnus Hagander
Fix a number of typos Author: Liudmila Mantrova Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d9443d9608a872b1aa8697fa6f40a41573a35f9d Modified Files -- doc/src/sgml/cube.sgml| 2 +- doc/src/sgml/pgtrgm.sgml | 8

pgsql: Fix typo

2018-06-20 Thread Magnus Hagander
Fix typo Reported using the website comment form Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/99ba8d2f8f84fdc2721000dc5727a41e2ca8d944 Modified Files -- doc/src/sgml/dml.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2018-06-20 Thread Magnus Hagander
Fix typo Reported using the website comment form Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/39686cd7f06fb8d3c0762b4d64056ed01f085966 Modified Files -- doc/src/sgml/dml.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2018-06-20 Thread Magnus Hagander
Fix typo Reported using the website comment form Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/af050c07b05fb495ffc194c8dad2f2966070e47b Modified Files -- doc/src/sgml/dml.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2018-06-20 Thread Magnus Hagander
Fix typo Reported using the website comment form Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/74cfbc8efd3f2f34d05e5c28a0299c2a7bc9c56d Modified Files -- doc/src/sgml/dml.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2018-06-20 Thread Magnus Hagander
Fix typo Reported using the website comment form Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5a7a08ff2c38e3599eeaec06a22e91d3d7fee34b Modified Files -- doc/src/sgml/dml.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix for checksum validation patch

2018-04-03 Thread Magnus Hagander
Fix for checksum validation patch Reorder the check for non-BLCKSZ size reads to make sure we don't abort sending the file in this case. Missed in the previous commit. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a08dc711952081d63577fc182fcf955958f70add

pgsql: Validate page level checksums in base backups

2018-04-03 Thread Magnus Hagander
. This becomes the default behaviour in pg_basebackup (provided checksums are enabled on the server), so add a switch (-k) to disable the checks if necessary. Author: Michael Banck Reviewed-By: Magnus Hagander, David Steele Discussion: https://postgr.es/m/20180228180856.ge13...@nighthawk.caipicrew.dd

pgsql: Fix typo

2018-04-06 Thread Magnus Hagander
Fix typo Author: Michael Banck Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f66c37b2f7b99d1216da9b6267793cfbdc2e58c4 Modified Files -- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Allow on-line enabling and disabling of data checksums

2018-04-05 Thread Magnus Hagander
that indicates the state of checksums, so the process works across replicated clusters. Authors: Magnus Hagander and Daniel Gustafsson Review: Tomas Vondra, Michael Banck, Heikki Linnakangas, Andrey Borodin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Attempt to fix win32 build of pg_verify_checksums

2018-04-05 Thread Magnus Hagander
Attempt to fix win32 build of pg_verify_checksums S_ISLNK doesn't exist on Win32, instead we should use pgwin32_is_junction(). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3b0b4f31f73a5f45f8e122d826211c13cd2412f7 Modified Files --

Re: pgsql: Allow on-line enabling and disabling of data checksums

2018-04-06 Thread Magnus Hagander
On Fri, Apr 6, 2018 at 12:41 PM, Andrew Dunstan <andrew.dunstan@2ndquadrant. com> wrote: > On Fri, Apr 6, 2018 at 7:07 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > > > > > On Fri, Apr 6, 2018 at 2:03 AM, Andrew Dunstan > > <andrew.duns...@2n

Re: pgsql: Allow on-line enabling and disabling of data checksums

2018-04-06 Thread Magnus Hagander
On Fri, Apr 6, 2018 at 2:03 AM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > On Fri, Apr 6, 2018 at 5:35 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > Allow on-line enabling and disabling of data checksums > > > > This makes it possible to

Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums"

2018-04-09 Thread Magnus Hagander
On Mon, Apr 9, 2018 at 7:26 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > Revert "Allow on-line enabling and disabling of data checksums" > > Since this changed pg_proc.dat, there should have been a catversion &g

pgsql: catversion bump for online-checksums revert

2018-04-09 Thread Magnus Hagander
catversion bump for online-checksums revert Lack thereof pointed out by Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f5543d47bcb2fee2ab69220f51e2078c11e19843 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1

pgsql: Revert "Allow on-line enabling and disabling of data checksums"

2018-04-09 Thread Magnus Hagander
Revert "Allow on-line enabling and disabling of data checksums" This reverts the backend sides of commit 1fde38beaa0c3e66c340efc7cc0dc272d6254bb0. I have, at least for now, left the pg_verify_checksums tool in place, as this tool can be very valuable without the rest of the patch as well, and

Re: pgsql: Allow background workers to bypass datallowconn

2018-04-05 Thread Magnus Hagander
t; Apr 05 13:09:08 : recipe for target 'worker_spi.o' failed > > Gah, I didn't run those tests. Thanks, fix pushed. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

pgsql: Fix worker_spi for new parameter to initialize connection

2018-04-05 Thread Magnus Hagander
Fix worker_spi for new parameter to initialize connection Missed in previous commit. Spotted by Teodor and the buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6a5f796b48b0e9808fef9731da8aea17f56de999 Modified Files --

pgsql: Allow background workers to bypass datallowconn

2018-04-05 Thread Magnus Hagander
Allow background workers to bypass datallowconn THis adds a "flags" field to the BackgroundWorkerInitializeConnection() and BackgroundWorkerInitializeConnectionByOid(). For now only one flag, BGWORKER_BYPASS_ALLOWCONN, is defined, which allows the worker to ignore datallowconn. Branch --

pgsql: Make sure pg_rewind can't run as root

2018-04-09 Thread Magnus Hagander
Make sure pg_rewind can't run as root Previously a warning was printed, but the tool actually kept running even when running as root. This is something we definitely want to prevent, but since this means a behavior change, not backpatching. Author: Michael Paquier Branch -- master Details

pgsql: Silence some warnings in TAP tests

2018-04-09 Thread Magnus Hagander
Silence some warnings in TAP tests Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d7754822c52ccb6dfb1c29607ae352c2028979d2 Modified Files -- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 2 +- src/test/perl/PostgresNode.pm

pgsql: Add missing documentation for BGWORKER_BYPASS_ALLOWCONN

2018-04-22 Thread Magnus Hagander
Add missing documentation for BGWORKER_BYPASS_ALLOWCONN This was missed in eed1ce72e1593d3e8b7461d7744808d4d6bf402b. Reported by Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9cad926eb876a30d58a5b39789098da83a6ef91c Modified Files --

pgsql: Remove -f option from pg_verify_checksums

2018-04-15 Thread Magnus Hagander
Remove -f option from pg_verify_checksums This option makes no sense when the cluster checksum state cannot be changed, and should have been removed in the revert. Author: Daniel Gustafsson Review: Michael Paquier Branch -- master Details ---

pgsql: Clarify pg_verify_checksum documentation

2018-04-15 Thread Magnus Hagander
Clarify pg_verify_checksum documentation Make it clear that a cluster has to be shut down cleanly before pg_verify_checksum can be run against it. Author: Michael Paquier Review: Daniel Gustafsson Branch -- master Details ---

pgsql: Don't attempt to verify checksums on new pages

2018-04-15 Thread Magnus Hagander
Don't attempt to verify checksums on new pages Teach both base backups and pg_verify_checksums that if a page is new, it does not have a checksum yet, so it shouldn't be verified. Noted by Tomas Vondra, review by David Steele. Branch -- master Details ---

pgsql: Add comment explaining BGWORKER_BYPASS_ALLOWCONN

2018-04-23 Thread Magnus Hagander
Add comment explaining BGWORKER_BYPASS_ALLOWCONN Suggested by Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/43cc4ee6340779f2a17fb5bab27355c2cb2e23a6 Modified Files -- src/include/postmaster/bgworker.h | 8 +++- 1 file changed, 7

pgsql: Fix typo in comment

2018-03-30 Thread Magnus Hagander
Fix typo in comment Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/019fa576ca8298ecb7b8ded6e0c857840b57a4ae Modified Files -- src/backend/access/transam/xlog.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix typo in comment

2018-03-29 Thread Magnus Hagander
Fix typo in comment Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9778d5c180c06998c315a4ae4753b927e3bc4ea8 Modified Files -- src/bin/pg_dump/pg_backup_custom.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix incorrect copy/paste in comment

2018-03-29 Thread Magnus Hagander
Fix incorrect copy/paste in comment Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8cdc834647b8b1558c10a7d27a3580a32e04c500 Modified Files -- src/test/subscription/t/003_constraints.pl | 2 +- 1

pgsql: Fix typo in comment

2018-03-29 Thread Magnus Hagander
Fix typo in comment Arthur Zakirov, confirmed by Thomas Munro Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/669820a3d9c359e8d44a26035cb4d675dc542cb4 Modified Files -- src/backend/utils/cache/typcache.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: pgsql: Validate page level checksums in base backups

2018-04-03 Thread Magnus Hagander
On Tue, Apr 3, 2018 at 7:13 PM, Andres Freund <and...@anarazel.de> wrote: > On 2018-04-03 11:52:26 +0000, Magnus Hagander wrote: > > Validate page level checksums in base backups > > > > When base backups are run over the replication protocol (for example >

pgsql: Properly use INT64_FORMAT in output

2018-04-03 Thread Magnus Hagander
Properly use INT64_FORMAT in output Per buildfarm animal prairiedog, suggestion solution from Tom. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/10d62d1065290469ae79518f8166550b2760dc26 Modified Files -- src/backend/replication/basebackup.c | 8

Re: pgsql: Validate page level checksums in base backups

2018-04-03 Thread Magnus Hagander
On Tue, Apr 3, 2018 at 8:29 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > Yeah, there's clearly a second problem here. > > I think this test script is broken in many ways. > > It's scribbling on the source

pgsql: Fix pg_bsaebackup checksum tests

2018-04-04 Thread Magnus Hagander
Fix pg_bsaebackup checksum tests Hopefully fix the fact that these checks are unstable, by introducing the corruption in a separate table from pg_class, and also explicitly disable autovacuum on those tables. Also make sure PostgreSQL is stopped while the corruption is introduced to avoid

Re: pgsql: Validate page level checksums in base backups

2018-04-04 Thread Magnus Hagander
On Tue, Apr 3, 2018 at 10:48 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > On Tue, Apr 03, 2018 at 08:48:08PM +0200, Magnus Hagander wrote: > > On Tue, Apr 3, 2018 at 8:29 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > I'd bet a good lunch t

pgsql: Fix pg_recvlogical for pre-10 versions

2018-03-18 Thread Magnus Hagander
Fix pg_recvlogical for pre-10 versions In e170b8c8, protection against modified search_path was added. However, PostgreSQL versions prior to 10 does not accept SQL commands over a replication connection, so the protection would generate a syntax error. Since we cannot run SQL commands on it, we

pgsql: Fix pg_recvlogical for pre-10 versions

2018-03-18 Thread Magnus Hagander
Fix pg_recvlogical for pre-10 versions In e170b8c8, protection against modified search_path was added. However, PostgreSQL versions prior to 10 does not accept SQL commands over a replication connection, so the protection would generate a syntax error. Since we cannot run SQL commands on it, we

pgsql: Fix pg_recvlogical for pre-10 versions

2018-03-18 Thread Magnus Hagander
Fix pg_recvlogical for pre-10 versions In e170b8c8, protection against modified search_path was added. However, PostgreSQL versions prior to 10 does not accept SQL commands over a replication connection, so the protection would generate a syntax error. Since we cannot run SQL commands on it, we

pgsql: Fix pg_recvlogical for pre-10 versions

2018-03-18 Thread Magnus Hagander
Fix pg_recvlogical for pre-10 versions In e170b8c8, protection against modified search_path was added. However, PostgreSQL versions prior to 10 does not accept SQL commands over a replication connection, so the protection would generate a syntax error. Since we cannot run SQL commands on it, we

pgsql: Fix typo in comment

2018-03-19 Thread Magnus Hagander
Fix typo in comment Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/71cce90ee99098f52e65278b96662e32ca005771 Modified Files -- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Actually pick .lib file when multiple perl libs are present

2018-03-04 Thread Magnus Hagander
Actually pick .lib file when multiple perl libs are present 7240962f8626ff09bb8f9e71ecdb074775bdd035 got it right in the comment, but the code did not actually do what the comment said. Fix that. Issue pointed out by Noah Misch. Branch -- master Details ---

pgsql: Fix msvc builds for ActivePerl > 5.24

2018-03-02 Thread Magnus Hagander
Fix msvc builds for ActivePerl > 5.24 From this version ActivePerl ships both a .lib and a .a file for the perl library, which our code would detect as there being no library available. Instead, we should pick the .lib version and use that. Report and suggested fix in bug #15065 Author: Heath

pgsql: Fix speling error

2018-10-08 Thread Magnus Hagander
Fix speling error Reported by Alexander Lakhin in bug #15423 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4d7c74039f091e04e520d5688c964f653f8c55a8 Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix speling error

2018-10-08 Thread Magnus Hagander
Fix speling error Reported by Alexander Lakhin in bug #15423 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a9da329be0bec586589cefc78da03ddb3fc13cbb Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/679ad2f969772297e4725715ea24e5d38526590d Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e873886b83e1ef5787dc0e4cd9588a703b4324a0 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b5f1717ef54868d34e9f588aa20adc3e2ea72c8b Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fe42d4be7b09267f77bccc0968933e45ee5beaed Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/56c0484b2ef10cacdfc3f35e017e8049ecc0800b Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bd3fc725b235e587864376ad8dfa60100eecf45c Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix missing whitespace in pg_dump ref page

2018-10-29 Thread Magnus Hagander
Fix missing whitespace in pg_dump ref page Author: Daniel Gustafsson Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ba5644d996f5a53306049e0004ecb07a9f74fb79 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+),

pgsql: Fix some spelling errors in the documentation

2018-11-02 Thread Magnus Hagander
Fix some spelling errors in the documentation Author: Daniel Gustafsson Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/919cffd323a0408a31cde7bc58994add5694b7fc Modified Files -- doc/src/sgml/libpq.sgml | 6 +++--- doc/src/sgml/lobj.sgml | 2 +-

pgsql: Fix some spelling errors in the documentation

2018-11-02 Thread Magnus Hagander
Fix some spelling errors in the documentation Author: Daniel Gustafsson Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/51afe7602bfa703f93b22fb81f13e8201f0f2b56 Modified Files -- doc/src/sgml/libpq.sgml | 6 +++--- doc/src/sgml/lobj.sgml | 2 +-

pgsql: Fix some spelling errors in the documentation

2018-11-02 Thread Magnus Hagander
Fix some spelling errors in the documentation Author: Daniel Gustafsson Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/708b96d56aee3cee830623f26c231e371fda19e4 Modified Files -- doc/src/sgml/libpq.sgml | 6 +++---

pgsql: Fix some spelling errors in the documentation

2018-11-02 Thread Magnus Hagander
Fix some spelling errors in the documentation Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0083a824333874570ec34b23c9acd445d1183036 Modified Files -- doc/src/sgml/libpq.sgml | 6 +++--- doc/src/sgml/lobj.sgml

pgsql: Fix some spelling errors in the documentation

2018-11-02 Thread Magnus Hagander
Fix some spelling errors in the documentation Author: Daniel Gustafsson Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f67ff17e2b302a97b1a10127d91746d54f4655c Modified Files -- doc/src/sgml/libpq.sgml | 6 +++--- doc/src/sgml/lobj.sgml | 2 +-

pgsql: Fix spelling errors and typos in comments

2018-11-02 Thread Magnus Hagander
Fix spelling errors and typos in comments Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fbec7459aa39da864ad1d578f044a21c3b3b057c Modified Files -- src/backend/access/nbtree/nbtsearch.c | 2 +-

pgsql: Replace references to mailinglists with @lists.postgresql.org

2019-01-17 Thread Magnus Hagander
Replace references to mailinglists with @lists.postgresql.org The namespace for all lists have changed a while ago, so all references should use the correct address. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cc65b7686bb4f01f7675c73beef9d67493c67017

pgsql: Remove references to Majordomo

2019-01-17 Thread Magnus Hagander
Remove references to Majordomo Lists are not handled by Majordomo anymore and haven't been for a while, so remove the reference and instead direct people to the list server. Branch -- REL9_4_STABLE Details ---

pgsql: Replace references to mailinglists with @lists.postgresql.org

2019-01-17 Thread Magnus Hagander
Replace references to mailinglists with @lists.postgresql.org The namespace for all lists have changed a while ago, so all references should use the correct address. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c0d0e540847d24d9dfe374549fb4cfd5ca40d050 Modified

pgsql: Remove references to Majordomo

2019-01-17 Thread Magnus Hagander
Remove references to Majordomo Lists are not handled by Majordomo anymore and haven't been for a while, so remove the reference and instead direct people to the list server. Branch -- REL_11_STABLE Details ---

pgsql: Remove references to Majordomo

2019-01-17 Thread Magnus Hagander
Remove references to Majordomo Lists are not handled by Majordomo anymore and haven't been for a while, so remove the reference and instead direct people to the list server. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0e10040e19db02a797a2597d2fecbaa094f04866

pgsql: Remove references to Majordomo

2019-01-17 Thread Magnus Hagander
Remove references to Majordomo Lists are not handled by Majordomo anymore and haven't been for a while, so remove the reference and instead direct people to the list server. Branch -- REL_10_STABLE Details ---

pgsql: Replace references to mailinglists with @lists.postgresql.org

2019-01-17 Thread Magnus Hagander
Replace references to mailinglists with @lists.postgresql.org The namespace for all lists have changed a while ago, so all references should use the correct address. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef2cd88fb0f3a62312bdd33c8f5f36b9b18fc1ac

pgsql: Remove references to Majordomo

2019-01-17 Thread Magnus Hagander
Remove references to Majordomo Lists are not handled by Majordomo anymore and haven't been for a while, so remove the reference and instead direct people to the list server. Branch -- REL9_6_STABLE Details ---

  1   2   3   >