Re: pgsql: make dist uses git archive

2024-03-26 Thread Magnus Hagander
On Tue, Mar 26, 2024 at 12:09 PM Andrew Dunstan wrote: > > > On Tue, Mar 26, 2024 at 6:10 AM Andrew Dunstan > wrote: > >> >> >> On Tue, Mar 26, 2024 at 5:15 AM Magnus Hagander >> wrote: >> >>> >>> >>> On Tue, Mar 26, 2024

Re: pgsql: make dist uses git archive

2024-03-26 Thread Magnus Hagander
On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan wrote: > > > On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut > wrote: > >> On 25.03.24 23:20, Andrew Dunstan wrote: >> > The problem occurs because except in vpath mode the buildfarm operates >> > on a copy of the code, and for efficiency reasons

Re: pgsql: make dist uses git archive

2024-03-25 Thread Magnus Hagander
On Mon, Mar 25, 2024 at 8:30 PM Peter Eisentraut wrote: > On 25.03.24 10:04, Magnus Hagander wrote: > > This seems to have broken buildfarm member guaibasaurus, which I believe > > is the only one that runs "make dist" as part of the buildfarm. And as a > > result,

Re: pgsql: make dist uses git archive

2024-03-25 Thread Magnus Hagander
This seems to have broken buildfarm member guaibasaurus, which I believe is the only one that runs "make dist" as part of the buildfarm. And as a result,t hat breaks the snapshot build uploads. I don't know exactly how it does it, it appears to not run from within the git repository. It might be

pgsql: Clarify which xml tools are missing in meson error message

2024-01-11 Thread Magnus Hagander
Clarify which xml tools are missing in meson error message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/544bcb5a5e778e8ef8d784de611c5f85bc33433c Modified Files -- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Fix omission in partitioning limitation documentation

2024-01-11 Thread Magnus Hagander
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By:

pgsql: Show the default checkpoint method in the pg_basebackup help mes

2024-01-10 Thread Magnus Hagander
Show the default checkpoint method in the pg_basebackup help message Author: Michael Banck Reviewed-By: Aleksander Alekseev, Michael Paquier, Peter Eisentraut Discussion: https://postgr.es/m/6530f954.170a0220.5637c.9...@mx.google.com Branch -- master Details ---

Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sun, Apr 23, 2023, 09:39 Tom Lane wrote: > Magnus Hagander writes: > > On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > >> Magnus Hagander writes: > >>> It would perhaps be a good idea to push a README update to the > >>> pg_bsd_indent repo that

Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > > Magnus Hagander writes: > > The plan of this import is that the standalone git version is "dead", > > correct? Given we now have a version in-tree that's newer than the one > > in that repo? > > Righ

Re: pgsql: Import pg_bsd_indent sources.

2023-04-22 Thread Magnus Hagander
On Sun, Feb 12, 2023 at 6:22 PM Tom Lane wrote: > > Import pg_bsd_indent sources. > > This brings in an exact copy of the pg_bsd_indent repo as of > commit d301442799cea44e5ccb04331afc537764ec77c5 (2020-12-28). The plan of this import is that the standalone git version is "dead", correct? Given

Re: pgsql: Remove outdated recommendation for manual VACUUM

2022-06-27 Thread Magnus Hagander
On Mon, Jun 27, 2022 at 8:57 PM Bruce Momjian wrote: > On Mon, Jun 27, 2022 at 05:48:41PM +0000, Magnus Hagander wrote: > > Remove outdated recommendation for manual VACUUM > > > > We have had a working and tunable autovacuum > > for at least a decade now, s

pgsql: Remove outdated recommendation for manual VACUUM

2022-06-27 Thread Magnus Hagander
(ANALYZE) after lots of INSERTs or DELETEs. Instead, suggest using autovacuum by moving the respective paragraph up to where the importance of VACUUM is emphasized. Author: Laurenz Albe Reviewed-By: Magnus Hagander, Peter Geoghegan Discussion: https://postgr.es/m

pgsql: Recommend scram-sha-256 instead of md5 authentication in docs

2022-05-31 Thread Magnus Hagander
Recommend scram-sha-256 instead of md5 authentication in docs PostgreSQL 14 changed the default to be scram-sha-256, so we should stop recommending the user to use md5 or even worse password. Suggested-By: Daniel Westermann Author: Jonathan S. Katz Backpatch-through: 14 Discussion:

pgsql: Recommend scram-sha-256 instead of md5 authentication in docs

2022-05-31 Thread Magnus Hagander
Recommend scram-sha-256 instead of md5 authentication in docs PostgreSQL 14 changed the default to be scram-sha-256, so we should stop recommending the user to use md5 or even worse password. Suggested-By: Daniel Westermann Author: Jonathan S. Katz Backpatch-through: 14 Discussion:

pgsql: Add JIT counters to pg_stat_statements

2022-04-08 Thread Magnus Hagander
Add JIT counters to pg_stat_statements This adds cumulative counters for jit operations to pg_stat_statements, making it easier to diagnose how JIT is used in an installation. These changes merge into the 1.10 changes applied in 76cbf7edb6 without creating a new version. Reviewed-By: Julien

Re: pgsql: Allow extensions to add new backup targets.

2022-03-21 Thread Magnus Hagander
(+), 55 deletions(-) This one has a tiny copy/paste error where the idenfiication comment for basebackup_target.c claims it's basebackup_gzip.c. I've pushed a fix. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

pgsql: Fix typo in file identification

2022-03-21 Thread Magnus Hagander
Fix typo in file identification Clearly a simple copy/paste mistake when the file was created. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c540d3715731e0e50259011ee62ea4c0c042b1b1 Modified Files -- src/backend/replication/basebackup_target.c | 2 +-

pgsql: Fix pg_hba_file_rules for authentication method cert

2022-01-26 Thread Magnus Hagander
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12

pgsql: Fix pg_hba_file_rules for authentication method cert

2022-01-26 Thread Magnus Hagander
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12

pgsql: Fix pg_hba_file_rules for authentication method cert

2022-01-26 Thread Magnus Hagander
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12

pgsql: Fix pg_hba_file_rules for authentication method cert

2022-01-26 Thread Magnus Hagander
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/79a4bf45e83ec92ea24421c0ce0790ecb0aa1542 Modified Files

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c8110854168eb3799ccaaddb720678d0de6b0ee Modified Files

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ca89bbee9b1c67fc9631abd96ea1c5837ea201b Modified Files

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f0c5866113fb1d85ada6dc3fe67e4909d94bacc2 Modified Files

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/69872d0bbe64fcd67c4fb4c61e5c7bf6a3443a47 Modified Files

pgsql: Fix typo

2022-01-02 Thread Magnus Hagander
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/580e99885970179d058d79914c43fb7bcba9242c Modified Files

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_12_STABLE

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- master Details

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_10_STABLE

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_11_STABLE

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_13_STABLE

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL9_6_STABLE

pgsql: Clarify that --system reindexes system catalogs *only*

2021-10-27 Thread Magnus Hagander
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_14_STABLE

pgsql: Properly schema-prefix reference to pg_catalog.pg_get_statistics

2021-09-28 Thread Magnus Hagander
Properly schema-prefix reference to pg_catalog.pg_get_statisticsobjdef_columns Author: Tatsuro Yamada Backpatch-through: 14 Discussion: https://www.postgresql.org/message-id/7ad8cd13-db5b-5cf6-8561-dccad1a93...@nttcom.co.jp Branch -- REL_14_STABLE Details ---

pgsql: Properly schema-prefix reference to pg_catalog.pg_get_statistics

2021-09-28 Thread Magnus Hagander
Properly schema-prefix reference to pg_catalog.pg_get_statisticsobjdef_columns Author: Tatsuro Yamada Backpatch-through: 14 Discussion: https://www.postgresql.org/message-id/7ad8cd13-db5b-5cf6-8561-dccad1a93...@nttcom.co.jp Branch -- master Details ---

pgsql: Consistently use read-only instead of "read only"

2021-09-07 Thread Magnus Hagander
Consistently use read-only instead of "read only" This affects one message and some documentation that used the format "read only", unlike everything else that used read-only. Backpatch-through: 14 Discussion:

pgsql: Consistently use read-only instead of "read only"

2021-09-07 Thread Magnus Hagander
Consistently use read-only instead of "read only" This affects one message and some documentation that used the format "read only", unlike everything else that used read-only. Backpatch-through: 14 Discussion:

pgsql: Clarify description of pg_stat_statements columns

2021-07-14 Thread Magnus Hagander
Clarify description of pg_stat_statements columns Reported-By: Peter Eisentraut Backpatch-through: 14 Discussion: https://postgr.es/m/8f5e63b8-e8ed-0f80-d8c4-68222624c...@enterprisedb.com Branch -- master Details ---

pgsql: Clarify description of pg_stat_statements columns

2021-07-14 Thread Magnus Hagander
Clarify description of pg_stat_statements columns Reported-By: Peter Eisentraut Backpatch-through: 14 Discussion: https://postgr.es/m/8f5e63b8-e8ed-0f80-d8c4-68222624c...@enterprisedb.com Branch -- REL_14_STABLE Details ---

pgsql: Remove obsolete reference to winflex download

2021-05-17 Thread Magnus Hagander
Remove obsolete reference to winflex download We used to distribute a binary version of flex for windows on our download site, but it hasn't been working for many years. The "old documentation" referenced was also for versions that have been EOL for many years. So, remove it. Discussion:

pgsql: Fix wording in description of pg_stat_statements.toplevel

2021-05-17 Thread Magnus Hagander
Fix wording in description of pg_stat_statements.toplevel Incorrect wording got applied in 7531fcb1fcf. Reported-By: Fujii Masao Discussion: https://postgr.es/m/e5512912-eac9-b163-df2b-e2601ce06...@oss.nttdata.com Branch -- master Details ---

pgsql: Mention that toplevel is part of pg_stat_statements key.

2021-04-23 Thread Magnus Hagander
Mention that toplevel is part of pg_stat_statements key. While at it, also document that toplevel is always true if pg_stat_statements.track is set to top. Author: Julien Rouhaud Reported-By: Fujii Masao Discussion: https://postgr.es/m/a878d5ea-64a7-485e-5d2f-177618ebc...@oss.nttdata.com

pgsql: Fix typo in comment

2021-04-20 Thread Magnus Hagander
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7311fa8a7096b3a00fc39a10c5a20d4cf0564bfa Modified Files --

pgsql: Fix typo in comment

2021-04-20 Thread Magnus Hagander
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf5d1f1e0052100b716f7b7b0934aefb28f72e73 Modified Files --

pgsql: Fix typo in comment

2021-04-20 Thread Magnus Hagander
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8b4b5669cde2b17bd6b5d68f584d97078f3296ac Modified Files --

pgsql: Fix typo in comment

2021-04-20 Thread Magnus Hagander
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e4fbd11a1d5c291fe719b0bc833882e0baad1f8e Modified Files --

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/721b3a3a9368c0bd5e9b92892279f0fa441efeee

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c777a1fcc6ba1d61bbb763f6fbd3ac8a5994446d

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/19b28d69128a7ca78705be9f4afca5044541beca

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/91a3a7dc63e8fded60b41cd842eba9a8e31f2b5d

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2bf44fbe271dae3f4bd458e19e32d51996b988b4

pgsql: Fix typo

2021-04-09 Thread Magnus Hagander
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1798d8f8b6fbb8ff922f640ff2d5dbd3e47064a2

pgsql: Merge v1.10 of pg_stat_statements into v1.9

2021-04-08 Thread Magnus Hagander
Merge v1.10 of pg_stat_statements into v1.9 v1.9 is already new in this version of PostgreSQL, so turn it into just one change. Author: Julien Rohaud Discussion: https://postgr.es/m/20210408120505.7zinijtdexbyghvb@nol Branch -- master Details ---

pgsql: Add functions to wait for backend termination

2021-04-08 Thread Magnus Hagander
). The default behaviour of pg_terminate_backend() remains being timeout=0 which does not waiting. For pg_wait_for_backend_termination() the default wait is 5 seconds. Author: Bharath Rupireddy Reviewed-By: Fujii Masao, David Johnston, Muhammad Usama, Hou Zhijie, Magnus Hagander Discussion

pgsql: Track identical top vs nested queries independently in pg_stat_s

2021-04-08 Thread Magnus Hagander
sted. Author: Julien Rohaud Reviewed-By: Magnus Hagander, Masahiro Ikeda Discussion: https://postgr.es/m/20201202040516.GA43757@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6b4d23feef6e334fb85af077f2857f62ab781848 Modified Files -- contrib/pg_st

pgsql: Refactor hba_authname

2021-04-07 Thread Magnus Hagander
Refactor hba_authname The previous implementation (from 9afffcb833) had an unnecessary check on the boundaries of the enum which trigtered compile warnings. To clean it up, move the pre-existing static assert to a central location and call that. Reported-By: Erik Rijkers Reviewed-By: Michael

pgsql: Fix function name in error hint

2021-03-18 Thread Magnus Hagander
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the

pgsql: Fix function name in error hint

2021-03-18 Thread Magnus Hagander
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the

pgsql: Fix function name in error hint

2021-03-18 Thread Magnus Hagander
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the

pgsql: Fix function name in error hint

2021-03-18 Thread Magnus Hagander
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the

pgsql: Clarify that CREATEROLE roles are considered Administrators

2021-03-06 Thread Magnus Hagander
Clarify that CREATEROLE roles are considered Administrators Author: Michael Banck Reviewed-By: Robert Treat Discussion: https://postgr.es/m/2160a5071a7bb5339055b04a8cad81a822be9d8d.ca...@credativ.de Branch -- master Details ---

pgsql: Improve docs on updatable views

2021-03-06 Thread Magnus Hagander
Improve docs on updatable views Introduce the options before going into details, and add a link to the CREATE TRIGGER documentation. Author: David Johnston Reviewed-By: Anastasia Lubennikova Discussion: https://postgr.es/m/CAKFQuwYLLRhheo0_Y4Jp=vj_ydsz1korutpx1a_buxmhtml...@mail.gmail.com

pgsql: Fix docs build for website styles

2021-02-22 Thread Magnus Hagander
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn

pgsql: Fix docs build for website styles

2021-02-22 Thread Magnus Hagander
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn

pgsql: Fix typo

2021-02-17 Thread Magnus Hagander
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/daf2e708edfbc0741f8a229a0c30fdd0168b525e Modified Files --

pgsql: Fix typo

2021-02-17 Thread Magnus Hagander
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6a31b48ec88ae506c6f115948c86f61abb89a89a Modified Files --

pgsql: Fix typo

2021-02-17 Thread Magnus Hagander
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5d319ce86f13d1b0e7fb911408fe012723259723 Modified Files --

pgsql: Fix typo

2021-02-17 Thread Magnus Hagander
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a29f30780f34d7706fcd398dea1d6882d184d17a Modified Files --

pgsql: Remove extra Success message at the end of initdb

2021-02-10 Thread Magnus Hagander
Remove extra Success message at the end of initdb This was accidentally included in e09155bd62 and is redundant with the lines right above it. Reported-By: Peter Eisentraut Discussion: https://postgr.es/m/455845d1-441d-cc40-d2a7-b47f4e422...@2ndquadrant.com Branch -- master Details

pgsql: Remove make_diff set of tools

2021-01-24 Thread Magnus Hagander
Remove make_diff set of tools These are mostly obsoleted by the switch to git, and it's easier to remove them than to update the incorrect documentation. Discussion: https://postgr.es/m/cabuevewmasmn4wrj6ragbx43sj10ctfmhcma_-7ka3pdymw...@mail.gmail.com Branch -- master Details ---

pgsql: Remove reference to ftp servers from documentation

2021-01-22 Thread Magnus Hagander
Remove reference to ftp servers from documentation It's been a long time since we used ftp, but there was a single reference left in the docs. Author: Daniel Gustafsson Discussion: https://postgr.es/m/6880d602-7286-46ec-8a03-14e3248fe...@yesql.se Branch -- master Details ---

Re: pgsql: Add pg_stat_database counters for sessions and session time

2021-01-18 Thread Magnus Hagander
On Mon, Jan 18, 2021 at 5:09 PM Laurenz Albe wrote: > > On Sun, 2021-01-17 at 13:07 +, Magnus Hagander wrote: > > Add pg_stat_database counters for sessions and session time > > > > This add counters for number of sessions, the different kind of session > >

pgsql: Bump PGSTAT_FILE_FORMAT_ID

2021-01-18 Thread Magnus Hagander
Bump PGSTAT_FILE_FORMAT_ID This was missed in 960869da08 Reported-By: Laurenz Albe Discussion: https://postgr.es/m/4f0aacc5fe1b4bfafa32b36ecd97469fae526a75.ca...@cybertec.at Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2f87b46690ab8cd3ee7c77226fcf3f5bb713e5b

pgsql: Add documentation chapter about checksums

2021-01-17 Thread Magnus Hagander
-By: Magnus Hagander, Michael Banck (and others through the big patch) Discussion: https://postgr.es/m/5ff49fa4.1c69fb81.658f3.0...@mx.google.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cf621d9d84db1e6edaff8ffa26bad93fdce5f830 Modified Files -- doc

pgsql: Add --no-instructions parameter to initdb

2021-01-17 Thread Magnus Hagander
would still be useful (and thus just redirecting everything to /dev/null would be bad). Author: Magnus Hagander Reviewed-By: Peter Eisentraut Discusion: https://postgr.es/m/CABUevEzo4t5bmTXF0_B9WzmuWpVbMpkNZZiGvzV8NZa-=fp...@mail.gmail.com Branch -- master Details --- https

pgsql: Add pg_stat_database counters for sessions and session time

2021-01-17 Thread Magnus Hagander
force" to disconnect. This was the only use-case for the parameter before, so repurposing it to this mroe narrow usecase makes things cleaner than inventing something new. Author: Laurenz Albe Reviewed-By: Magnus Hagander, Soumyadeep Chakraborty, Masahiro Ikeda Discussion: https://p

pgsql: Remove incorrect markup

2021-01-13 Thread Magnus Hagander
Remove incorrect markup Seems 737d69ffc3c made a copy/paste or automation error resulting in two extra right-parenthesis. Reported-By: Michael Vastola Backpatch-through: 13 Discussion: https://postgr.es/m/161051035421.12224.1741822783166533...@wrigleys.postgresql.org Branch --

pgsql: Remove incorrect markup

2021-01-13 Thread Magnus Hagander
Remove incorrect markup Seems 737d69ffc3c made a copy/paste or automation error resulting in two extra right-parenthesis. Reported-By: Michael Vastola Backpatch-through: 13 Discussion: https://postgr.es/m/161051035421.12224.1741822783166533...@wrigleys.postgresql.org Branch -- master

pgsql: Remove ability to independently select random number generator

2020-11-20 Thread Magnus Hagander
: Daniel Gustafsson, Magnus Hagander, Michael Paquier Discussion: https://postgr.es/m/632623.1605460...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/16f96c74d48e65da23d28665103e2c4c9d3414cc Modified Files -- configure

pgsql: Remove line missed in previous commit

2020-11-11 Thread Magnus Hagander
Remove line missed in previous commit Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4e3ffd5981536f93787ae6d81bc179da0acc423e Modified Files -- src/tools/msvc/vcregress.pl | 1 - 1 file changed, 1 deletion(-)

pgsql: Remove vacuumdb --analyze-in-stages from pg_upgrade tests

2020-11-11 Thread Magnus Hagander
Remove vacuumdb --analyze-in-stages from pg_upgrade tests This step was only there to test the script when we generated those, but commit 8f113698b6 removed those scripts, so it's not needed anymore. Reported-By: Peter Eisentraut Discussion:

pgsql: Remove -o option to postmaster

2020-11-10 Thread Magnus Hagander
Remove -o option to postmaster This option was declared obsolete many years ago. Reviewed-By: Tom Lane Discussion: https://postgr.es/m/CABUevEyOE=9CQwZm2j=vwp5+6olcsoxn9pbjk8gyrdktzmf...@mail.gmail.com Branch -- master Details ---

pgsql: Remove analyze_new_cluster script from pg_upgrade

2020-11-09 Thread Magnus Hagander
Remove analyze_new_cluster script from pg_upgrade Since this script just runs vacuumdb anyway, remove the script and replace the instructions to run it with instructions to run vacuumdb directly. Reviewed-By: Michael Paquier Discussion:

pgsql: Remove incorrect %s in string

2020-11-09 Thread Magnus Hagander
Remove incorrect %s in string Appears to have been a copy/paste error in the original commit that moved the messages to fe_utils/. Author: Tang, Haiying Backpatch-through: 13 Discussion: https://postgr.es/m/3321cbcea76d4d2c8320a05c19b9304a@G08CNEXMBPEKD05.g08.fujitsu.local Branch --

pgsql: Remove incorrect %s in string

2020-11-09 Thread Magnus Hagander
Remove incorrect %s in string Appears to have been a copy/paste error in the original commit that moved the messages to fe_utils/. Author: Tang, Haiying Backpatch-through: 13 Discussion: https://postgr.es/m/3321cbcea76d4d2c8320a05c19b9304a@G08CNEXMBPEKD05.g08.fujitsu.local Branch --

pgsql: Add pg_strong_random_init function to initialize random number g

2020-11-06 Thread Magnus Hagander
it). All other implementations are left empty at this time, but more are expected to be added in the future. Author: Daniel Gustafsson , Michael Paquier Reviewed-By: Magnus Hagander Discussion: https://postgr.es/m/f6291c3c-747c-4c93-bce0-28bb420b1...@yesql.se Branch -- master Details

Re: pgsql: Add pg_depend.refobjversion.

2020-11-05 Thread Magnus Hagander
On Thu, Nov 5, 2020 at 8:17 PM Tom Lane wrote: > > Magnus Hagander writes: > > On Thu, Nov 5, 2020 at 3:50 PM Tom Lane wrote: > >> AFAIK the agreed-on process is to do that once per release cycle. > >> Is there some reason why it needs to be done now? >

Re: pgsql: Add pg_depend.refobjversion.

2020-11-05 Thread Magnus Hagander
entation), but that could definitely be my searching -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

pgsql: Use the non-deprecated TG_TABLE_MAME in test trigger

2020-11-03 Thread Magnus Hagander
Use the non-deprecated TG_TABLE_MAME in test trigger Commit 3a9ae3d2068 (back in 2006) deprecated TG_RELNAME in favor of TG_TABLE_NAME, but the existing usage in test cases has remained till today. Change to use TG_TABLE_NAME instead (TG_RELNAME is still covered by a test case). Branch --

pgsql: Improve error handling in backend OpenSSL implementation

2020-11-03 Thread Magnus Hagander
Improve error handling in backend OpenSSL implementation Commit d94c36a45ab introduced error handling to sslinfo to handle OpenSSL errors gracefully. This ports this errorhandling to the backend TLS implementation. Author: Daniel Gustafsson Branch -- master Details ---

pgsql: Use be_tls_* API for SSL information in sslinfo

2020-11-03 Thread Magnus Hagander
Use be_tls_* API for SSL information in sslinfo sslinfo was passing the Port->ssl member directly to OpenSSL in order to extract information regarding the connection. This breaks the API provided by the backend TLS implementation, as well as duplicates code for no benefit. Rewrite to make use of

pgsql: Add missing comma in list of SSL versions

2020-11-02 Thread Magnus Hagander
Add missing comma in list of SSL versions Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc5b2203bfe80a4ac1b3c2c3ff536247514df304 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add missing comma in list of SSL versions

2020-11-02 Thread Magnus Hagander
Add missing comma in list of SSL versions Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ba4987a4048f1ad3002bc047279cb633429d7d1 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add missing comma in list of SSL versions

2020-11-02 Thread Magnus Hagander
Add missing comma in list of SSL versions Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/06801aef52f7f734a737cc0763a410fd1ec6e574 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

  1   2   3   >