immediately?
0003:
Besides refactor it looks that deleteLSNWaiter() is added
in WaitForLSNReplay. Maybe it's worth mentioning in the commit message.
Maybe refactoring for loop for assigning result variable and breaking a
loop instead of immediate return would look better and lead to natural call
of after the loop before returning.
0004:
Comment:
+ * Waits until recovery replays the target LSN with optional timeout.
Throw
+ * an error on failure.
may need mentioning "Unless no_error provided throws an error on failure"
Otherwise the patch looks good.
Regards,
Pavel Borisov
Supabase
Hi, Alexander!
On Wed, 23 Oct 2024 at 00:12, Alexander Korotkov
wrote:
> Hi, Pavel!
>
> Thank you for your review.
>
> On Tue, Oct 22, 2024 at 4:30 PM Pavel Borisov
> wrote:
> > On Tue, 22 Oct 2024 at 13:26, Alexander Korotkov
> wrote:
> >>
> >&g
Fix a typo of myself:
> Maybe refactoring for loop for assigning result variable and breaking a
> loop instead of immediate return would look better and lead to natural call
> of after the loop before returning.
>
Maybe refactoring for loop for assigning result variable and breaking a
loop instea
