Re: pgsql: make dist uses git archive
On Tue, Mar 26, 2024 at 12:09 PM Andrew Dunstan wrote:
>
>
> On Tue, Mar 26, 2024 at 6:10 AM Andrew Dunstan
> wrote:
>
>>
>>
>> On Tue, Mar 26, 2024 at 5:15 AM Magnus Hagander
>> wrote:
>>
>>>
>>>
>>> On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan
>>> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut
>>>> wrote:
>>>>
>>>>> On 25.03.24 23:20, Andrew Dunstan wrote:
>>>>> > The problem occurs because except in vpath mode the buildfarm
>>>>> operates
>>>>> > on a copy of the code, and for efficiency reasons we don't copy the
>>>>> ,git
>>>>> > directory.
>>>>> >
>>>>> > The simplest fix is probably to change the machine's config to use a
>>>>> > vpath build.
>>>>> >
>>>>> > In the config file change the undef here to a 1:
>>>>> >
>>>>> > 'use_vpath' => undef,
>>>>> >
>>>>> > That worked for me in a quick test.
>>>>>
>>>>> Note that "make dist" doesn't work with vpath in backbranches. :-/
>>>>>
>>>>
>>>>
>>>> Ugh.
>>>>
>>>> OK, plan B :
>>>>
>>>> In the Module's setup code, right after the "die", put
>>>>
>>>> symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");
>>>>
>>>>
>>> If I understand you right, you meant:
>>>
>>> die "can't run this module with vpath builds"
>>> if $conf->{vpath};
>>> + symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");
>>>
>>> my $self = {buildroot => $buildroot, pgbranch=> $branch, bfconf
>>> => $conf, pgsql => $pgsql};
>>> bless ($self, $class);
>>>
>>> If so, I tried that, but it didn't work. That's this run here:
>>> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus=2024-03-26%2009%3A02%3A51=make-dist
>>>
>>>
>>>
>> *sigh*
>>
>> OK, instead of speculating I'll experiment and come up with an answer.
>>
>
>
> OK, this should work. Put these lines after the first print statement of
> the module's build() routine - the setup() routine runs too early:
>
> my $src = "$self->{buildroot}/$self->{pgbranch}/pgsql";
> symlink("$src/.git", "$self->{pgsql}/.git");
>
>
>
That seems to have sorted it.
I did a manual force run and that made it recovered. Let's see if it's also
happy after the first regular run, but it definitely look right.
Thanks!
//Magnus
Re: pgsql: make dist uses git archive
On Tue, Mar 26, 2024 at 9:13 AM Andrew Dunstan wrote:
>
>
> On Tue, Mar 26, 2024 at 3:20 AM Peter Eisentraut
> wrote:
>
>> On 25.03.24 23:20, Andrew Dunstan wrote:
>> > The problem occurs because except in vpath mode the buildfarm operates
>> > on a copy of the code, and for efficiency reasons we don't copy the
>> ,git
>> > directory.
>> >
>> > The simplest fix is probably to change the machine's config to use a
>> > vpath build.
>> >
>> > In the config file change the undef here to a 1:
>> >
>> > 'use_vpath' => undef,
>> >
>> > That worked for me in a quick test.
>>
>> Note that "make dist" doesn't work with vpath in backbranches. :-/
>>
>
>
> Ugh.
>
> OK, plan B :
>
> In the Module's setup code, right after the "die", put
>
> symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");
>
>
If I understand you right, you meant:
die "can't run this module with vpath builds"
if $conf->{vpath};
+ symlink("$buildroot/$branch/pgsql/.git","$pgsql/.git");
my $self = {buildroot => $buildroot, pgbranch=> $branch, bfconf =>
$conf, pgsql => $pgsql};
bless ($self, $class);
If so, I tried that, but it didn't work. That's this run here:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus=2024-03-26%2009%3A02%3A51=make-dist
//Magnus
Re: pgsql: make dist uses git archive
On Mon, Mar 25, 2024 at 8:30 PM Peter Eisentraut wrote: > On 25.03.24 10:04, Magnus Hagander wrote: > > This seems to have broken buildfarm member guaibasaurus, which I believe > > is the only one that runs "make dist" as part of the buildfarm. And as a > > result,t hat breaks the snapshot build uploads. > > > > I don't know exactly how it does it, it appears to not run from within > > the git repository. It might be this needs an update to the buildfarm > > code itself to handle this path? I haven't dug into how that code does > > the make dist part (thus cc:ing in Andrew as well). > > I don't see any code for this in the client-code git repository. So > maybe it is a local custom module? > > Huh, it seems you're right. I didn't realize that :) We received that module from Andrew back in Nov 2011, but I guess it was never committed to the repo (assuming that was the intention) :) But it has served us well so far... PFA the module. It's pretty simple, but I don't know enough (anything, really) about the bf client code to say how to fix it... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> Dist.pm Description: Perl program
Re: pgsql: make dist uses git archive
This seems to have broken buildfarm member guaibasaurus, which I believe is the only one that runs "make dist" as part of the buildfarm. And as a result,t hat breaks the snapshot build uploads. I don't know exactly how it does it, it appears to not run from within the git repository. It might be this needs an update to the buildfarm code itself to handle this path? I haven't dug into how that code does the make dist part (thus cc:ing in Andrew as well). //Magnus On Mon, Mar 25, 2024 at 6:35 AM Peter Eisentraut wrote: > make dist uses git archive > > This changes "make dist" to directly use "git archive", rather than > the custom shell script it currently runs. > > This is to make the creation of the distribution tarball more directly > traceable to the git repository. That is why we removed the "make > distprep" step. > > "make dist" continues to produce a .gz and a .bz2 tarball as before. > > The archives produced this way are deterministic and reproducible, > meaning for a given commit the result file should always be > bit-for-bit identical. The exception is that if you use a git version > older than 2.38.0, gzip records the platform in the archive, so you'd > get a different output on Windows vs. macOS vs. "UNIX" (everything > else). In git 2.38.0, this was changed so that everything is recorded > as "UNIX" now. This is just something to keep in mind. This issue is > specific to the gzip format, it does not affect other compression > formats. > > Meson has its own distribution building command (meson dist), but we > are not using that at this point. The main problem is that, the way > they have implemented it, it is not deterministic in the above sense. > Also, we want a "make" version for the time being. But the target > name "dist" in meson is reserved for that reason, so we call the > custom target "pgdist" (so call something like "meson compile -C build > pgdist"). > > Reviewed-by: Tristan Partin > Discussion: > https://www.postgresql.org/message-id/flat/40e80f77-a294-4f29-a16f-e21bc7bc75fc%40eisentraut.org > > Branch > -- > master > > Details > --- > > https://git.postgresql.org/pg/commitdiff/619bc23a1a2f3750ac3668fe5a7564bc51e01684 > > Modified Files > -- > GNUmakefile.in | 32 + > meson.build| 65 > ++ > 2 files changed, 79 insertions(+), 18 deletions(-) > >
pgsql: Clarify which xml tools are missing in meson error message
Clarify which xml tools are missing in meson error message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/544bcb5a5e778e8ef8d784de611c5f85bc33433c Modified Files -- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bcaf41c608b1b7b462d6ff13c0e4fa80a8847f66 Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ba2d2784f3f83277de6f9c17505229fa3f2f6d5c Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9a94e9ae7ea2f0aced00a53ab618ee4f7c46cc5e Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/18d51c0bb19097191182e57bc755c197ee6a4fc4 Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/af36f1993da1dc35a45337faab22a46e068443c3 Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Fix omission in partitioning limitation documentation
Fix omission in partitioning limitation documentation UNIQUE and PRIMARY KEY constraints can be created on ONLY the partitioned table. We already had an example demonstrating that, but forgot to mention it in the documentation of the limits of partitioning. Author: Laurenz Albe Reviewed-By: shihao zhong, Shubham Khanna, Ashutosh Bapat Backpatch-through: 12 Discussion: https://postgr.es/m/167299368731.659.16130012959616771...@wrigleys.postgresql.org Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5b0287adcab35c1e55d007ba3037c49bd7536ee8 Modified Files -- doc/src/sgml/ddl.sgml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
pgsql: Show the default checkpoint method in the pg_basebackup help mes
Show the default checkpoint method in the pg_basebackup help message Author: Michael Banck Reviewed-By: Aleksander Alekseev, Michael Paquier, Peter Eisentraut Discussion: https://postgr.es/m/6530f954.170a0220.5637c.9...@mx.google.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cd02b35a4609090e6c4e4fc3d8bd055c559dea1b Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: pgsql: Import pg_bsd_indent sources.
On Sun, Apr 23, 2023, 09:39 Tom Lane wrote: > Magnus Hagander writes: > > On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > >> Magnus Hagander writes: > >>> It would perhaps be a good idea to push a README update to the > >>> pg_bsd_indent repo that states this? > > >> Good point. We could either do that or just take that repo down. > >> I'm happy to push such an update if the latter seems bad. > > > I think it's worth doing. If we just zap it we kill history. Not that > > there's a huge amount of it in there, but there is some and just in > > case. > > OK, README update done. Thanks! /Magnus > >
Re: pgsql: Import pg_bsd_indent sources.
On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > > Magnus Hagander writes: > > The plan of this import is that the standalone git version is "dead", > > correct? Given we now have a version in-tree that's newer than the one > > in that repo? > > Right. > > > It would perhaps be a good idea to push a README update to the > > pg_bsd_indent repo that states this? > > Good point. We could either do that or just take that repo down. > I'm happy to push such an update if the latter seems bad. I think it's worth doing. If we just zap it we kill history. Not that there's a huge amount of it in there, but there is some and just in case. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
Re: pgsql: Import pg_bsd_indent sources.
On Sun, Feb 12, 2023 at 6:22 PM Tom Lane wrote: > > Import pg_bsd_indent sources. > > This brings in an exact copy of the pg_bsd_indent repo as of > commit d301442799cea44e5ccb04331afc537764ec77c5 (2020-12-28). The plan of this import is that the standalone git version is "dead", correct? Given we now have a version in-tree that's newer than the one in that repo? It would perhaps be a good idea to push a README update to the pg_bsd_indent repo that states this? //Magnus
Re: pgsql: Remove outdated recommendation for manual VACUUM
On Mon, Jun 27, 2022 at 8:57 PM Bruce Momjian wrote: > On Mon, Jun 27, 2022 at 05:48:41PM +0000, Magnus Hagander wrote: > > Remove outdated recommendation for manual VACUUM > > > > We have had a working and tunable autovacuum > > for at least a decade now, so remove the recommendation to > > manually vacuum tables at least every night. > > Autovacuum is now also triggered by INSERTs, so we can also > > remove the recommendation to run VACUUM (ANALYZE) after lots > > of INSERTs or DELETEs. > > > > Instead, suggest using autovacuum by moving the respective > > paragraph up to where the importance of VACUUM is emphasized. > > > > Author: Laurenz Albe > > Reviewed-By: Magnus Hagander, Peter Geoghegan > > Discussion: > https://postgr.es/m/6f5e3da98fec14640f389d7b84c3b413833697f4.ca...@cybertec.at > > > > Branch > > -- > > master > > > > Details > > --- > > > https://git.postgresql.org/pg/commitdiff/27f953ea9901c08fb3e4064f9a31e07bc30c1e6d > > > > Modified Files > > -- > > doc/src/sgml/ref/vacuum.sgml | 20 +--- > > 1 file changed, 5 insertions(+), 15 deletions(-) > > Uh, shouldn't this doc patch be applied to all major supported Postgres > versions? > > Not sure. If we do we'd at least have to adapt it past the point where autovacuum handles INSERTs I think? //Magnus
pgsql: Remove outdated recommendation for manual VACUUM
Remove outdated recommendation for manual VACUUM We have had a working and tunable autovacuum for at least a decade now, so remove the recommendation to manually vacuum tables at least every night. Autovacuum is now also triggered by INSERTs, so we can also remove the recommendation to run VACUUM (ANALYZE) after lots of INSERTs or DELETEs. Instead, suggest using autovacuum by moving the respective paragraph up to where the importance of VACUUM is emphasized. Author: Laurenz Albe Reviewed-By: Magnus Hagander, Peter Geoghegan Discussion: https://postgr.es/m/6f5e3da98fec14640f389d7b84c3b413833697f4.ca...@cybertec.at Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27f953ea9901c08fb3e4064f9a31e07bc30c1e6d Modified Files -- doc/src/sgml/ref/vacuum.sgml | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-)
pgsql: Recommend scram-sha-256 instead of md5 authentication in docs
Recommend scram-sha-256 instead of md5 authentication in docs PostgreSQL 14 changed the default to be scram-sha-256, so we should stop recommending the user to use md5 or even worse password. Suggested-By: Daniel Westermann Author: Jonathan S. Katz Backpatch-through: 14 Discussion: https://postgr.es/m/gv0p278mb0419a8bac0b0b84afa5263d9d2...@gv0p278mb0419.chep278.prod.outlook.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a694cf4ca496a7db66a61f6ec2a15a9af6493cef Modified Files -- doc/src/sgml/runtime.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Recommend scram-sha-256 instead of md5 authentication in docs
Recommend scram-sha-256 instead of md5 authentication in docs PostgreSQL 14 changed the default to be scram-sha-256, so we should stop recommending the user to use md5 or even worse password. Suggested-By: Daniel Westermann Author: Jonathan S. Katz Backpatch-through: 14 Discussion: https://postgr.es/m/gv0p278mb0419a8bac0b0b84afa5263d9d2...@gv0p278mb0419.chep278.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e1ed1a7aa5477a52faad2699c881966fb73128cb Modified Files -- doc/src/sgml/runtime.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Add JIT counters to pg_stat_statements
Add JIT counters to pg_stat_statements This adds cumulative counters for jit operations to pg_stat_statements, making it easier to diagnose how JIT is used in an installation. These changes merge into the 1.10 changes applied in 76cbf7edb6 without creating a new version. Reviewed-By: Julien Rouhaud Discussion: https://www.postgresql.org/message-id/flat/cabueveyst4ntyqvwzwyaw_0-jg1bjn-y+tykapana0falos...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/57d6aea00fcefec3825a5948ce05cf2b4941097b Modified Files -- .../pg_stat_statements/expected/oldextversions.out | 84 -- .../pg_stat_statements--1.9--1.10.sql | 10 ++- contrib/pg_stat_statements/pg_stat_statements.c| 50 - doc/src/sgml/pgstatstatements.sgml | 72 +++ 4 files changed, 175 insertions(+), 41 deletions(-)
Re: pgsql: Allow extensions to add new backup targets.
On Tue, Mar 15, 2022 at 7:33 PM Robert Haas wrote: > > Allow extensions to add new backup targets. > > Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup > targets, meaning that we could do something with the backup other than > send it to the client, but all of those targets had to be baked in to > the core code. This commit makes it possible for extensions to define > additional backup targets. > > Patch by me, reviewed by Abhijit Menon-Sen. > > Discussion: > http://postgr.es/m/ca+tgmoaqvdt-u3nt+_kkz7bgdayqdb0i-+xommr5jn2rd37...@mail.gmail.com > > Branch > -- > master > > Details > --- > https://git.postgresql.org/pg/commitdiff/e4ba69f3f4a1b997aa493cc02e563a91c0f35b87 > > Modified Files > -- > src/backend/replication/Makefile| 1 + > src/backend/replication/Makefile.orig | 49 ++ > src/backend/replication/basebackup.c| 82 -- > src/backend/replication/basebackup_target.c | 238 > src/include/replication/basebackup_target.h | 66 > 5 files changed, 381 insertions(+), 55 deletions(-) This one has a tiny copy/paste error where the idenfiication comment for basebackup_target.c claims it's basebackup_gzip.c. I've pushed a fix. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
pgsql: Fix typo in file identification
Fix typo in file identification Clearly a simple copy/paste mistake when the file was created. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c540d3715731e0e50259011ee62ea4c0c042b1b1 Modified Files -- src/backend/replication/basebackup_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix pg_hba_file_rules for authentication method cert
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/81596645ca2ba382918fca9e82aa3089db737e14 Modified Files -- src/backend/libpq/hba.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
pgsql: Fix pg_hba_file_rules for authentication method cert
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4afae689ead4ffbfdbaac1cd72794c729446596e Modified Files -- src/backend/libpq/hba.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
pgsql: Fix pg_hba_file_rules for authentication method cert
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2dbb7b9b2279d064f66ce9008869fd0e2b794534 Modified Files -- src/backend/libpq/hba.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
pgsql: Fix pg_hba_file_rules for authentication method cert
Fix pg_hba_file_rules for authentication method cert For authentication method cert, clientcert=verify-full is implied. But the pg_hba_file_rules entry would incorrectly show clientcert=verify-ca. Per bug #17354 Reported-By: Feike Steenbergen Reviewed-By: Jonathan Katz Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa58f5c53142782bd6a376a578d85d5ddd13d751 Modified Files -- src/backend/libpq/hba.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/79a4bf45e83ec92ea24421c0ce0790ecb0aa1542 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c8110854168eb3799ccaaddb720678d0de6b0ee Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ca89bbee9b1c67fc9631abd96ea1c5837ea201b Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f0c5866113fb1d85ada6dc3fe67e4909d94bacc2 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/69872d0bbe64fcd67c4fb4c61e5c7bf6a3443a47 Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Reported-By: Eric Mutta Backpatch-through: 10 Discussion: https://postgr.es/m/164052477973.21665.7888120874624887...@wrigleys.postgresql.org Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/580e99885970179d058d79914c43fb7bcba9242c Modified Files -- doc/src/sgml/high-availability.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ad4aaf7221a70048da642652d1c379f0c5a83f50 Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eff61383b982be8dc71d942340a839bea88a9eab Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0275314e4f017ee3f84e9b77637388610a4417c1 Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc92bb94af9fcb0629a7a05c0859210b37aca919 Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dd111887fbaead778d1077dfbc92b520a5188b51 Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/162cb0834a9a06ac076d613729447ccf5c2ee21b Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Clarify that --system reindexes system catalogs *only*
Clarify that --system reindexes system catalogs *only* Make this more clear both in the help message and docs. Reviewed-By: Michael Paquier Backpatch-through: 9.6 Discussion: https://postgr.es/m/cabuevew6je0wuftlhpkok4+bobudre-fkw3n4ckqgdbmfu4...@mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a0b6520ecfd6bd938851ec386241d2e3c689e117 Modified Files -- doc/src/sgml/ref/reindexdb.sgml | 2 +- src/bin/scripts/reindexdb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
pgsql: Properly schema-prefix reference to pg_catalog.pg_get_statistics
Properly schema-prefix reference to pg_catalog.pg_get_statisticsobjdef_columns Author: Tatsuro Yamada Backpatch-through: 14 Discussion: https://www.postgresql.org/message-id/7ad8cd13-db5b-5cf6-8561-dccad1a93...@nttcom.co.jp Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/febbb2f52c99b16261387daba4931d621dfbef0f Modified Files -- src/bin/psql/describe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Properly schema-prefix reference to pg_catalog.pg_get_statistics
Properly schema-prefix reference to pg_catalog.pg_get_statisticsobjdef_columns Author: Tatsuro Yamada Backpatch-through: 14 Discussion: https://www.postgresql.org/message-id/7ad8cd13-db5b-5cf6-8561-dccad1a93...@nttcom.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/07f8a9e784236a3baf707c59cf80d0f015594ffc Modified Files -- src/bin/psql/describe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Consistently use read-only instead of "read only"
Consistently use read-only instead of "read only" This affects one message and some documentation that used the format "read only", unlike everything else that used read-only. Backpatch-through: 14 Discussion: https://postgr.es/m/cabuevexuxkwn0ym3+wdseqsvk6crrj-hewocgvx3r4-xvx4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d6c916f020e291b45563d4e76a649e9364cb6f2d Modified Files -- doc/src/sgml/catalogs.sgml | 10 +- doc/src/sgml/high-availability.sgml | 8 doc/src/sgml/mvcc.sgml | 2 +- src/backend/postmaster/postmaster.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-)
pgsql: Consistently use read-only instead of "read only"
Consistently use read-only instead of "read only" This affects one message and some documentation that used the format "read only", unlike everything else that used read-only. Backpatch-through: 14 Discussion: https://postgr.es/m/cabuevexuxkwn0ym3+wdseqsvk6crrj-hewocgvx3r4-xvx4...@mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b7fd291042a846b04439f122cb81a41d3cd2e8de Modified Files -- doc/src/sgml/catalogs.sgml | 10 +- doc/src/sgml/high-availability.sgml | 8 doc/src/sgml/mvcc.sgml | 2 +- src/backend/postmaster/postmaster.c | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-)
pgsql: Clarify description of pg_stat_statements columns
Clarify description of pg_stat_statements columns Reported-By: Peter Eisentraut Backpatch-through: 14 Discussion: https://postgr.es/m/8f5e63b8-e8ed-0f80-d8c4-68222624c...@enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4deefc39b933b9808645667117f2d8208092794 Modified Files -- doc/src/sgml/pgstatstatements.sgml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
pgsql: Clarify description of pg_stat_statements columns
Clarify description of pg_stat_statements columns Reported-By: Peter Eisentraut Backpatch-through: 14 Discussion: https://postgr.es/m/8f5e63b8-e8ed-0f80-d8c4-68222624c...@enterprisedb.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3b57d5af7435d0d21bdec392dc1ce7c13871df8b Modified Files -- doc/src/sgml/pgstatstatements.sgml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
pgsql: Remove obsolete reference to winflex download
Remove obsolete reference to winflex download We used to distribute a binary version of flex for windows on our download site, but it hasn't been working for many years. The "old documentation" referenced was also for versions that have been EOL for many years. So, remove it. Discussion: https://postgr.es/m/CABUevEwXLJpVpab62f7AFXNWQ5=u0kverclq4vesikidlyz...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cff8436f19e1c0c278f1ee96d450507fbd43f9ef Modified Files -- doc/src/sgml/install-windows.sgml | 9 - 1 file changed, 9 deletions(-)
pgsql: Fix wording in description of pg_stat_statements.toplevel
Fix wording in description of pg_stat_statements.toplevel Incorrect wording got applied in 7531fcb1fcf. Reported-By: Fujii Masao Discussion: https://postgr.es/m/e5512912-eac9-b163-df2b-e2601ce06...@oss.nttdata.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f9e6d00df029144fd8f4ec70c52b5a1d2444f895 Modified Files -- doc/src/sgml/pgstatstatements.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Mention that toplevel is part of pg_stat_statements key.
Mention that toplevel is part of pg_stat_statements key. While at it, also document that toplevel is always true if pg_stat_statements.track is set to top. Author: Julien Rouhaud Reported-By: Fujii Masao Discussion: https://postgr.es/m/a878d5ea-64a7-485e-5d2f-177618ebc...@oss.nttdata.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7531fcb1fcf5b3ea2f49959a3f095c083e3fc4c4 Modified Files -- doc/src/sgml/pgstatstatements.sgml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)
pgsql: Fix typo in comment
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7311fa8a7096b3a00fc39a10c5a20d4cf0564bfa Modified Files -- src/backend/lib/dshash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo in comment
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf5d1f1e0052100b716f7b7b0934aefb28f72e73 Modified Files -- src/backend/lib/dshash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo in comment
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8b4b5669cde2b17bd6b5d68f584d97078f3296ac Modified Files -- src/backend/lib/dshash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo in comment
Fix typo in comment Author: Julien Rouhaud Backpatch-through: 11 Discussion: https://postgr.es/m/20210420121659.odjueyd4rpilorn5@nol Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e4fbd11a1d5c291fe719b0bc833882e0baad1f8e Modified Files -- src/backend/lib/dshash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/721b3a3a9368c0bd5e9b92892279f0fa441efeee Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c777a1fcc6ba1d61bbb763f6fbd3ac8a5994446d Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/19b28d69128a7ca78705be9f4afca5044541beca Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/91a3a7dc63e8fded60b41cd842eba9a8e31f2b5d Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2bf44fbe271dae3f4bd458e19e32d51996b988b4 Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Westermann Backpatch-through: 9.6 Discussion: https://postgr.es/m/gv0p278mb0483a7aa85bafcc06d90f453d2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1798d8f8b6fbb8ff922f640ff2d5dbd3e47064a2 Modified Files -- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Merge v1.10 of pg_stat_statements into v1.9
Merge v1.10 of pg_stat_statements into v1.9 v1.9 is already new in this version of PostgreSQL, so turn it into just one change. Author: Julien Rohaud Discussion: https://postgr.es/m/20210408120505.7zinijtdexbyghvb@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5844c23dc50508aefeb8183be45f4ee99e9dec17 Modified Files -- contrib/pg_stat_statements/Makefile| 3 +- .../pg_stat_statements--1.8--1.9.sql | 53 .../pg_stat_statements--1.9--1.10.sql | 57 -- contrib/pg_stat_statements/pg_stat_statements.c| 18 +++ .../pg_stat_statements/pg_stat_statements.control | 2 +- 5 files changed, 64 insertions(+), 69 deletions(-)
pgsql: Add functions to wait for backend termination
Add functions to wait for backend termination This adds a function, pg_wait_for_backend_termination(), and a new timeout argument to pg_terminate_backend(), which will wait for the backend to actually terminate (with or without signaling it to do so depending on which function is called). The default behaviour of pg_terminate_backend() remains being timeout=0 which does not waiting. For pg_wait_for_backend_termination() the default wait is 5 seconds. Author: Bharath Rupireddy Reviewed-By: Fujii Masao, David Johnston, Muhammad Usama, Hou Zhijie, Magnus Hagander Discussion: https://postgr.es/m/calj2acubpunmyhyzw-kxcys5nm+h6og_7df_tn4mlmmuqif...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aaf043257205ec523f1ba09a3856464d17cf2281 Modified Files -- doc/src/sgml/func.sgml | 30 +++- doc/src/sgml/monitoring.sgml| 4 ++ src/backend/catalog/system_views.sql| 10 +++ src/backend/storage/ipc/signalfuncs.c | 124 ++-- src/backend/utils/activity/wait_event.c | 3 + src/include/catalog/pg_proc.dat | 9 ++- src/include/utils/wait_event.h | 1 + 7 files changed, 174 insertions(+), 7 deletions(-)
pgsql: Track identical top vs nested queries independently in pg_stat_s
Track identical top vs nested queries independently in pg_stat_statements Changing pg_stat_statements.track between 'all' and 'top' would control if pg_stat_statements tracked just top level statements or also statements inside functions, but when tracking all it would not differentiate between the two. Being table to differentiate this is useful both to track where the actual query is coming from, and to see if there are differences in executions between the two. To do this, add a boolean to the hash key indicating if the statement was top level or not. Experience from the pg_stat_kcache module shows that in at least some "reasonable worloads" only <5% of the queries show up both top level and nested. Based on this, admittedly small, dataset, this patch does not try to de-duplicate those query *texts*, and will just store one copy for the top level and one for the nested. Author: Julien Rohaud Reviewed-By: Magnus Hagander, Masahiro Ikeda Discussion: https://postgr.es/m/20201202040516.GA43757@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6b4d23feef6e334fb85af077f2857f62ab781848 Modified Files -- contrib/pg_stat_statements/Makefile| 3 +- .../expected/pg_stat_statements.out| 40 +++ .../pg_stat_statements--1.9--1.10.sql | 57 ++ contrib/pg_stat_statements/pg_stat_statements.c| 50 --- .../pg_stat_statements/pg_stat_statements.control | 2 +- .../pg_stat_statements/sql/pg_stat_statements.sql | 21 doc/src/sgml/pgstatstatements.sgml | 9 7 files changed, 173 insertions(+), 9 deletions(-)
pgsql: Refactor hba_authname
Refactor hba_authname The previous implementation (from 9afffcb833) had an unnecessary check on the boundaries of the enum which trigtered compile warnings. To clean it up, move the pre-existing static assert to a central location and call that. Reported-By: Erik Rijkers Reviewed-By: Michael Paquier Discussion: https://postgr.es/m/1056399262.13159.1617793249...@webmailclassic.xs4all.nl Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1968426ba3de1fe37848863e35fff30261bf941 Modified Files -- src/backend/libpq/auth.c | 2 +- src/backend/libpq/hba.c | 25 +++-- src/include/libpq/hba.h | 2 +- 3 files changed, 9 insertions(+), 20 deletions(-)
pgsql: Fix function name in error hint
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the SQL function. Reported-By: Sergei Kornilov Backpatch-through: 11 Discussion: https://postgr.es/m/373021616060...@mail.yandex.ru Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0c3079e3ef6956feefc9cc4f62ad1f9acc7c84e9 Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix function name in error hint
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the SQL function. Reported-By: Sergei Kornilov Backpatch-through: 11 Discussion: https://postgr.es/m/373021616060...@mail.yandex.ru Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a5eb70cfca5bc252d7913eb6bb0ff304c4b7d7ae Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix function name in error hint
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the SQL function. Reported-By: Sergei Kornilov Backpatch-through: 11 Discussion: https://postgr.es/m/373021616060...@mail.yandex.ru Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5d825d7bee4d05c4ed086e23306e7a74b8f817a8 Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix function name in error hint
Fix function name in error hint pg_read_file() is the function that's in core, pg_file_read() is in adminpack. But when using pg_file_read() in adminpack it calls the *C* level function pg_read_file() in core, which probably threw the original author off. But the error hint should be about the SQL function. Reported-By: Sergei Kornilov Backpatch-through: 11 Discussion: https://postgr.es/m/373021616060...@mail.yandex.ru Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/da18d829c28197efb04805a43f129f62650e50c8 Modified Files -- src/backend/utils/adt/genfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Clarify that CREATEROLE roles are considered Administrators
Clarify that CREATEROLE roles are considered Administrators Author: Michael Banck Reviewed-By: Robert Treat Discussion: https://postgr.es/m/2160a5071a7bb5339055b04a8cad81a822be9d8d.ca...@credativ.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/30b26dfac7db2fc76dafaa8a6c459871bfcd100e Modified Files -- doc/src/sgml/user-manag.sgml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)
pgsql: Improve docs on updatable views
Improve docs on updatable views Introduce the options before going into details, and add a link to the CREATE TRIGGER documentation. Author: David Johnston Reviewed-By: Anastasia Lubennikova Discussion: https://postgr.es/m/CAKFQuwYLLRhheo0_Y4Jp=vj_ydsz1korutpx1a_buxmhtml...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e045565dae4b2368ba812d60ef0fb7f927fe2646 Modified Files -- doc/src/sgml/rules.sgml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)
pgsql: Fix docs build for website styles
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn import the required one. That puts the process entirely within the scope of the website repository, so next time a version is switched that's the only place changes have to be made, making them less likely to be missed. Per (off-list) discussion with Peter Geoghegan and Jonathan Katz. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d22d0fa937616a3112f69ebd6a6ed4f039162441 Modified Files -- doc/src/sgml/stylesheet.xsl | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
pgsql: Fix docs build for website styles
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn import the required one. That puts the process entirely within the scope of the website repository, so next time a version is switched that's the only place changes have to be made, making them less likely to be missed. Per (off-list) discussion with Peter Geoghegan and Jonathan Katz. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/186f6168b73de6472e8aeb6e96b2ec6c73fd7b89 Modified Files -- doc/src/sgml/stylesheet.xsl | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
pgsql: Fix typo
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/daf2e708edfbc0741f8a229a0c30fdd0168b525e Modified Files -- doc/src/sgml/ref/create_table.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6a31b48ec88ae506c6f115948c86f61abb89a89a Modified Files -- doc/src/sgml/ref/create_table.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5d319ce86f13d1b0e7fb911408fe012723259723 Modified Files -- doc/src/sgml/ref/create_table.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Fix typo
Fix typo Author: Daniel Gustafsson Discussion: https://postgr.es/m/0cf087fc-bead-4010-8bb9-3cdd74dc9...@yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a29f30780f34d7706fcd398dea1d6882d184d17a Modified Files -- doc/src/sgml/ref/create_table.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Remove extra Success message at the end of initdb
Remove extra Success message at the end of initdb This was accidentally included in e09155bd62 and is redundant with the lines right above it. Reported-By: Peter Eisentraut Discussion: https://postgr.es/m/455845d1-441d-cc40-d2a7-b47f4e422...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e7f42914854926c2afbb89b9cd0e381fd90766be Modified Files -- src/bin/initdb/initdb.c | 2 -- 1 file changed, 2 deletions(-)
pgsql: Remove make_diff set of tools
Remove make_diff set of tools These are mostly obsoleted by the switch to git, and it's easier to remove them than to update the incorrect documentation. Discussion: https://postgr.es/m/cabuevewmasmn4wrj6ragbx43sj10ctfmhcma_-7ka3pdymw...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8a337b0ed21c654521da137159b8b9327a5cb971 Modified Files -- src/tools/make_diff/README | 39 --- src/tools/make_diff/cporig | 11 --- src/tools/make_diff/difforig | 14 -- src/tools/make_diff/rmorig | 9 - 4 files changed, 73 deletions(-)
pgsql: Remove reference to ftp servers from documentation
Remove reference to ftp servers from documentation It's been a long time since we used ftp, but there was a single reference left in the docs. Author: Daniel Gustafsson Discussion: https://postgr.es/m/6880d602-7286-46ec-8a03-14e3248fe...@yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0a9ae44288d122c12aa0862b032ae892942da452 Modified Files -- doc/src/sgml/install-windows.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Re: pgsql: Add pg_stat_database counters for sessions and session time
On Mon, Jan 18, 2021 at 5:09 PM Laurenz Albe wrote: > > On Sun, 2021-01-17 at 13:07 +, Magnus Hagander wrote: > > Add pg_stat_database counters for sessions and session time > > > > This add counters for number of sessions, the different kind of session > > termination types, and timers for how much time is spent in active vs > > idle in a database to pg_stat_database. > > Should't this update PGSTAT_FILE_FORMAT_ID in include/pgstat.h > since "struct PgStat_StatDBEntry" was changed? Per my reply in the other thread -- yes it should. Fixed. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
pgsql: Bump PGSTAT_FILE_FORMAT_ID
Bump PGSTAT_FILE_FORMAT_ID This was missed in 960869da08 Reported-By: Laurenz Albe Discussion: https://postgr.es/m/4f0aacc5fe1b4bfafa32b36ecd97469fae526a75.ca...@cybertec.at Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2f87b46690ab8cd3ee7c77226fcf3f5bb713e5b Modified Files -- src/include/pgstat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Add documentation chapter about checksums
Add documentation chapter about checksums Data checksums did not have a longer discussion in the docs, this adds a short section with an overview. Extracted from the larger patch for on-line enabling of checksums, which has many more authors and reviewers. Author: Daniel Gustafsson Reviewed-By: Magnus Hagander, Michael Banck (and others through the big patch) Discussion: https://postgr.es/m/5ff49fa4.1c69fb81.658f3.0...@mx.google.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cf621d9d84db1e6edaff8ffa26bad93fdce5f830 Modified Files -- doc/src/sgml/amcheck.sgml| 4 ++-- doc/src/sgml/ref/initdb.sgml | 1 + doc/src/sgml/wal.sgml| 49 +++- 3 files changed, 51 insertions(+), 3 deletions(-)
pgsql: Add --no-instructions parameter to initdb
Add --no-instructions parameter to initdb Specifying this parameter removes the informational messages about how to start the server. This is intended for use by wrappers in different packaging systems, where those instructions would most likely be wrong anyway, but the other output from initdb would still be useful (and thus just redirecting everything to /dev/null would be bad). Author: Magnus Hagander Reviewed-By: Peter Eisentraut Discusion: https://postgr.es/m/CABUevEzo4t5bmTXF0_B9WzmuWpVbMpkNZZiGvzV8NZa-=fp...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e09155bd62f0ac5817cb3d736eb35adf4200549e Modified Files -- doc/src/sgml/ref/initdb.sgml | 13 ++ src/bin/initdb/initdb.c | 56 +++- 2 files changed, 47 insertions(+), 22 deletions(-)
pgsql: Add pg_stat_database counters for sessions and session time
Add pg_stat_database counters for sessions and session time This add counters for number of sessions, the different kind of session termination types, and timers for how much time is spent in active vs idle in a database to pg_stat_database. Internally this also renames the parameter "force" to disconnect. This was the only use-case for the parameter before, so repurposing it to this mroe narrow usecase makes things cleaner than inventing something new. Author: Laurenz Albe Reviewed-By: Magnus Hagander, Soumyadeep Chakraborty, Masahiro Ikeda Discussion: https://postgr.es/m/b07e1f9953701b90c66ed368656f2aef40cac4fb.ca...@cybertec.at Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/960869da0803427d14335bba24393f414b476e2c Modified Files -- doc/src/sgml/monitoring.sgml | 77 src/backend/catalog/system_views.sql | 7 ++ src/backend/postmaster/pgstat.c | 134 +-- src/backend/tcop/postgres.c | 11 ++- src/backend/utils/adt/pgstatfuncs.c | 94 src/backend/utils/error/elog.c | 8 +++ src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.dat | 32 + src/include/pgstat.h | 39 ++ src/test/regress/expected/rules.out | 7 ++ 10 files changed, 405 insertions(+), 6 deletions(-)
pgsql: Remove incorrect markup
Remove incorrect markup Seems 737d69ffc3c made a copy/paste or automation error resulting in two extra right-parenthesis. Reported-By: Michael Vastola Backpatch-through: 13 Discussion: https://postgr.es/m/161051035421.12224.1741822783166533...@wrigleys.postgresql.org Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bff8d0fe3bff0ce52c0343d81afa8f1745d0209e Modified Files -- doc/src/sgml/func.sgml | 2 -- 1 file changed, 2 deletions(-)
pgsql: Remove incorrect markup
Remove incorrect markup Seems 737d69ffc3c made a copy/paste or automation error resulting in two extra right-parenthesis. Reported-By: Michael Vastola Backpatch-through: 13 Discussion: https://postgr.es/m/161051035421.12224.1741822783166533...@wrigleys.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e6eeb8d799c703eb829612ddcb4fd5ba82d3e880 Modified Files -- doc/src/sgml/func.sgml | 2 -- 1 file changed, 2 deletions(-)
pgsql: Remove ability to independently select random number generator
Remove ability to independently select random number generator Remove the ability to select random number generator independently from SSL library. Instead, use the random number generator from the SSL library (today only OpenSSL supported) if one is configured. If no SSL library is configured, use the platform default (which means use CryptoAPI on Win32 and /dev/urandom on Linux). This also restructures pg_strong_random.c to have three clearly separate sections, one for each implementation, with two functions in each, instead of a scattered set of ifdefs throughout the whole file. Author: Daniel Gustafsson, Magnus Hagander, Michael Paquier Discussion: https://postgr.es/m/632623.1605460...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/16f96c74d48e65da23d28665103e2c4c9d3414cc Modified Files -- configure | 61 +- configure.ac| 41 +++-- src/include/pg_config.h.in | 9 -- src/port/pg_strong_random.c | 201 ++-- src/tools/msvc/Solution.pm | 3 - 5 files changed, 114 insertions(+), 201 deletions(-)
pgsql: Remove line missed in previous commit
Remove line missed in previous commit Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4e3ffd5981536f93787ae6d81bc179da0acc423e Modified Files -- src/tools/msvc/vcregress.pl | 1 - 1 file changed, 1 deletion(-)
pgsql: Remove vacuumdb --analyze-in-stages from pg_upgrade tests
Remove vacuumdb --analyze-in-stages from pg_upgrade tests This step was only there to test the script when we generated those, but commit 8f113698b6 removed those scripts, so it's not needed anymore. Reported-By: Peter Eisentraut Discussion: https://postgr.es/m/ea403f46-2b33-a7de-618e-9cab35a69...@enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1e12a495b4749c7dc8e38e347554f2b24297f4ba Modified Files -- src/bin/pg_upgrade/test.sh | 2 -- src/tools/msvc/vcregress.pl | 2 -- 2 files changed, 4 deletions(-)
pgsql: Remove -o option to postmaster
Remove -o option to postmaster This option was declared obsolete many years ago. Reviewed-By: Tom Lane Discussion: https://postgr.es/m/CABUevEyOE=9CQwZm2j=vwp5+6olcsoxn9pbjk8gyrdktzmf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d2e4bf688e16f95d180b68b7cbb7881b12434dba Modified Files -- doc/src/sgml/ref/postgres-ref.sgml | 26 --- src/backend/main/main.c | 1 - src/backend/postmaster/postmaster.c | 66 +++-- src/backend/tcop/postgres.c | 6 +--- 4 files changed, 6 insertions(+), 93 deletions(-)
pgsql: Remove analyze_new_cluster script from pg_upgrade
Remove analyze_new_cluster script from pg_upgrade Since this script just runs vacuumdb anyway, remove the script and replace the instructions to run it with instructions to run vacuumdb directly. Reviewed-By: Michael Paquier Discussion: https://postgr.es/m/CABUevEwg5LDFzthhxzSj7sZGMiVsZe0VVNbzzwTQOHJ=rn7...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8f113698b63b15a4e0a4b15d3ee37238c1d1821d Modified Files -- src/bin/pg_upgrade/.gitignore | 2 - src/bin/pg_upgrade/Makefile | 2 +- src/bin/pg_upgrade/check.c | 101 ++-- src/bin/pg_upgrade/pg_upgrade.c | 6 +-- src/bin/pg_upgrade/pg_upgrade.h | 4 +- src/bin/pg_upgrade/test.sh | 8 +--- src/tools/msvc/vcregress.pl | 3 +- 7 files changed, 20 insertions(+), 106 deletions(-)
pgsql: Remove incorrect %s in string
Remove incorrect %s in string Appears to have been a copy/paste error in the original commit that moved the messages to fe_utils/. Author: Tang, Haiying Backpatch-through: 13 Discussion: https://postgr.es/m/3321cbcea76d4d2c8320a05c19b9304a@G08CNEXMBPEKD05.g08.fujitsu.local Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e84dd212040529de1811c7c97c996cc4e392015 Modified Files -- src/fe_utils/cancel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Remove incorrect %s in string
Remove incorrect %s in string Appears to have been a copy/paste error in the original commit that moved the messages to fe_utils/. Author: Tang, Haiying Backpatch-through: 13 Discussion: https://postgr.es/m/3321cbcea76d4d2c8320a05c19b9304a@G08CNEXMBPEKD05.g08.fujitsu.local Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7d94c017b94577548a0656b2aef7ce8be18fbc1b Modified Files -- src/fe_utils/cancel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Add pg_strong_random_init function to initialize random number g
Add pg_strong_random_init function to initialize random number generator Currently only OpenSSL requires this initialization, but in the future other SSL implementations are likely to need it as well. Abstracting this functionality out into a separate function makes this cleaner and more clear, and also removes the dependency on OpenSSL headers from fork_process.c. OpenSSL is special in that we need to initialize this random number generator even if we're not going to use it directly, until we drop support for everything prior to OpenSSL 1.1.1. (And of course also if we actually use it). All other implementations are left empty at this time, but more are expected to be added in the future. Author: Daniel Gustafsson , Michael Paquier Reviewed-By: Magnus Hagander Discussion: https://postgr.es/m/f6291c3c-747c-4c93-bce0-28bb420b1...@yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5ee180a3947060b98284a935f26f92c71d698f7c Modified Files -- src/backend/postmaster/fork_process.c | 13 ++ src/include/port.h| 1 + src/port/pg_strong_random.c | 46 ++- 3 files changed, 48 insertions(+), 12 deletions(-)
Re: pgsql: Add pg_depend.refobjversion.
On Thu, Nov 5, 2020 at 8:17 PM Tom Lane wrote: > > Magnus Hagander writes: > > On Thu, Nov 5, 2020 at 3:50 PM Tom Lane wrote: > >> AFAIK the agreed-on process is to do that once per release cycle. > >> Is there some reason why it needs to be done now? > > > Did we ever actually document this process somewhere? I went looking > > for it some time ago and failed to find it (and eventually found the > > old email thread(s) around it, but that's not really documentation), > > but that could definitely be my searching > > Yeah, it's documented here: > > https://www.postgresql.org/docs/devel/system-catalog-initial-data.html#SYSTEM-CATALOG-OID-ASSIGNMENT > > and there is an entry in src/tools/RELEASE_CHANGES to remind us > to actually do the cleanup work. Ha! Thanks. I did find the RELEASE_CHANGES ones, but for some reason managed to miss the other one. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
Re: pgsql: Add pg_depend.refobjversion.
On Thu, Nov 5, 2020 at 3:50 PM Tom Lane wrote: > > Peter Eisentraut writes: > > This commit assigns OIDs from the reserved range: > > +DECLARE_TOAST(pg_depend, , 8889); > > > Do you want to try the renumber_oids.pl script to fix this? > > AFAIK the agreed-on process is to do that once per release cycle. > Is there some reason why it needs to be done now? Did we ever actually document this process somewhere? I went looking for it some time ago and failed to find it (and eventually found the old email thread(s) around it, but that's not really documentation), but that could definitely be my searching -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
pgsql: Use the non-deprecated TG_TABLE_MAME in test trigger
Use the non-deprecated TG_TABLE_MAME in test trigger Commit 3a9ae3d2068 (back in 2006) deprecated TG_RELNAME in favor of TG_TABLE_NAME, but the existing usage in test cases has remained till today. Change to use TG_TABLE_NAME instead (TG_RELNAME is still covered by a test case). Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/44a184cb686866b10d63695db344195c239f9374 Modified Files -- src/test/regress/expected/triggers.out | 4 ++-- src/test/regress/sql/triggers.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
pgsql: Improve error handling in backend OpenSSL implementation
Improve error handling in backend OpenSSL implementation Commit d94c36a45ab introduced error handling to sslinfo to handle OpenSSL errors gracefully. This ports this errorhandling to the backend TLS implementation. Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/13cfa02f77936895bff6ffabf1fde5d47fd1df07 Modified Files -- src/backend/libpq/be-secure-openssl.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-)
pgsql: Use be_tls_* API for SSL information in sslinfo
Use be_tls_* API for SSL information in sslinfo sslinfo was passing the Port->ssl member directly to OpenSSL in order to extract information regarding the connection. This breaks the API provided by the backend TLS implementation, as well as duplicates code for no benefit. Rewrite to make use of the backend API as much as possible. Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5d1833f414973595411779b86e085fb05907a805 Modified Files -- contrib/sslinfo/sslinfo.c | 139 -- doc/src/sgml/sslinfo.sgml | 4 +- 2 files changed, 49 insertions(+), 94 deletions(-)
pgsql: Add missing comma in list of SSL versions
Add missing comma in list of SSL versions Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc5b2203bfe80a4ac1b3c2c3ff536247514df304 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Add missing comma in list of SSL versions
Add missing comma in list of SSL versions Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ba4987a4048f1ad3002bc047279cb633429d7d1 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
pgsql: Add missing comma in list of SSL versions
Add missing comma in list of SSL versions Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/06801aef52f7f734a737cc0763a410fd1ec6e574 Modified Files -- doc/src/sgml/sslinfo.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
