Re: pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Peter Geoghegan
On Wed, Apr 11, 2018 at 9:17 AM, Teodor Sigaev wrote: >> Several of the failing animals aren't using optimization, so it can't be >> just that. I think it might make sense considering reverting and trying > > Yep, but on my notebook - only with -02 I suggest using Valgrind to

Re: pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Teodor Sigaev
Andres Freund wrote: On 2018-04-11 19:04:53 +0300, Teodor Sigaev wrote: Seems, something is wrong here, investigating... pg_upgrade test fails only with -O2 on my box. Assert, debug could be any. Several of the failing animals aren't using optimization, so it can't be just that. I think

Re: pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Andres Freund
On 2018-04-11 19:04:53 +0300, Teodor Sigaev wrote: > > > Seems, something is wrong here, investigating... > > pg_upgrade test fails only with -O2 on my box. Assert, debug could be any. Several of the failing animals aren't using optimization, so it can't be just that. I think it might make

Re: pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Teodor Sigaev
Seems, something is wrong here, investigating... pg_upgrade test fails only with -O2 on my box. Assert, debug could be any. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/

Re: pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Teodor Sigaev
Seems, something is wrong here, investigating... Teodor Sigaev wrote: Fix interference between cavering indexes and partitioned tables The bug is caused due to the original IndexStmt that DefineIndex receives being overwritten when processing the INCLUDE columns. Use separate list of index

pgsql: Fix interference between cavering indexes and partitioned tables

2018-04-11 Thread Teodor Sigaev
Fix interference between cavering indexes and partitioned tables The bug is caused due to the original IndexStmt that DefineIndex receives being overwritten when processing the INCLUDE columns. Use separate list of index params to propagate to child tables. Add tests covering this case. Amit