pgsql: Detect unused steps in isolation specs and do some cleanup
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the specs which include steps not used in any permutations to simplify them. This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to make all the branches consistent for an upcoming patch that will improve the output generated by isolationtester. Author: Michael Paquier Reviewed-by: Asim Praveen, Melanie Plageman Discussion: https://postgr.es/m/20190819080820.gg18...@paquier.xyz Discussion: https://postgr.es/m/794820.1623872...@sss.pgh.pa.us Backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/feac82fa8550b4ae483993674e1676911ebe0546 Modified Files -- .../test_decoding/specs/concurrent_ddl_dml.spec| 9 - contrib/test_decoding/specs/snapshot_transfer.spec | 1 - .../isolation/expected/eval-plan-qual-trigger.out | 2 +- src/test/isolation/isolationtester.c | 19 ++- src/test/isolation/isolationtester.h | 1 + src/test/isolation/specparse.y | 1 + .../isolation/specs/eval-plan-qual-trigger.spec| 38 +++--- src/test/isolation/specs/freeze-the-dead.spec | 3 -- .../specs/insert-conflict-do-nothing.spec | 1 - .../specs/insert-conflict-do-update-2.spec | 1 - .../isolation/specs/insert-conflict-do-update.spec | 1 - src/test/isolation/specs/sequence-ddl.spec | 1 - .../specs/tuplelock-upgrade-no-deadlock.spec | 3 -- 13 files changed, 40 insertions(+), 41 deletions(-)
pgsql: Detect unused steps in isolation specs and do some cleanup
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the specs which include steps not used in any permutations to simplify them. This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to make all the branches consistent for an upcoming patch that will improve the output generated by isolationtester. Author: Michael Paquier Reviewed-by: Asim Praveen, Melanie Plageman Discussion: https://postgr.es/m/20190819080820.gg18...@paquier.xyz Discussion: https://postgr.es/m/794820.1623872...@sss.pgh.pa.us Backpatch-through: 9.6 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/96f3661e4540db1f45709c5f098aeecc6e9df271 Modified Files -- .../test_decoding/specs/concurrent_ddl_dml.spec| 9 - contrib/test_decoding/specs/snapshot_transfer.spec | 1 - .../isolation/expected/eval-plan-qual-trigger.out | 2 +- src/test/isolation/isolationtester.c | 19 ++- src/test/isolation/isolationtester.h | 1 + src/test/isolation/specparse.y | 1 + .../isolation/specs/eval-plan-qual-trigger.spec| 38 +++--- src/test/isolation/specs/freeze-the-dead.spec | 3 -- .../specs/insert-conflict-do-nothing.spec | 1 - .../specs/insert-conflict-do-update-2.spec | 1 - .../isolation/specs/insert-conflict-do-update.spec | 1 - src/test/isolation/specs/sequence-ddl.spec | 1 - .../specs/tuplelock-upgrade-no-deadlock.spec | 3 -- 13 files changed, 40 insertions(+), 41 deletions(-)
pgsql: Detect unused steps in isolation specs and do some cleanup
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the specs which include steps not used in any permutations to simplify them. This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to make all the branches consistent for an upcoming patch that will improve the output generated by isolationtester. Author: Michael Paquier Reviewed-by: Asim Praveen, Melanie Plageman Discussion: https://postgr.es/m/20190819080820.gg18...@paquier.xyz Discussion: https://postgr.es/m/794820.1623872...@sss.pgh.pa.us Backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8f32299424d90b0dab792bf96a5b0e3a62cc63da Modified Files -- .../test_decoding/specs/concurrent_ddl_dml.spec| 9 - contrib/test_decoding/specs/snapshot_transfer.spec | 1 - .../isolation/expected/eval-plan-qual-trigger.out | 2 +- src/test/isolation/isolationtester.c | 19 ++- src/test/isolation/isolationtester.h | 1 + src/test/isolation/specparse.y | 1 + .../isolation/specs/eval-plan-qual-trigger.spec| 38 +++--- src/test/isolation/specs/freeze-the-dead.spec | 3 -- .../specs/insert-conflict-do-nothing.spec | 1 - .../specs/insert-conflict-do-update-2.spec | 1 - .../isolation/specs/insert-conflict-do-update.spec | 1 - .../isolation/specs/partition-key-update-1.spec| 1 - src/test/isolation/specs/sequence-ddl.spec | 1 - .../specs/tuplelock-upgrade-no-deadlock.spec | 3 -- 14 files changed, 40 insertions(+), 42 deletions(-)
pgsql: Detect unused steps in isolation specs and do some cleanup
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the specs which include steps not used in any permutations to simplify them. This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to make all the branches consistent for an upcoming patch that will improve the output generated by isolationtester. Author: Michael Paquier Reviewed-by: Asim Praveen, Melanie Plageman Discussion: https://postgr.es/m/20190819080820.gg18...@paquier.xyz Discussion: https://postgr.es/m/794820.1623872...@sss.pgh.pa.us Backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/484c81bf7765862a02a2866466b140a097e36c8c Modified Files -- .../test_decoding/specs/concurrent_ddl_dml.spec| 9 - contrib/test_decoding/specs/snapshot_transfer.spec | 1 - .../isolation/expected/eval-plan-qual-trigger.out | 2 +- src/test/isolation/isolationtester.c | 19 ++- src/test/isolation/isolationtester.h | 1 + src/test/isolation/specparse.y | 1 + .../isolation/specs/eval-plan-qual-trigger.spec| 38 +++--- src/test/isolation/specs/freeze-the-dead.spec | 3 -- .../specs/insert-conflict-do-nothing.spec | 1 - .../specs/insert-conflict-do-update-2.spec | 1 - .../isolation/specs/insert-conflict-do-update.spec | 1 - .../specs/tuplelock-upgrade-no-deadlock.spec | 3 -- 12 files changed, 40 insertions(+), 40 deletions(-)
Re: pgsql: Detect unused steps in isolation specs and do some cleanup
On Fri, Aug 23, 2019 at 11:07:49PM -0400, Stephen Frost wrote: > Buildfarm didn't particularly like this. Thanks, I have noticed that. The problem should be fixed now thanks to 06fdc4e. -- Michael signature.asc Description: PGP signature
Re: pgsql: Detect unused steps in isolation specs and do some cleanup
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > Detect unused steps in isolation specs and do some cleanup > > This is useful for developers to find out if an isolation spec is > over-engineered or if it needs more work by warning at the end of a > test run if a step is not used, generating a failure with extra diffs. > > While on it, clean up all the specs which include steps not used in any > permutations to simplify them. Buildfarm didn't particularly like this. Thanks, Stephen signature.asc Description: PGP signature
pgsql: Detect unused steps in isolation specs and do some cleanup
Detect unused steps in isolation specs and do some cleanup This is useful for developers to find out if an isolation spec is over-engineered or if it needs more work by warning at the end of a test run if a step is not used, generating a failure with extra diffs. While on it, clean up all the specs which include steps not used in any permutations to simplify them. Author: Michael Paquier Reviewed-by: Asim Praveen, Melanie Plageman Discussion: https://postgr.es/m/20190819080820.gg18...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/989d23b04beac0c26f44c379b04ac781eaa4265e Modified Files -- src/test/isolation/isolationtester.c | 19 ++- src/test/isolation/isolationtester.h | 1 + src/test/isolation/specparse.y| 1 + src/test/isolation/specs/freeze-the-dead.spec | 3 --- .../isolation/specs/insert-conflict-do-nothing.spec | 1 - .../isolation/specs/insert-conflict-do-update-2.spec | 1 - .../isolation/specs/insert-conflict-do-update.spec| 1 - src/test/isolation/specs/sequence-ddl.spec| 1 - .../specs/tuplelock-upgrade-no-deadlock.spec | 3 --- 9 files changed, 20 insertions(+), 11 deletions(-)
