Re: pgsql: Support parallel btree index builds.

On Tue, Feb 6, 2018 at 8:05 AM, Tom Lane wrote: > I like the option of doing VALGRIND_MAKE_MEM_DEFINED on the tail > portion of the buffer before writing it. That seems pretty tightly > tied to the behavior we're decreeing valid, whereas the suppression > is not. I think

Re: pgsql: Support parallel btree index builds.

Robert Haas writes: > On Tue, Feb 6, 2018 at 10:46 AM, Tom Lane wrote: >> ... I, at least, don't have that understanding from looking >> at the thread. For one thing, Peter has not explained why this issue >> appears now with parallel index build when

Re: pgsql: Support parallel btree index builds.

On Tue, Feb 6, 2018 at 10:46 AM, Tom Lane wrote: > Robert Haas writes: >> On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: >>> I'll be happier about it when the valgrind buildfarm animals are >>> happy. > >> Me too, but it's not

Re: pgsql: Support parallel btree index builds.

Robert Haas writes: > On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: >> I'll be happier about it when the valgrind buildfarm animals are >> happy. > Me too, but it's not clear what the right fix is. One thing that > would help is if you put in an

Re: pgsql: Support parallel btree index builds.

On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: > I'll be happier about it when the valgrind buildfarm animals are > happy. Me too, but it's not clear what the right fix is. One thing that would help is if you put in an appearance on the thread where this is being discussed

Re: pgsql: Support parallel btree index builds.

On Sun, Feb 4, 2018 at 10:11 AM, Tom Lane wrote: > I'll be happier about it when the valgrind buildfarm animals are > happy. I don't know if you noticed, but I did post a patch for that on Friday. -- Peter Geoghegan

Re: pgsql: Support parallel btree index builds.

Andres Freund writes: > On 2018-02-02 18:37:11 +, Robert Haas wrote: >> Support parallel btree index builds. > Wheee! Congrats Peter, Rushash, and everyone else involved! I'll be happier about it when the valgrind buildfarm animals are happy.

Re: pgsql: Support parallel btree index builds.

On Sun, Feb 4, 2018 at 9:42 AM, Andres Freund wrote: > Wheee! Congrats Peter, Rushash, and everyone else involved! Thanks! -- Peter Geoghegan

Re: pgsql: Support parallel btree index builds.

Hi, On 2018-02-02 18:37:11 +, Robert Haas wrote: > Support parallel btree index builds. Wheee! Congrats Peter, Rushash, and everyone else involved! - Andres

pgsql: Support parallel btree index builds.

Support parallel btree index builds. To make this work, tuplesort.c and logtape.c must also support parallelism, so this patch adds that infrastructure and then applies it to the particular case of parallel btree index builds. Testing to date shows that this can often be 2-3x faster than a