Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I never said I wasn't going to enable it for Win32, but I am only going > > to do it when the unix build is better tested, and right now it doesn't > > even work on my unix machine. > > Well, if you'd said "I'm holding off enabling it

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I never said I wasn't going to enable it for Win32, but I am only going > > to do it when the unix build is better tested, and right now it doesn't > > even work on my unix machine. > > Well, if you'd said "I'm holding off enabling it

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I never said I wasn't going to enable it for Win32, but I am only going > to do it when the unix build is better tested, and right now it doesn't > even work on my unix machine. Well, if you'd said "I'm holding off enabling it globally just until I can f

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I thought about that but I figured the less we change the tz library, > > the easier it will be to replace later. > > I have come to the conclusion that trying to minimize changes to the tz > library is a bad tradeoff. It's not going

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I thought about that but I figured the less we change the tz library, > the easier it will be to replace later. I have come to the conclusion that trying to minimize changes to the tz library is a bad tradeoff. It's not going to be a minimally sized dif

[COMMITTERS] pgsql-server/src/timezone pgtz.c

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 22:38:53 Modified files: src/timezone : pgtz.c Log message: Remove debug output line. ---(end of broadcast)--- TIP 7: don't f

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: > > > #ifndef HAVE_SYMLINK > > #define HAVE_SYMLINK 0 > > #endif > > Surely this is exactly the wrong thing to do. It will break code that > test

[COMMITTERS] pgsql-server/src/timezone pgtz.c pgtz.h

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 22:34:47 Modified files: src/timezone : pgtz.c pgtz.h Log message: Rename function to be less win32 specific. ---(end of broadcast)--

Re: [COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: > #ifndef HAVE_SYMLINK > #define HAVE_SYMLINK 0 > #endif Surely this is exactly the wrong thing to do. It will break code that tests for #ifdef HAVE_SYMLIN

[COMMITTERS] pgsql-server/doc FAQ_japanese src/FAQ/FAQ_japa ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 22:27:03 Modified files: doc: FAQ_japanese doc/src/FAQ: FAQ_japanese.html Log message: Update Japanese FAQ. Jun Kuwamura

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > It goes with the Win32 approach of doing as little as possible to the > > Unix port. > > That's *not* the approach I want to take. What I want is a Windows port > that adds as little #ifdef cruft to the system as possible --- that is

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > It goes with the Win32 approach of doing as little as possible to the > Unix port. That's *not* the approach I want to take. What I want is a Windows port that adds as little #ifdef cruft to the system as possible --- that is, no duplicate code paths th

[COMMITTERS] pgsql-server/src/include c.h

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 17:47:33 Modified files: src/include: c.h Log message: Suppress use of timezone library by ecpg. ---(end of broadcast)--- T

[COMMITTERS] pgsql-server/src/timezone Makefile pgtz.c

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 17:23:28 Modified files: src/timezone : Makefile pgtz.c Log message: Fix zic compiler to use pg version. Move timezone database to share/timezone. -

[COMMITTERS] pgsql-server/src bin/pg_controldata/Makefile b ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 17:01:39 Modified files: src/bin/pg_controldata: Makefile src/bin/pg_dump: Makefile src/bin/pg_resetxlog: Makefile src/timezone : Makefile pgtz.h private.h

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Neil Conway
On 30-Apr-04, at 12:14 PM, Bruce Momjian wrote: It goes with the Win32 approach of doing as little as possible to the Unix port. If the Unix folks want it, we can enable it, but the Win32 folks aren't going to force it on Unix until Unix wants it and has tested it. I completely agree with Tom and

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Marc G. Fournier
On Fri, 30 Apr 2004, Bruce Momjian wrote: > Tom Lane wrote: > > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > > 3) I was under the (apparantly incorrect?) impression that we wanted > > > this one up on win32 *now*, and then wanted to add it on other platforms > > > later. > > > > Well, that's

[COMMITTERS] pgsql-server/src include/port.h timezone/Makef ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 14:52:07 Modified files: src/include: port.h src/timezone : Makefile private.h Log message: More timezone build adjustments. ---(end of

[COMMITTERS] pgsql-server/src/timezone pgtz.h

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 13:58:48 Modified files: src/timezone : pgtz.h Log message: Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h: #ifndef HAVE_SYMLINK #def

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > 3) I was under the (apparantly incorrect?) impression that we wanted > this one up on win32 *now*, and then wanted to add it on other platforms > later. Well, that's an okay position if your time horizon is measured in days. But I would like to see u

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > 3) I was under the (apparantly incorrect?) impression that we wanted > > this one up on win32 *now*, and then wanted to add it on other platforms > > later. > > Well, that's an okay position if your time horizon is measured in day

[COMMITTERS] pgsql-server/ /configure /configure.in rc/back ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 13:08:01 Modified files: . : configure configure.in src/backend: Makefile src/timezone : Makefile Log message: More cleanups for USE_PGTZ.

[COMMITTERS] pgsql-server/ /configure /configure.in rc/Make ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 12:01:25 Modified files: . : configure configure.in src: Makefile.global.in src/include: pg_config.h.in Log message: Rename to USE

[COMMITTERS] pgsql-server/src/timezone Makefile pgtz.c priv ...

2004-04-30 Thread Bruce Momjian
CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/04/30 11:24:14 Modified files: src/timezone : Makefile pgtz.c private.h Log message: Allow timezone to compile under Unix by blocking 'timezone' conflict with system headers

Re: [COMMITTERS] pgsql-server/ /configure /configure.in rc/incl ...

2004-04-30 Thread Magnus Hagander
> > It doesn't even compile on my platform. > > Then we have some work to do ... but that work won't get done > if the code is disabled by default. > > Or did we pick an upstream library so bad that it should be > *expected* to fail to compile everywhere? If that's true > then I can't trust i