I have a whole separate CVS checkout for every path I'm working on -
makes life a lot easier :)
Dammit - I meant 'patch'.
Chris
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's
Thanks for spotting this sloppy work. Basically, I cropped my diff because
there was lots of unrelated code in the work space. But I was a little too
hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and analyze.c.
I was wondering if something like that might have happened --- I know
you k
Here is a change to the alter_table regression test to use ALTER INDEX ...
RENAME instead of ALTER TABLE ... RENAME in the case of an index renaming.
Its probably not the right place for it, but I'm not sure where is the
right place for it.
Thanks,
Gavin
On Sat, 21 Aug 2004, Tom Lane wrote:
> G
Log Message:
---
Tweak code so that pg_subtrans is never consulted for XIDs older than
RecentXmin (== MyProc->xmin). This ensures that it will be safe to
truncate pg_subtrans at RecentGlobalXmin, which should largely eliminate
any fear of bloat. Along the way, eliminate SubTransXidsHaveCo
Gavin Sherry <[EMAIL PROTECTED]> writes:
> Thanks for spotting this sloppy work. Basically, I cropped my diff because
> there was lots of unrelated code in the work space. But I was a little too
> hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and analyze.c.
I was wondering if something
Umm... oops.
On Sat, 21 Aug 2004, Tom Lane wrote:
> [EMAIL PROTECTED] (Bruce Momjian) writes:
> > Add ALTER INDEX, particularly for moving tablespaces.
>
> This patch is a perfect example of why unreviewed patches should not
> go in during beta.
>
> So far I have noticed the following problems wi
Log Message:
---
Code review for ALTER INDEX patch.
Modified Files:
--
pgsql-server/src/backend/commands:
alter.c (r1.8 -> r1.9)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/alter.c.diff?r1=1.8&r2=1.9)
pgsql-server/src/b
"Marc G. Fournier" <[EMAIL PROTECTED]> writes:
> Considering point 3 seems a wee bit critical, at least to me, should the
> patch be removed and postponed for a non-Beta period?
No, the fixes are all trivial. I'm just chewing out Bruce and Gavin
for sloppiness ;-)
regard
On Sat, 21 Aug 2004, Bruce Momjian wrote:
Tom Lane wrote:
[EMAIL PROTECTED] (Bruce Momjian) writes:
Add ALTER INDEX, particularly for moving tablespaces.
This patch is a perfect example of why unreviewed patches should not
go in during beta.
So far I have noticed the following problems with it:
* A
Tom Lane wrote:
> [EMAIL PROTECTED] (Bruce Momjian) writes:
> > Add ALTER INDEX, particularly for moving tablespaces.
>
> This patch is a perfect example of why unreviewed patches should not
> go in during beta.
>
> So far I have noticed the following problems with it:
>
> * Added reference page
Log Message:
---
Fix tab completion for ALTER INDEX.
Modified Files:
--
pgsql-server/src/bin/psql:
tab-complete.c (r1.111 -> r1.112)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/psql/tab-complete.c.diff?r1=1.111&r2=1.112)
--
[EMAIL PROTECTED] (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.
This patch is a perfect example of why unreviewed patches should not
go in during beta.
So far I have noticed the following problems with it:
* Added reference page wasn't linked into the docs build
Log Message:
---
Seems it would be nice if the ALTER INDEX ref page were actually
linked into the docs ...
Modified Files:
--
pgsql-server/doc/src/sgml:
reference.sgml (r1.51 -> r1.52)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/re
Log Message:
---
Fix typo (extraneous comma).
Modified Files:
--
pgsql-server/doc/src/sgml/ref:
cluster.sgml (r1.32 -> r1.33)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/doc/src/sgml/ref/cluster.sgml.diff?r1=1.32&r2=1.33)
-
14 matches
Mail list logo
