Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Peter Eisentraut
Tom Lane wrote: > I suggest that what we should do is define SQLSTATE and SQLERRM > similarly to FOUND: they are procedure-local variables that are > assigned to by an occurrence of an error. I'd be inclined to make > them start out NULL, too, not 0/"Successful completion". Does Oracle suppor

[COMMITTERS] pgsql: Back out SQLSTATE and SQLERRM support.

2005-05-25 Thread Bruce Momjian
Log Message: --- Back out SQLSTATE and SQLERRM support. Modified Files: -- pgsql/doc/src/sgml: plpgsql.sgml (r1.68 -> r1.69) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/plpgsql.sgml.diff?r1=1.68&r2=1.69) pgsql/src/pl/plpgsql/src:

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support

2005-05-25 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Alternatively we could make them local to any block that contains an >> EXCEPTION clause, which would fix point 3 and also go a long way towards >> addressing the unnecessary-overhead gripe. However that would mean that >> an attempt to

[COMMITTERS] pgsql: Display only 9 not 10 digits of precision for timestamp values

2005-05-25 Thread Bruce Momjian
Log Message: --- Display only 9 not 10 digits of precision for timestamp values when using non-integer timestamps. This prevents the display of rounding errors for common values like days < 32. Modified Files: -- pgsql/src/backend/utils/adt: datetime.c (r1.145 -> r

Re: [COMMITTERS] pgsql: Minor cleanup for recent SQLSTATE / SQLERRM

2005-05-25 Thread Neil Conway
Tom Lane wrote: I'm not sure you should have done that; IMHO the right thing is for Bruce to back this patch out and ask for a resubmission I thought about that, but I don't see a need to back out the patch: it is not fundamentally broken or invasive to the rest of the tree. Needlessly backin

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support

2005-05-25 Thread Neil Conway
Tom Lane wrote: Alternatively we could make them local to any block that contains an EXCEPTION clause, which would fix point 3 and also go a long way towards addressing the unnecessary-overhead gripe. However that would mean that an attempt to reference them from outside an exception handler wou

Re: [COMMITTERS] pgsql: Minor cleanup for recent SQLSTATE / SQLERRM patch: spell

2005-05-25 Thread Tom Lane
[EMAIL PROTECTED] (Neil Conway) writes: > Minor cleanup for recent SQLSTATE / SQLERRM patch: spell "successful" > correctly, style fixes. I'm not sure you should have done that; IMHO the right thing is for Bruce to back this patch out and ask for a resubmission, and you just made it a lot harder f

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values on > error. I had not taken the time to review this patch before, but now that I have looked at it I'm pretty unhappy with it. It creates new local variables SQLSTATE and SQLERRM in *ever

[COMMITTERS] pgsql: Minor cleanup for recent SQLSTATE / SQLERRM patch: spell

2005-05-25 Thread Neil Conway
Log Message: --- Minor cleanup for recent SQLSTATE / SQLERRM patch: spell "successful" correctly, style fixes. Modified Files: -- pgsql/src/pl/plpgsql/src: gram.y (r1.70 -> r1.71) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/gram.y.d

[COMMITTERS] pgsql: Adjust datetime parsing to be more robust.

2005-05-25 Thread Neil Conway
Log Message: --- Adjust datetime parsing to be more robust. We now pass the length of the working buffer into ParseDateTime() and reject too-long input there, rather than checking the length of the input string before calling ParseDateTime(). The old method was bogus because ParseDateTime()

[COMMITTERS] pgsql: Adjust datetime parsing to be more robust.

2005-05-25 Thread Neil Conway
Log Message: --- Adjust datetime parsing to be more robust. We now pass the length of the working buffer into ParseDateTime() and reject too-long input there, rather than checking the length of the input string before calling ParseDateTime(). The old method was bogus because ParseDateTime()

[COMMITTERS] pgsql: Adjust datetime parsing to be more robust.

2005-05-25 Thread Neil Conway
Log Message: --- Adjust datetime parsing to be more robust. We now pass the length of the working buffer into ParseDateTime() and reject too-long input there, rather than checking the length of the input string before calling ParseDateTime(). The old method was bogus because ParseDateTime()

[COMMITTERS] pgsql: Tweak the backend scanner (and psqlscan.l, which must track the

2005-05-25 Thread Tom Lane
Log Message: --- Tweak the backend scanner (and psqlscan.l, which must track the backend scanner anyway) to avoid having any backup states. According to the flex manual, this should speed things up, and indeed the backend scanner is about a third faster according to some quick profiling ch

[COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values

2005-05-25 Thread Bruce Momjian
Log Message: --- Add PL/pgSQL SQLSTATE and SQLERRM support which sets these values on error. Pavel Stehule Modified Files: -- pgsql/doc/src/sgml: plpgsql.sgml (r1.67 -> r1.68) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/plpgsql.sgml.diff

[COMMITTERS] pgsql: At the head of wchareq, length of (multibyte) character is

2005-05-25 Thread Bruce Momjian
Log Message: --- At the head of wchareq, length of (multibyte) character is compared by using pg_mblen. Therefore, pg_mblen is executed many times, and it becomes a bottleneck. This patch makes a short cut, and reduces execution frequency of pg_mblen by comparing the first byte first. a_o

[COMMITTERS] pgsql: Quick patch to adress a recent concern on the mailing list about

2005-05-25 Thread Bruce Momjian
Log Message: --- Quick patch to adress a recent concern on the mailing list about adding an errant "TO" when we already have a TO. Since TO cannot be a valid column name (we must quote it), we can simply ignore the tab-completion if the previous word was a "TO". Greg Sabino Mullane Modifi

[COMMITTERS] pgsql: Add parentheses to macros when args are used in computations.

2005-05-25 Thread Bruce Momjian
Log Message: --- Add parentheses to macros when args are used in computations. Without them, the executation behavior could be unexpected. Modified Files: -- pgsql/contrib/intarray: _int_bool.c (r1.3 -> r1.4) (http://developer.postgresql.org/cvsweb.cgi/pgs

[COMMITTERS] pqa - pqa:

2005-05-25 Thread User Tom
Log Message: --- Modified Files: -- pqa/etc: doing_the_next_release.txt (r1.27 -> r1.28) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pqa/pqa/etc/doing_the_next_release.txt.diff?r1=1.27&r2=1.28) ---(end of broadcast)---

[COMMITTERS] pgsql: Translation updates

2005-05-25 Thread Peter Eisentraut
Log Message: --- Translation updates Tags: REL8_0_STABLE Modified Files: -- pgsql/src/backend/po: pt_BR.po (r1.8 -> r1.8.4.1) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/po/pt_BR.po.diff?r1=1.8&r2=1.8.4.1) pgsql/src/bin/pg_contro

[COMMITTERS] pgsql: Translation updates

2005-05-25 Thread Peter Eisentraut
Log Message: --- Translation updates Tags: REL7_4_STABLE Modified Files: -- pgsql/src/backend/po: pt_BR.po (r1.1.2.6 -> r1.1.2.7) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/po/pt_BR.po.diff?r1=1.1.2.6&r2=1.1.2.7) pgsql/src/bin/p