[COMMITTERS] pgsql: Nab some low-hanging fruit: replace the planner's base_rel_list

2005-06-05 Thread Tom Lane
Log Message: --- Nab some low-hanging fruit: replace the planner's base_rel_list and other_rel_list with a single array indexed by rangetable index. This reduces find_base_rel from O(N) to O(1) without any real penalty. While find_base_rel isn't one of the major bottlenecks in any profile I

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support

2005-06-05 Thread Pavel Stehule
On Thu, 2 Jun 2005, Tom Lane wrote: > Pavel Stehule <[EMAIL PROTECTED]> writes: > > I din't find easy way how append variable only when block contains > > EXCEPTION part. I wilcome any advice > > I was envisioning an action in the beginning of the EXCEPTION clause, > viz > > exception_sect : >

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support

2005-06-05 Thread Pavel Stehule
On Thu, 2 Jun 2005, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > I should have commented on this earlier: I don't think exact Oracle > > compatibility is _at all_ important. > > The results of Pavel's experiments prove that Oracle's behavior is > pretty random --- it looks to me

Re: [COMMITTERS] pgsql: Add PL/pgSQL SQLSTATE and SQLERRM support

2005-06-05 Thread Pavel Stehule
On Fri, 3 Jun 2005, Neil Conway wrote: > Pavel Stehule wrote: > > So we can have only one procedure level scope variable, which is > > initialized on start of exception and zeroized on the end of exception > > block. This behavior is different from my patch, but is better for Oracle > > compati

[COMMITTERS] pgsql: Remove planner's private fields from Query struct, and put them

2005-06-05 Thread Tom Lane
Log Message: --- Remove planner's private fields from Query struct, and put them into a new PlannerInfo struct, which is passed around instead of the bare Query in all the planning code. This commit is essentially just a code-beautification exercise, but it does open the door to making lar