[COMMITTERS] pgsql: Move setup_cancel_handler() up near start of psql main(), where

2006-06-21 Thread Tom Lane
Log Message: --- Move setup_cancel_handler() up near start of psql main(), where the setup_win32_locks() call formerly was, to ensure that cancelConnLock is valid when it needs to be. Per Yoshiyuki Asaba. Modified Files: -- pgsql/src/bin/psql: startup.c (r1.133 ->

[COMMITTERS] pgsql: Remove ancient kluge that kept nodeAgg.c from crashing on UPDATEs

2006-06-21 Thread Tom Lane
Log Message: --- Remove ancient kluge that kept nodeAgg.c from crashing on UPDATEs involving aggregates. We just disallowed that, and AFAICS there should be no other cases where direct (non-aggregated) references to input columns are allowed in a query with aggregation and no GROUP BY. Mo

[COMMITTERS] pgsql: Disallow aggregate functions in UPDATE commands (unless within a

2006-06-21 Thread Tom Lane
Log Message: --- Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT). This is disallowed by the SQL spec because it doesn't have any very sensible interpretation. Historically Postgres has allowed it but behaved strangely. As of PG 8.1 a server crash is possible if

[COMMITTERS] pgsql: Disallow aggregate functions in UPDATE commands (unless within a

2006-06-21 Thread Tom Lane
Log Message: --- Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT). This is disallowed by the SQL spec because it doesn't have any very sensible interpretation. Historically Postgres has allowed it but behaved strangely. As of PG 8.1 a server crash is possible if

[COMMITTERS] pgsql: Eliminate a gratuitously different wording of the 'cannot use

2006-06-21 Thread Tom Lane
Log Message: --- Eliminate a gratuitously different wording of the 'cannot use aggregate function in check constraint' error message. Modified Files: -- pgsql/src/backend/commands: typecmds.c (r1.90 -> r1.91) (http://developer.postgresql.org/cvsweb.cgi/pgs

[COMMITTERS] pgsql: - During dblink_open, if transaction state was IDLE, force cursor

2006-06-21 Thread Joe Conway
Log Message: --- - During dblink_open, if transaction state was IDLE, force cursor count to initially be 0. This is needed as a previous ABORT might have wiped out an automatically opened transaction without maintaining the cursor count. - Fix regression test expected file for the corre

[COMMITTERS] pgsql: - During dblink_open, if transaction state was IDLE, force cursor

2006-06-21 Thread Joe Conway
Log Message: --- - During dblink_open, if transaction state was IDLE, force cursor count to initially be 0. This is needed as a previous ABORT might have wiped out an automatically opened transaction without maintaining the cursor count. - Fix regression test expected file for the corre

[COMMITTERS] pgsql: Clean up psql variable code a little: eliminate unnecessary tests

2006-06-21 Thread Tom Lane
Log Message: --- Clean up psql variable code a little: eliminate unnecessary tests in GetVariable() and be consistent about treatment of the list header. Motivated by noticing strspn() taking an unreasonable percentage of runtime --- the call removed from GetVariable() was the only one that

[COMMITTERS] fulldisjunction - fd: Some more deformed tuple structures consolidation

2006-06-21 Thread User Pgstudy
Log Message: --- Some more deformed tuple structures consolidation works. Modified Files: -- fd: algutils.c (r1.8 -> r1.9) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/fulldisjunction/fd/algutils.c.diff?r1=1.8&r2=1.9) odmbfd.c (r1.11 -> r1.12)

[COMMITTERS] pgsql: Added some more coverity report patches send in by Martijn van

2006-06-21 Thread Michael Meskes
Log Message: --- Added some more coverity report patches send in by Martijn van Oosterhout . Tags: REL8_0_STABLE Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: connect.c (r1.24.4.4 -> r1.24.4.5) (http://developer.postgresql.org/cvsweb.cgi/pgsq

[COMMITTERS] pgsql: Added some more coverity report patches send in by Martijn van

2006-06-21 Thread Michael Meskes
Log Message: --- Added some more coverity report patches send in by Martijn van Oosterhout . Tags: REL8_1_STABLE Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: connect.c (r1.26.2.3 -> r1.26.2.4) (http://developer.postgresql.org/cvsweb.cgi/pgsq

[COMMITTERS] pgsql: Added some more coverity report patches send in by Martijn van

2006-06-21 Thread Michael Meskes
Log Message: --- Added some more coverity report patches send in by Martijn van Oosterhout . Modified Files: -- pgsql/src/interfaces/ecpg: ChangeLog (r1.306 -> r1.307) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ChangeLog.diff?r1=

[COMMITTERS] pgsql: Fixed small typo in changelog

2006-06-21 Thread Michael Meskes
Log Message: --- Fixed small typo in changelog Modified Files: -- pgsql/src/interfaces/ecpg: ChangeLog (r1.305 -> r1.306) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ChangeLog.diff?r1=1.305&r2=1.306) ---(en

[COMMITTERS] pgsql: Added fixes from the coverity report send in by Joachim Wieland

2006-06-21 Thread Michael Meskes
Log Message: --- Added fixes from the coverity report send in by Joachim Wieland <[EMAIL PROTECTED]> Added missing error handling in a few functions in ecpglib. Tags: REL8_0_STABLE Modified Files: -- pgsql/src/interfaces/ecpg/compatlib: informix.c (r1.38.4.1

[COMMITTERS] pgsql: Added fixes from the coverity report send in by Joachim Wieland

2006-06-21 Thread Michael Meskes
Log Message: --- Added fixes from the coverity report send in by Joachim Wieland <[EMAIL PROTECTED]> Added missing error handling in a few functions in ecpglib. Tags: REL8_1_STABLE Modified Files: -- pgsql/src/interfaces/ecpg/compatlib: informix.c (r1.39.2.2

[COMMITTERS] pgsql: Added fixed from the coverity report send in by Joachim Wieland

2006-06-21 Thread Michael Meskes
Log Message: --- Added fixed from the coverity report send in by Joachim Wieland <[EMAIL PROTECTED]> Added missing error handling in a few functions in ecpglib Modified Files: -- pgsql/src/interfaces/ecpg: ChangeLog (r1.304 -> r1.305) (http://developer.pos