Andres Freund writes:
> I just found a relatively big problem with one of your modifications on the
> patch - you removed the
> FreeDir(xldir);
> xldir = AllocateDir(fromdir);
> pair - unfortunately its crucial because otherwise the DIR does not get
> rewound - that resulted in *no* files getti
Log Message:
---
Fix multiple copy and paste-o's. No wonder this code didn't work.
Modified Files:
--
pgsql/src/port:
copydir.c (r1.29 -> r1.30)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/copydir.c?r1=1.29&r2=1.30)
--
Sent via pgsql-committ
On Mon, Feb 22, 2010 at 9:11 AM, Greg Stark wrote:
> Log Message:
> ---
> Oops, don't forget to rewind the directory before scanning it to fsync files
> in CREATE DATABASE
}
+ Free(xldir);
s/Free/FreeDir ?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATI
st...@postgresql.org (Greg Stark) writes:
> Oops, don't forget to rewind the directory before scanning it to fsync files
> in CREATE DATABASE
This is certainly not right:
+ AllocateDir(fromdir);
if (xldir == NULL)
ereport(ERROR,
There's no guarantee AllocateDir wil
On Sun, Feb 21, 2010 at 11:43 PM, Andres Freund wrote:
> Could you add it back?
>
Oops, sorry. Sigh. Done.
--
greg
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Log Message:
---
Oops, don't forget to rewind the directory before scanning it to fsync files in
CREATE DATABASE
Modified Files:
--
pgsql/src/port:
copydir.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/copydir.c?r1=1.28&r2=1.2
On Monday 15 February 2010 01:50:57 Greg Stark wrote:
> Log Message:
> ---
> Speed up CREATE DATABASE by deferring the fsyncs until after copying
> all the data and using posix_fadvise to nudge the OS into flushing it
> earlier. This also hopefully makes CREATE DATABASE avoid spamming the
>
