[COMMITTERS] pgsql: Waiting for complete startup is now a well-defined operation.

2010-12-16 Thread Robert Haas
Waiting for complete startup is now a well-defined operation. Per report from Fujii Masao, and subsequent discussion. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=df142bf82c84de5d0588ae7d52881501abb039ed Modified Files -- doc/

[COMMITTERS] pgsql: Improve comments around startup_hacks() code.

2010-12-16 Thread Tom Lane
Improve comments around startup_hacks() code. These comments were not updated when we added the EXEC_BACKEND mechanism for Windows, even though it rendered them inaccurate. Also unify two unnecessarily-separate #ifdef __alpha code blocks. Branch -- master Details --- http://git.postgres

[COMMITTERS] pgsql: Remove optreset from src/port/ implementations of getopt and get

2010-12-16 Thread Tom Lane
Remove optreset from src/port/ implementations of getopt and getopt_long. We don't actually need optreset, because we can easily fix the code to ensure that it's cleanly restartable after having completed a scan over the argv array; which is the only case we need to restart in. Getting rid of it

[COMMITTERS] pgsql: Remove optreset from src/port/ implementations of getopt and get

2010-12-16 Thread Tom Lane
Remove optreset from src/port/ implementations of getopt and getopt_long. We don't actually need optreset, because we can easily fix the code to ensure that it's cleanly restartable after having completed a scan over the argv array; which is the only case we need to restart in. Getting rid of it

[COMMITTERS] pgsql: Remove optreset from src/port/ implementations of getopt and get

2010-12-16 Thread Tom Lane
Remove optreset from src/port/ implementations of getopt and getopt_long. We don't actually need optreset, because we can easily fix the code to ensure that it's cleanly restartable after having completed a scan over the argv array; which is the only case we need to restart in. Getting rid of it

Re: [COMMITTERS] pgsql: Fix inconsequential FILE pointer leakage

2010-12-16 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue dic 16 17:00:43 -0300 2010: > --- a/src/port/exec.c > +++ b/src/port/exec.c > @@ -357,6 +357,7 @@ pipe_read_line(char *cmd, char *line, int maxsize) > > if (fgets(line, maxsize, pgver) == NULL) > { > + pclose(pgver); /* no error checking

[COMMITTERS] pgsql: Avoid clobbering errno, per comment from Tom.

2010-12-16 Thread Alvaro Herrera
Avoid clobbering errno, per comment from Tom. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=cd1fefa973968ff4e3760a9593f70fe2da0def48 Modified Files -- src/port/exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [COMMITTERS] pgsql: Fix inconsequential FILE pointer leakage

2010-12-16 Thread Tom Lane
Alvaro Herrera writes: --- a/src/port/exec.c +++ b/src/port/exec.c @@ -357,6 +357,7 @@ pipe_read_line(char *cmd, char *line, int maxsize) if (fgets(line, maxsize, pgver) == NULL) { + pclose(pgver); /* no error checking */ perror("fgets failure"); return NULL;

[COMMITTERS] pgsql: Fix inconsequential FILE pointer leakage

2010-12-16 Thread Alvaro Herrera
Fix inconsequential FILE pointer leakage Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=83c759ea0ea8ffe07c45e6fd2c489cebce2caad6 Modified Files -- src/port/exec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Se

[COMMITTERS] pgsql: Simplify SignalSomeChildren(BACKEND_TYPE_ALL) to SignalChildren(

2010-12-16 Thread Alvaro Herrera
Simplify SignalSomeChildren(BACKEND_TYPE_ALL) to SignalChildren() Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=16ca75baebc56cebc6590691a0b474ee1922519c Modified Files -- src/backend/postmaster/postmaster.c |2 +- 1 files cha

[COMMITTERS] pgsql: Add some minor missing error checks

2010-12-16 Thread Alvaro Herrera
Add some minor missing error checks Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e359b8496d11befb63d4734874d997909c44ad83 Modified Files -- src/port/win32env.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) --

[COMMITTERS] pgsql: Fix crash caused by NULL lookup when reporting IP address of fai

2010-12-16 Thread Bruce Momjian
Fix crash caused by NULL lookup when reporting IP address of failed libpq connection, per report from Magnus. This happens only on GIT master and only on Win32 because that is the platform where "" maps to an IP address (localhost). Branch -- master Details --- http://git.postgresql.org/

[COMMITTERS] libpqtypes - libpqtypes: fixed type->array join to properly use typarray

2010-12-16 Thread User Merlinm
Log Message: --- fixed type->array join to properly use typarray Modified Files: -- libpqtypes: ChangeLog (r1.52 -> r1.53) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/ChangeLog?r1=1.52&r2=1.53) -- Sent via pgsql-committers mailing l

[COMMITTERS] libpqtypes - libpqtypes: fixed type->array join to properly use typarray

2010-12-16 Thread User Merlinm
Log Message: --- fixed type->array join to properly use typarray Modified Files: -- libpqtypes: ChangeLog (r1.51 -> r1.52) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/ChangeLog?r1=1.51&r2=1.52) -- Sent via pgsql-committers mailing l

[COMMITTERS] libpqtypes - libpqtypes: fixed type->array join to properly use typarray

2010-12-16 Thread User Merlinm
Log Message: --- fixed type->array join to properly use typarray Modified Files: -- libpqtypes/src: handler.c (r1.22 -> r1.23) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/libpqtypes/libpqtypes/src/handler.c?r1=1.22&r2=1.23) -- Sent via pgsql-committers m

[COMMITTERS] npgsql - Npgsql2: Fixed: [#1010951] AllowPartiallyTrustedCallers for

2010-12-16 Thread User Fxjr
Log Message: --- Fixed: [#1010951] AllowPartiallyTrustedCallers for npgsql assemblies. Updated AssemblyInfo.cs to include the fix above and to update assembly version. Modified Files: -- Npgsql2/src: Npgsql.build (r1.21 -> r1.22) (http://cvs.pgfoundry.org/