[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Actually, all of parallel restore's limitations should be tested

2011-08-28 Thread Tom Lane
Actually, all of parallel restore's limitations should be tested earlier. On closer inspection, whining in restore_toc_entries_parallel is really much too late for any user-facing error case. The right place to do it is at the start of RestoreArchive(), before we've done anything interesting (suh

[COMMITTERS] pgsql: Be more user-friendly about unsupported cases for parallel pg_re

2011-08-28 Thread Tom Lane
Be more user-friendly about unsupported cases for parallel pg_restore. If we are unable to do a parallel restore because the input file is stdin or is otherwise unseekable, we should complain and fail immediately, not after having done some of the restore. Complaining once per thread isn't so coo

[COMMITTERS] pgsql: Be more user-friendly about unsupported cases for parallel pg_re

2011-08-28 Thread Tom Lane
Be more user-friendly about unsupported cases for parallel pg_restore. If we are unable to do a parallel restore because the input file is stdin or is otherwise unseekable, we should complain and fail immediately, not after having done some of the restore. Complaining once per thread isn't so coo

[COMMITTERS] pgsql: Be more user-friendly about unsupported cases for parallel pg_re

2011-08-28 Thread Tom Lane
Be more user-friendly about unsupported cases for parallel pg_restore. If we are unable to do a parallel restore because the input file is stdin or is otherwise unseekable, we should complain and fail immediately, not after having done some of the restore. Complaining once per thread isn't so coo

[COMMITTERS] pgsql: Be more user-friendly about unsupported cases for parallel pg_re

2011-08-28 Thread Tom Lane
Be more user-friendly about unsupported cases for parallel pg_restore. If we are unable to do a parallel restore because the input file is stdin or is otherwise unseekable, we should complain and fail immediately, not after having done some of the restore. Complaining once per thread isn't so coo

Re: [COMMITTERS] pgsql: Allow more include files to be compiled in their own by adding m

2011-08-28 Thread Andrew Dunstan
On 08/28/2011 04:55 PM, Tom Lane wrote: Bruce Momjian writes: Allow more include files to be compiled in their own by adding missing include dependencies. This patch broke the build on buildfarm member mongoose. I'm not sure I understand the point of it anyway. c

[COMMITTERS] pgsql: Include $cc_string in the info reported by a configure run.

2011-08-28 Thread Tom Lane
Include $cc_string in the info reported by a configure run. Without this, it's not very easy to tell which compiler version a buildfarm animal is actually using at the moment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2c5d6f1fb570db1a287532d3291d284710e756bf M

Re: [COMMITTERS] pgsql: Allow more include files to be compiled in their own by adding m

2011-08-28 Thread Tom Lane
Bruce Momjian writes: > Allow more include files to be compiled in their own by adding missing > include dependencies. This patch broke the build on buildfarm member mongoose. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected])

[COMMITTERS] pgsql: Modify pgrminclude -v to report include files that can't be comp

2011-08-28 Thread Bruce Momjian
Modify pgrminclude -v to report include files that can't be compiled on their own. Avoid compile problems with defines being redefined after the removal of the #if blocks. Change script to use shell functions for simplicity. Branch -- master Details --- http://git.postgresql.org/pg/comm