Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Tom Lane
Alex Hunsaker writes: > PFA that copies if its readonly and its not a scalar. Also I fixed up > Tom's complaint about having sv2cstr() inside do_util_elog's PG_TRY > block. On reflection I don't believe that just moving that call will improve matters. sv2cstr also contains a palloc, and if that

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Alex Hunsaker
On Thu, Jan 5, 2012 at 16:59, Andrew Dunstan wrote: > > > On 01/05/2012 06:31 PM, Alex Hunsaker wrote: >> >> On Thu, Jan 5, 2012 at 16:02, Andrew Dunstan  wrote: >>> >>> Fix breakage from earlier plperl fix. >> I can't help but think this seems a bit inefficient > > So, yes, we should probably ad

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Andrew Dunstan
On 01/05/2012 06:31 PM, Alex Hunsaker wrote: On Thu, Jan 5, 2012 at 16:02, Andrew Dunstan wrote: Fix breakage from earlier plperl fix. Apparently the perl garbage collector was a bit too eager, so here we control when the new SV is garbage collected. I know im a little late to the party...

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Alex Hunsaker
On Thu, Jan 5, 2012 at 16:02, Andrew Dunstan wrote: > Fix breakage from earlier plperl fix. > > Apparently the perl garbage collector was a bit too eager, so here > we control when the new SV is garbage collected. I know im a little late to the party... I can't help but think this seems a bit in

[COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Andrew Dunstan
Fix breakage from earlier plperl fix. Apparently the perl garbage collector was a bit too eager, so here we control when the new SV is garbage collected. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd0e74a9ce98c65c94565fb603dcc7b710cd4227 Modified Files

[COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

2012-01-05 Thread Andrew Dunstan
Fix breakage from earlier plperl fix. Apparently the perl garbage collector was a bit too eager, so here we control when the new SV is garbage collected. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d1d836f92c0798f4bc4138dc6b87279199c4f49a Modified Files -

[COMMITTERS] pgsql: pg_dump: Dump foreign options in prettier format

2012-01-05 Thread Peter Eisentraut
pg_dump: Dump foreign options in prettier format Dump them using line breaks and indentation instead of everything on one line. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7e53515480853604aac825bd3e53e7f9716632b4 Modified Files -- src/bin/pg_dump/pg_

[COMMITTERS] pgsql: pg_dump: Dump operators with the same name ordered by arity

2012-01-05 Thread Peter Eisentraut
pg_dump: Dump operators with the same name ordered by arity pg_dump sorts operators by name, but operators with the same name come out in random order. Now operators with the same name are dumped in the order prefix, postfix, infix. (This is consistent with functions, which are dumped in increas

[COMMITTERS] pgsql: Improve ALTER DOMAIN / DROP CONSTRAINT with nonexistent constrai

2012-01-05 Thread Peter Eisentraut
Improve ALTER DOMAIN / DROP CONSTRAINT with nonexistent constraint ALTER DOMAIN / DROP CONSTRAINT on a nonexistent constraint name did not report any error. Now it reports an error. The IF EXISTS option was added to get the usual behavior of ignoring nonexistent objects to drop. Branch -- m

[COMMITTERS] pgsql: Work around perl bug in SvPVutf8().

2012-01-05 Thread Andrew Dunstan
Work around perl bug in SvPVutf8(). Certain things like typeglobs or readonly things like $^V cause perl's SvPVutf8() to die nastily and crash the backend. To avoid that bug we make a copy of the object, which will subsequently be garbage collected. Back patched to 9.1 where we first started usin

[COMMITTERS] pgsql: Work around perl bug in SvPVutf8().

2012-01-05 Thread Andrew Dunstan
Work around perl bug in SvPVutf8(). Certain things like typeglobs or readonly things like $^V cause perl's SvPVutf8() to die nastily and crash the backend. To avoid that bug we make a copy of the object, which will subsequently be garbage collected. Back patched to 9.1 where we first started usin

[COMMITTERS] autodoc - autodoc: 1.41 release notes

2012-01-05 Thread User Rbt
Log Message: --- 1.41 release notes Modified Files: -- autodoc: ChangeLog (r1.12 -> r1.13) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/autodoc/autodoc/ChangeLog?r1=1.12&r2=1.13) -- Sent via pgsql-committers mailing list ([email protected])

[COMMITTERS] autodoc - autodoc: Mark 1.41 release

2012-01-05 Thread User Rbt
Log Message: --- Mark 1.41 release Modified Files: -- autodoc: postgresql_autodoc.pl (r1.29 -> r1.30) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/autodoc/autodoc/postgresql_autodoc.pl?r1=1.29&r2=1.30) -- Sent via pgsql-committers mailing list (pgsql-comm

[COMMITTERS] autodoc - autodoc: Update schema for Docbook 4.5.

2012-01-05 Thread User Rbt
Log Message: --- Update schema for Docbook 4.5. Use where possible. Modified Files: -- autodoc: xml.tmpl (r1.2 -> r1.3) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/autodoc/autodoc/xml.tmpl?r1=1.2&r2=1.3) -- Sent via pgsql-committers mailing list (pgsql-

[COMMITTERS] pgsql: Ecpglib stores variables that are used in DECLARE statements in

2012-01-05 Thread Michael Meskes
Ecpglib stores variables that are used in DECLARE statements in a global list. This list is now freed when the last connection has been closed. Closes: #6366 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8cf82ac53e9a3d5dd86f16106e3398063a526817 Modified Files