[COMMITTERS] pgsql: Add caution about multiple unique indexes breaking plpgsql upser

2012-01-28 Thread Tom Lane
Add caution about multiple unique indexes breaking plpgsql upsert example. Per Phil Sorber, though I didn't use his wording exactly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ed6e0545f5f6e9977c8410e04244138b567c5a73 Modified Files -- doc/src/sgml/p

[COMMITTERS] pgsql: Update statement about sorting of character-string data.

2012-01-28 Thread Tom Lane
Update statement about sorting of character-string data. The sort order is no longer fixed at database creation time, but can be controlled via COLLATE. Noted by Thomas Kellerer. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b3bd5a093f3758cf168dae88478f9fc5

[COMMITTERS] pgsql: Update statement about sorting of character-string data.

2012-01-28 Thread Tom Lane
Update statement about sorting of character-string data. The sort order is no longer fixed at database creation time, but can be controlled via COLLATE. Noted by Thomas Kellerer. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/17d3233e1bfd9fbe856f032a542f2c595e79ca0

[COMMITTERS] pgsql: Fix handling of init_plans list in inheritance_planner().

2012-01-28 Thread Tom Lane
Fix handling of init_plans list in inheritance_planner(). Formerly we passed an empty list to each per-child-table invocation of grouping_planner, and then merged the results into the global list. However, that fails if there's a CTE attached to the statement, because create_ctescan_plan uses the

[COMMITTERS] pgsql: Fix handling of init_plans list in inheritance_planner().

2012-01-28 Thread Tom Lane
Fix handling of init_plans list in inheritance_planner(). Formerly we passed an empty list to each per-child-table invocation of grouping_planner, and then merged the results into the global list. However, that fails if there's a CTE attached to the statement, because create_ctescan_plan uses the

[COMMITTERS] pgsql: Add simple tests of EvalPlanQual using the isolationtester infra

2012-01-28 Thread Tom Lane
Add simple tests of EvalPlanQual using the isolationtester infrastructure. Much more could be done here, but at least now we have *some* automated test coverage of that mechanism. In particular this tests the writable-CTE case reported by Phil Sorber. In passing, remove isolationtester's arbitra

[COMMITTERS] pgsql: Fix handling of data-modifying CTE subplans in EvalPlanQual.

2012-01-28 Thread Tom Lane
Fix handling of data-modifying CTE subplans in EvalPlanQual. We can't just skip initializing such subplans, because the referencing CTE node will expect to find the subplan available when it initializes. That in turn means that ExecInitModifyTable must allow the case (which actually it needed to

[COMMITTERS] pgsql: Fix handling of data-modifying CTE subplans in EvalPlanQual.

2012-01-28 Thread Tom Lane
Fix handling of data-modifying CTE subplans in EvalPlanQual. We can't just skip initializing such subplans, because the referencing CTE node will expect to find the subplan available when it initializes. That in turn means that ExecInitModifyTable must allow the case (which actually it needed to

[COMMITTERS] pgsql: Prevent logging "failed to stat file: success" for temp files

2012-01-28 Thread Magnus Hagander
Prevent logging "failed to stat file: success" for temp files This was broken in commit bc3347484a7bf9eddb98e4352d84599cae9a31c6, the addition of statistics counters for temp files. Reported by Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/672614cf2137b