[COMMITTERS] pgsql: Refactor the way code is shared between some range type function

2012-07-18 Thread Heikki Linnakangas
Refactor the way code is shared between some range type functions. Functions like range_eq, range_before etc. are exposed at the SQL-level, but they're also used internally by the GiST consistent support function. The code sharing was done by a hack, TrickFunctionCall2, which relied on the knowled

[COMMITTERS] pgsql: Refactor the way code is shared between some range type function

2012-07-18 Thread Heikki Linnakangas
Refactor the way code is shared between some range type functions. Functions like range_eq, range_before etc. are exposed at the SQL-level, but they're also used internally by the GiST consistent support function. The code sharing was done by a hack, TrickFunctionCall2, which relied on the knowled

Re: [COMMITTERS] pgsql: Fix management of pendingOpsTable in auxiliary processes.

2012-07-18 Thread Simon Riggs
On 18 July 2012 20:38, Tom Lane wrote: > Creation of the table in the > bgwriter is fatal, because it absorbs fsync requests that should have gone > to the checkpointer; instead they just sit in bgwriter local memory and are > never acted on. Hmmm, sorry about that. I would swear I had fixed th

[COMMITTERS] pgsql: Fix statistics breakage from bgwriter/checkpointer process split

2012-07-18 Thread Tom Lane
Fix statistics breakage from bgwriter/checkpointer process split. ForwardFsyncRequest() supposed that it could only be called in regular backends, which used to be true; but since the splitup of bgwriter and checkpointer, it is also called in the bgwriter. We do not want to count such calls in pg

[COMMITTERS] pgsql: Fix statistics breakage from bgwriter/checkpointer process split

2012-07-18 Thread Tom Lane
Fix statistics breakage from bgwriter/checkpointer process split. ForwardFsyncRequest() supposed that it could only be called in regular backends, which used to be true; but since the splitup of bgwriter and checkpointer, it is also called in the bgwriter. We do not want to count such calls in pg

[COMMITTERS] pgsql: Fix management of pendingOpsTable in auxiliary processes.

2012-07-18 Thread Tom Lane
Fix management of pendingOpsTable in auxiliary processes. mdinit() was misusing IsBootstrapProcessingMode() to decide whether to create an fsync pending-operations table in the current process. This led to creating a table not only in the startup and checkpointer processes as intended, but also i

[COMMITTERS] pgsql: Fix management of pendingOpsTable in auxiliary processes.

2012-07-18 Thread Tom Lane
Fix management of pendingOpsTable in auxiliary processes. mdinit() was misusing IsBootstrapProcessingMode() to decide whether to create an fsync pending-operations table in the current process. This led to creating a table not only in the startup and checkpointer processes as intended, but also i

[COMMITTERS] pgsql: Syntax support and documentation for event triggers.

2012-07-18 Thread Robert Haas
Syntax support and documentation for event triggers. They don't actually do anything yet; that will get fixed in a follow-on commit. But this gets the basic infrastructure in place, including CREATE/ALTER/DROP EVENT TRIGGER; support for COMMENT, SECURITY LABEL, and ALTER EXTENSION .. ADD/DROP EVE