Re: [COMMITTERS] pgsql: Revert commit_delay change; just add comment that we don't hav

2012-08-15 Thread Peter Geoghegan
On 15 August 2012 05:15, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan pe...@2ndquadrant.com writes: On 14 August 2012 21:26, Bruce Momjian br...@momjian.us wrote: Revert commit_delay change; just add comment that we don't have a microsecond specification. I think that if we eventually

[COMMITTERS] pgsql: Properly escape usernames in initdb, so names with single-quotes

2012-08-15 Thread Bruce Momjian
Properly escape usernames in initdb, so names with single-quotes are supported. Also add assert to catch future breakage. Also, improve documentation that double-quotes must be used in pg_hba.conf (not single quotes). Branch -- master Details ---

[COMMITTERS] pgsql: Disallow extensions from owning the schema they are assigned to.

2012-08-15 Thread Tom Lane
Disallow extensions from owning the schema they are assigned to. This situation creates a dependency loop that confuses pg_dump and probably other things. Moreover, since the mental model is that the extension contains schemas it owns, but is contained in its extschema (even though neither is

[COMMITTERS] pgsql: Disallow extensions from owning the schema they are assigned to.

2012-08-15 Thread Tom Lane
Disallow extensions from owning the schema they are assigned to. This situation creates a dependency loop that confuses pg_dump and probably other things. Moreover, since the mental model is that the extension contains schemas it owns, but is contained in its extschema (even though neither is

[COMMITTERS] pgsql: Disallow extensions from owning the schema they are assigned to.

2012-08-15 Thread Tom Lane
Disallow extensions from owning the schema they are assigned to. This situation creates a dependency loop that confuses pg_dump and probably other things. Moreover, since the mental model is that the extension contains schemas it owns, but is contained in its extschema (even though neither is

[COMMITTERS] pgsql: Document that foreign version and type values are only usefu

2012-08-15 Thread Bruce Momjian
Document that foreign version and type values are only useful to certain foreign data wrappers. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fc5f20057f8666107f37d0c97fd6614054e72edc Modified Files -- doc/src/sgml/ref/create_server.sgml |4 ++-- 1

[COMMITTERS] pgsql: Add C comment that '=' is not documented for plpgsql assignment.

2012-08-15 Thread Bruce Momjian
Add C comment that '=' is not documented for plpgsql assignment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1d9a6ae8555da4a7de0046c61264748602ff6086 Modified Files -- src/pl/plpgsql/src/gram.y |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Document why you can't use date_trunc(week) on intervals.

2012-08-15 Thread Bruce Momjian
Document why you can't use date_trunc(week) on intervals. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74f4881d7cc9c69cb0e0b236f06d1ebf9859a737 Modified Files -- doc/src/sgml/func.sgml |5 + 1 files changed, 5 insertions(+), 0 deletions(-) --

[COMMITTERS] pgsql: On second thought, explain why date_trunc(week) on interval va

2012-08-15 Thread Bruce Momjian
On second thought, explain why date_trunc(week) on interval values is not supported in the error message, rather than the docs. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/083b9133aa0e5e91d74ba46b530a74989223324d Modified Files --

[COMMITTERS] pgsql: Fix rescan logic in nodeCtescan.

2012-08-15 Thread Tom Lane
Fix rescan logic in nodeCtescan. The previous coding essentially assumed that nodes would be rescanned in the same order they were initialized in; or at least that the leader of a group of CTEscans would be rescanned before any others were required to execute. Unfortunately, that isn't even a

[COMMITTERS] pgsql: Fix rescan logic in nodeCtescan.

2012-08-15 Thread Tom Lane
Fix rescan logic in nodeCtescan. The previous coding essentially assumed that nodes would be rescanned in the same order they were initialized in; or at least that the leader of a group of CTEscans would be rescanned before any others were required to execute. Unfortunately, that isn't even a

[COMMITTERS] pgsql: Fix rescan logic in nodeCtescan.

2012-08-15 Thread Tom Lane
Fix rescan logic in nodeCtescan. The previous coding essentially assumed that nodes would be rescanned in the same order they were initialized in; or at least that the leader of a group of CTEscans would be rescanned before any others were required to execute. Unfortunately, that isn't even a

[COMMITTERS] pgsql: Fix rescan logic in nodeCtescan.

2012-08-15 Thread Tom Lane
Fix rescan logic in nodeCtescan. The previous coding essentially assumed that nodes would be rescanned in the same order they were initialized in; or at least that the leader of a group of CTEscans would be rescanned before any others were required to execute. Unfortunately, that isn't even a

[COMMITTERS] pgsql: Fix rescan logic in nodeCtescan.

2012-08-15 Thread Tom Lane
Fix rescan logic in nodeCtescan. The previous coding essentially assumed that nodes would be rescanned in the same order they were initialized in; or at least that the leader of a group of CTEscans would be rescanned before any others were required to execute. Unfortunately, that isn't even a

[COMMITTERS] pgsql: In psql, if the is no connection object, e.g. due to a server cr

2012-08-15 Thread Bruce Momjian
In psql, if the is no connection object, e.g. due to a server crash, require all parameters for \c, rather than using the defaults, which might be wrong. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fe21fcaf8d91a71c15ff25276f9fa81e0cd1dba9 Modified Files

[COMMITTERS] pgsql: Update C comment to NOTICE to reflect previous commit changing t

2012-08-15 Thread Bruce Momjian
Update C comment to NOTICE to reflect previous commit changing the error level, per report from Tom. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/41fa3dfb0a266d424fa5d87962cf7a543fe421e2 Modified Files -- src/backend/access/transam/xact.c |2 +- 1

[COMMITTERS] pgsql: Add C comment about new \c parameter requirement for crashed con

2012-08-15 Thread Bruce Momjian
Add C comment about new \c parameter requirement for crashed connections. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d55f1b852d4fe87f2a4d16ea3f0ce11a7019a352 Modified Files -- src/bin/psql/command.c |5 + 1 files changed, 5 insertions(+), 0

[COMMITTERS] pgsql: Properly document that NEW is unassigned in plpgsql for DELETE (

2012-08-15 Thread Bruce Momjian
Properly document that NEW is unassigned in plpgsql for DELETE (not NULL), and OLD is unassigned for INSERT, and NEW/OLD are unassigned (not NULL) for statement-level triggers. Per report from Pavel Stehule Branch -- master Details ---

[COMMITTERS] pgsql: Add CREATE FOREIGN TABLE doc reference to CREATE SERVER.

2012-08-15 Thread Bruce Momjian
Add CREATE FOREIGN TABLE doc reference to CREATE SERVER. Per suggestion from Ray Stell Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/16d508ccbc6f228c8c38dffbe9d295ac449c809b Modified Files -- doc/src/sgml/ref/create_foreign_table.sgml |3 ++- 1

[COMMITTERS] pgsql: Document that pg_ctl -w allows for the entry of an SSL passphase

2012-08-15 Thread Bruce Momjian
Document that pg_ctl -w allows for the entry of an SSL passphase on startup. Per report from Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6ff55ebe3dc790ebd80f9a26fa3d05867aee728e Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |1 +

[COMMITTERS] pgsql: Document that PGDATA has to point to the configuration files, ra

2012-08-15 Thread Bruce Momjian
Document that PGDATA has to point to the configuration files, rather than the actual data storage directory. Per suggestion from Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/077908aed726b0e1605ed27156d7ebcf93a64d5d Modified Files --

[COMMITTERS] pgsql: Fix SGML markup; missing tag.

2012-08-15 Thread Bruce Momjian
Fix SGML markup; missing tag. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de3773d951bfc85d8860295248cf91db524a4ef8 Modified Files -- doc/src/sgml/ref/create_foreign_table.sgml |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via