Re: [COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Heikki Linnakangas
On 02.10.2012 21:12, Fujii Masao wrote: + * The files are named like ".history". For example, if the + * database starts up and switches to timeline 5, while processing WAL + * segment 0003002A0006 (the old timeline was 3), the timeline + * history file would be called "000500

[COMMITTERS] pgsql: Fix two bugs introduced in the xlog.c split.

2012-10-02 Thread Heikki Linnakangas
Fix two bugs introduced in the xlog.c split. The comment explaining the naming of timeline history files was wrong, and the history file was not being arhived. Pointed out by Fujii Masao. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bc1229c83238a0d71a3923cb48e53e

[COMMITTERS] pgsql: Improve some LDAP authentication error messages

2012-10-02 Thread Peter Eisentraut
Improve some LDAP authentication error messages Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6bd176095b59c1d7acfed3adf7648d04d7b2916f Modified Files -- src/backend/libpq/auth.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-

[COMMITTERS] pgsql: In pg_upgrade, use full path name for analyze_new_cluster.sh scr

2012-10-02 Thread Bruce Momjian
In pg_upgrade, use full path name for analyze_new_cluster.sh script. Backpatch to 9.2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ce754579491bfcfc1c83b737fa5373c2e3fc4b39 Modified Files -- contrib/pg_upgrade/check.c |8 1 files changed,

[COMMITTERS] pgsql: In pg_upgrade, use full path name for analyze_new_cluster.sh scr

2012-10-02 Thread Bruce Momjian
In pg_upgrade, use full path name for analyze_new_cluster.sh script. Backpatch to 9.2. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/03dfbce9a2d5f1680438ddb2837b68e6a6624b66 Modified Files -- contrib/pg_upgrade/check.c |8 1 files ch

[COMMITTERS] pgsql: Refactor "ALTER some-obj SET SCHEMA" implementation

2012-10-02 Thread Alvaro Herrera
Refactor "ALTER some-obj SET SCHEMA" implementation Instead of having each object type implement the catalog munging independently, centralize knowledge about how to do it and expand the existing table in objectaddress.c with enough data about each object type to support this operation. Author: K

[COMMITTERS] pgsql: Work around unportable behavior of malloc(0) and realloc(NULL, 0

2012-10-02 Thread Tom Lane
Work around unportable behavior of malloc(0) and realloc(NULL, 0). On some platforms these functions return NULL, rather than the more common practice of returning a pointer to a zero-sized block of memory. Hack our various wrapper functions to hide the difference by substituting a size request o

[COMMITTERS] pgsql: Work around unportable behavior of malloc(0) and realloc(NULL, 0

2012-10-02 Thread Tom Lane
Work around unportable behavior of malloc(0) and realloc(NULL, 0). On some platforms these functions return NULL, rather than the more common practice of returning a pointer to a zero-sized block of memory. Hack our various wrapper functions to hide the difference by substituting a size request o

[COMMITTERS] pgsql: Standardize naming of malloc/realloc/strdup wrapper functions.

2012-10-02 Thread Tom Lane
Standardize naming of malloc/realloc/strdup wrapper functions. We had a number of variants on the theme of "malloc or die", with the majority named like "pg_malloc", but by no means all. Standardize on the names pg_malloc, pg_malloc0, pg_realloc, pg_strdup. Get rid of pg_calloc entirely in favor

Re: [COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Fujii Masao
On Tue, Oct 2, 2012 at 7:39 PM, Heikki Linnakangas wrote: > Split off functions related to timeline history files and XLOG archiving. > > This is just refactoring, to make the functions accessible outside xlog.c. > A followup patch will make use of that, to allow fetching timeline history > files

Re: [COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
On 02.10.2012 19:33, Fujii Masao wrote: On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas wrote: Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning

[COMMITTERS] pgsql: Fix typo in previous warning-silencing patch.

2012-10-02 Thread Heikki Linnakangas
Fix typo in previous warning-silencing patch. Fujii Masao Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/87b6a3989fec4a8d10de910671ab702e07aa85cf Modified Files -- src/bin/pg_basebackup/receivelog.c |2 +- 1 files changed, 1 insertions(+), 1 d

[COMMITTERS] pgsql: Fix typo in previous warning-silencing patch.

2012-10-02 Thread Heikki Linnakangas
Fix typo in previous warning-silencing patch. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/779f80b75d448d61cf3388645505c9fd81000bb2 Modified Files -- src/bin/pg_basebackup/receivelog.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

Re: [COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Fujii Masao
On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas wrote: > Silence compiler warning about pointer type mismatch on some platforms. > > timeval.t_sec is of type time_t, which is not always compatible with long. > I'm not sure if this was just harmless warning or a real bug, but this > fixes it, a

Re: [COMMITTERS] pgsql: Disable _FORTIFY_SOURCE with ICC

2012-10-02 Thread Peter Geoghegan
On 30 September 2012 01:07, Peter Eisentraut wrote: > Disable _FORTIFY_SOURCE with ICC I'm having some problems of my own with this. Specifically: gcc -O0 -g -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-

[COMMITTERS] pgsql: In pg_upgrade, improve error reporting when the number of relati

2012-10-02 Thread Bruce Momjian
In pg_upgrade, improve error reporting when the number of relation objects does not match between the old and new clusters. Backpatch to 9.2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8a7598091a29ac13736ef8b70986921746648582 Modified Files -- contr

[COMMITTERS] pgsql: In pg_upgrade, improve error reporting when the number of relati

2012-10-02 Thread Bruce Momjian
In pg_upgrade, improve error reporting when the number of relation objects does not match between the old and new clusters. Backpatch to 9.2. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cbf99c7aa46d5be64b7adf8169129d5c1453dcdd Modified Files -

[COMMITTERS] pgsql: Adjust pg_upgrade query so toast tables related to system catalo

2012-10-02 Thread Bruce Momjian
Adjust pg_upgrade query so toast tables related to system catalog schema entries are not dumped. This fixes an error caused by droping/recreating the information_schema, but other failures were also possible. Backpatch to 9.2. Branch -- REL9_2_STABLE Details --- http://git.postgresql.o

[COMMITTERS] pgsql: Adjust pg_upgrade query so toast tables related to system catalo

2012-10-02 Thread Bruce Momjian
Adjust pg_upgrade query so toast tables related to system catalog schema entries are not dumped. This fixes an error caused by droping/recreating the information_schema, but other failures were also possible. Backpatch to 9.2. Branch -- master Details --- http://git.postgresql.org/pg/c

[COMMITTERS] pgsql: In pg_upgrade, try to convert the locale names to canonical form

2012-10-02 Thread Bruce Momjian
In pg_upgrade, try to convert the locale names to canonical form before comparison; also report the old/new values if they don't match. Backpatch to 9.2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b61837a49f4b4ea12e7ced8e3039ae98908c7c0b Modified Files ---

[COMMITTERS] pgsql: In pg_upgrade, try to convert the locale names to canonical form

2012-10-02 Thread Bruce Momjian
In pg_upgrade, try to convert the locale names to canonical form before comparison; also report the old/new values if they don't match. Backpatch to 9.2. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fe39bf0db64a99d401a2fdb0a219aefcbb406aa2 Modified Files

Re: [COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Heikki Linnakangas
On 02.10.2012 16:50, Tom Lane wrote: Heikki Linnakangas writes: Split off functions related to timeline history files and XLOG archiving. A large fraction of the buildfarm doesn't like this patch --- looks like you omitted some system headers that are required on only some platforms. Fixed,

[COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning or a real bug, but this fixes it, anyway. Branch -- master Details --- http://git.postgresql.o

[COMMITTERS] pgsql: Silence compiler warning about pointer type mismatch on some pla

2012-10-02 Thread Heikki Linnakangas
Silence compiler warning about pointer type mismatch on some platforms. timeval.t_sec is of type time_t, which is not always compatible with long. I'm not sure if this was just harmless warning or a real bug, but this fixes it, anyway. Branch -- REL9_2_STABLE Details --- http://git.postg

[COMMITTERS] pgsql: Allow a few seconds for Windows to catch up with a directory ren

2012-10-02 Thread Andrew Dunstan
Allow a few seconds for Windows to catch up with a directory rename when checking pg_upgrade. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/06623df63bc7debaad5b3239f2a4626b4c1d8855 Modified Files -- src/tools/msvc/vcregress.pl |5 - 1 files chan

[COMMITTERS] pgsql: Allow a few seconds for Windows to catch up with a directory ren

2012-10-02 Thread Andrew Dunstan
Allow a few seconds for Windows to catch up with a directory rename when checking pg_upgrade. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a50be771c80446d36771ff6c425a152e0d332315 Modified Files -- src/tools/msvc/vcregress.pl |5 - 1 fil

[COMMITTERS] pgsql: Add #includes needed on some platforms in the new files.

2012-10-02 Thread Heikki Linnakangas
Add #includes needed on some platforms in the new files. Hopefully this makes the *BSD buildfarm animals happy. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/93b6d78cf07cc886cd14edacc7d621ef330c513d Modified Files -- src/backend/access/transam/timeline

Re: [COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Tom Lane
Heikki Linnakangas writes: > Split off functions related to timeline history files and XLOG archiving. A large fraction of the buildfarm doesn't like this patch --- looks like you omitted some system headers that are required on only some platforms. regards, tom lane --

Re: [COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Simon Riggs
On 2 October 2012 11:39, Heikki Linnakangas wrote: > Split off functions related to timeline history files and XLOG archiving. > > This is just refactoring, to make the functions accessible outside xlog.c. > A followup patch will make use of that, to allow fetching timeline history > files over st

[COMMITTERS] pgsql: Split off functions related to timeline history files and XLOG a

2012-10-02 Thread Heikki Linnakangas
Split off functions related to timeline history files and XLOG archiving. This is just refactoring, to make the functions accessible outside xlog.c. A followup patch will make use of that, to allow fetching timeline history files over streaming replication. Branch -- master Details --- h

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3e291cab0829f48215061a67cc07371cca3cf2e1 Modified Files --

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/61540e6d71764cd595bef7add8d7c5a329547448 Modified Files --

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/23355e6cb9272cde1b695a3c6228e8e8186d59f4 Modified Files --

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6c00b2bbf7726efdf7d96ad5c9e9ef0450d2a150 Modified Files --

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/43dfc5cac38b41365f512e237e12572f180b2883 Modified Files --

[COMMITTERS] pgsql: Fix access past end of string in date parsing.

2012-10-02 Thread Heikki Linnakangas
Fix access past end of string in date parsing. This affects date_in(), and a couple of other funcions that use DecodeDate(). Hitoshi Harada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0899556e92958712cc31953497b82657cc706f94 Modified Files -- src/ba