Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Tom Lane
"Erik Rijkers" writes: > On Tue, February 12, 2013 17:19, Alvaro Herrera wrote: >> I'm not sure are you suggesting, though. Are you saying that the commit >> message should explicitely state "this patch requires initdb" or some >> such? > I was under the impression that this was habitually done

Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Erik Rijkers
On Tue, February 12, 2013 17:19, Alvaro Herrera wrote: > Erik Rijkers wrote: >> On Tue, February 12, 2013 17:01, Alvaro Herrera wrote: >> > Erik Rijkers wrote: >> >> On Tue, February 12, 2013 15:55, Alvaro Herrera wrote: >> >> > Create libpgcommon, and move pg_malloc et al to it >> >> > >> >> >> >>

Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Erik Rijkers
On Tue, February 12, 2013 17:01, Alvaro Herrera wrote: > Erik Rijkers wrote: >> On Tue, February 12, 2013 15:55, Alvaro Herrera wrote: >> > Create libpgcommon, and move pg_malloc et al to it >> > >> >> If at all possible, it would be handy (for testers) if initdb-forcing >> commits are flagged as

Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Alvaro Herrera
Erik Rijkers wrote: > On Tue, February 12, 2013 17:01, Alvaro Herrera wrote: > > Erik Rijkers wrote: > >> On Tue, February 12, 2013 15:55, Alvaro Herrera wrote: > >> > Create libpgcommon, and move pg_malloc et al to it > >> > > >> > >> If at all possible, it would be handy (for testers) if initdb-f

Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Alvaro Herrera
Erik Rijkers wrote: > On Tue, February 12, 2013 15:55, Alvaro Herrera wrote: > > Create libpgcommon, and move pg_malloc et al to it > > > > If at all possible, it would be handy (for testers) if initdb-forcing commits > are flagged as such. Hmm? I don't think this patch requires an initdb at al

Re: [COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Erik Rijkers
On Tue, February 12, 2013 15:55, Alvaro Herrera wrote: > Create libpgcommon, and move pg_malloc et al to it > If at all possible, it would be handy (for testers) if initdb-forcing commits are flagged as such. (it's not a big deal but I often have large databases in a dev/test-setup that take a

[COMMITTERS] pgsql: Rename "string" pstrdup argument to "in"

2013-02-12 Thread Alvaro Herrera
Rename "string" pstrdup argument to "in" The former name collides with a symbol also used in the isolation test's parser, causing assorted failures in certain platforms. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0e81ddde2c62ada7f818114ca961d80d42370e32 Modifie

[COMMITTERS] pgsql: Don't build libpgcommon_srv.a just yet

2013-02-12 Thread Alvaro Herrera
Don't build libpgcommon_srv.a just yet It's empty, and some archivers do not support that case. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0f980b0e17d95e77dc2822eb7855d072a5874d9a Modified Files -- src/common/Makefile |2 +- 1 files changed, 1 in

[COMMITTERS] pgsql: Create libpgcommon, and move pg_malloc et al to it

2013-02-12 Thread Alvaro Herrera
Create libpgcommon, and move pg_malloc et al to it libpgcommon is a new static library to allow sharing code among the various frontend programs and backend; this lets us eliminate duplicate implementations of common routines. We avoid libpgport, because that's intended as a place for porting iss

Re: [COMMITTERS] pgsql: Add noreturn attributes to some error reporting functions

2013-02-12 Thread Andres Freund
On 2013-02-12 12:14:06 +, Peter Eisentraut wrote: > Add noreturn attributes to some error reporting functions I wonder if its time to add a macro for this instead of slapping __attribute__((noreturn)) everywhere. That way msvc had a chance of adding __declspec(noreturn) or whatever its magic i

[COMMITTERS] pgsql: Add noreturn attributes to some error reporting functions

2013-02-12 Thread Peter Eisentraut
Add noreturn attributes to some error reporting functions Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0cb1fac3b19f01025b63d2cdceabb8767185da28 Modified Files -- contrib/cube/cubescan.l|2 +- contrib/seg/segscan.l |